Skip to content

Account for Arcs and lazy being dropped - #651

Merged
tnull merged 5 commits into
lightningdevkit:mainfrom
tnull:2025-09-fix-lazy-remove
Oct 10, 2025
Merged

Account for Arcs and lazy being dropped#651
tnull merged 5 commits into
lightningdevkit:mainfrom
tnull:2025-09-fix-lazy-remove

Conversation

@tnull

@tnulltnull commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

Based on #650.

We fix two more minor API changes that have been merged on LDK.

@ldk-reviews-bot

ldk-reviews-bot commented Sep 25, 2025•
edited
Loading

Copy link
Copy Markdown

I've assigned @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull
tnull marked this pull request as draft September 25, 2025 14:24
@tnull
tnull changed the base branch from main to developSeptember 30, 2025 07:53
@tnull
tnullforce-pushed the 2025-09-fix-lazy-remove branch from 6129097 to 3c695a0CompareSeptember 30, 2025 08:17
@tnull
tnull changed the base branch from develop to mainOctober 7, 2025 08:52
@tnull

tnull commented Oct 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

We decided to make the develop behavior (tracking more-recent LDK main) the default behavior. With #655 we merged develop into main and now deleted the develop branch. Hence the base branch is changed to main here, too.

@tnull
tnullforce-pushed the 2025-09-fix-lazy-remove branch from 3c695a0 to 9ec89feCompareOctober 8, 2025 09:48
@tnull

tnull commented Oct 8, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Rebased on main now that #650 has been merged. Ready for review.

@tnull
tnull marked this pull request as ready for review October 8, 2025 09:48
@tnulltnull added this to the 0.7 milestone Oct 8, 2025
@tnulltnull moved this to Goal: Merge in Weekly GoalsOct 9, 2025
@tnulltnull self-assigned this Oct 9, 2025
jkczyz
jkczyz approved these changes Oct 9, 2025
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though CI is failing.

@tnull

tnull commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

LGTM, though CI is failing.

Yeah, very flaky currently unfortunately.

@tnull
tnull merged commit 98d2148 into lightningdevkit:mainOct 10, 2025
0 of 15 checks passed
@github-project-automationgithub-project-automationBot moved this from Goal: Merge to Done in Weekly GoalsOct 10, 2025
@joostjagerjoostjager mentioned this pull request Nov 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees

@tnulltnull

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz