Uh oh!
There was an error while loading. Please reload this page.
Bump to latest LDK main - #659
Conversation
👋 Thanks for assigning @joostjager as a reviewer! |
- We fix an oversight introduced in 9977903 where we switched `Cargo.toml` to use local dependencies instead of pointing to an appropriate upstream commit - We account for Splicing-related events - We account for `KeysManager` taking a new flag for v2-payment-key derivation.
ef393bf to
2276157Compare| LdkEvent::SplicePending { .. } => { | ||
| debug_assert!( | ||
| false, | ||
| "We currently don't support splicing, so this event should never be emitted." |
There was a problem hiding this comment.
Just to double check - no splicing api is exposed in ldk-node and therefore this should never happen? I don't know the api, but is it possible for the counterparty to initiate this and get us to move along?
There was a problem hiding this comment.
Yes, there is a new reject_inbound_splices on UserConfig that defaults to true. So we'll have to manually opt into splicing support as part of the integration PR.
Uh oh!
There was an error while loading. Please reload this page.
Cargo.tomlto use local dependencies instead of pointing to an appropriate upstream commitKeysManagertaking a new flag for v2-payment-key derivation.