Asyncify test suite and reintroduce VSS-internal runtime by tnull · Pull Request #670 · lightningdevkit/ldk-node

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull · 2025-10-17T11:08:02Z

As we're looking to move to a more async-friendly API over time (which would allow us to drop the dependency on the KVStoreSync implementation entirely), we here make a few prefactors and minor improvements that move in that direction.

Most notably, we switch to have our tests run in async contexts, which also should make them more efficient as not every node will spawn its own runtime, but rather reuse the one runtime spawned for each test case.

Moreover, we reintroduce a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

.. as we're about to `cargo test` anyways.

.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

ldk-reviews-bot · 2025-10-17T11:08:05Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2025-10-20T00:00:29Z

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-21T15:18:05Z

Now added changes reintroducing a secondary runtime internal to VssStore in order to fix the blocking issue we recently hit in our CI. Additionally, we found that not all tests cfg-gated under vss_test were being run, so we fix these test cases and have them run in CI.

joostjager

PR could have been split up in independent changes, but perhaps too late now.

The whole rust async situation is so painful. It really seems to get to the point - if it wasn't already there - of being a true velocity killer.

tnull

Addressed remaining comments.

tnull · 2025-10-27T15:08:11Z

CI failure is unrelated: #679

tnull · 2025-10-28T08:37:27Z

Addressed pending feedback.

@joostjager let me know if I can squash.

Given we regularly run into issues arising from mixing sync and async contexts, we here simplify our `EventQueue` implementation by avoiding to use `Condvar::wait_while` (which parks the current thread) and rather simply us `block_on` on our `next_event_async` method.

.. as LDK Node is moving towards a more `async` core, it starts to make sense to switch our test suite over to be `async`. This change should make our CI more efficient (as not every node will spawn its independent runtime, but we just have one runtime per test created) and also makes sure we won't run into any edge cases arising from blocking test threads that are executing other async tasks.

Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

In order to avoid the recently, discovered blocking-task-deadlock (in which the task holding the runtime reactor got blocked and hence stopped polling VSS write tasks), we where re-introduce an internal runtime to the `VssStore`, on which we spawn the tasks, while still using `block_on` of our regular runtime for async-sync conversions. This also finally fixes our VSS CI.

.. we previously avoided running some tests which turned out to be broken.

joostjager

Remaining questions answered offline and summarized in threads. LGTM

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

tnull added 2 commits October 17, 2025 12:59

Drop superfluous cargo build step
edff34c
.. as we're about to `cargo test` anyways.

Add missing error logs for ReadFailed cases
ae98bef
.. some of the `ReadFailed` cases didn't log why they failed. Here we fix that oversight.

tnull requested a review from joostjager October 17, 2025 11:08

tnull force-pushed the 2025-10-asyncify-more-things branch 3 times, most recently from f817f78 to 141f186Compare October 17, 2025 11:21

joostjager reviewed Oct 20, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadtests/reorg_test.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from e6e2073 to 584fff6Compare October 21, 2025 15:11

tnull changed the title ~~Asyncify test suite and event queue~~Asyncify test suite and reintroduce VSS-internal runtimeOct 21, 2025

tnull requested a review from joostjager October 21, 2025 15:17

tnull force-pushed the 2025-10-asyncify-more-things branch 7 times, most recently from 6d3a774 to eedfb12Compare October 21, 2025 21:31

joostjager reviewed Oct 23, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadsrc/event.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/runtime.rs
Comment threadsrc/lib.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs

tnull force-pushed the 2025-10-asyncify-more-things branch from eedfb12 to dba502dCompare October 27, 2025 12:52

tnull commented Oct 27, 2025
View reviewed changes

Comment threadsrc/lib.rs
Comment threadtests/integration_tests_cln.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/io/vss_store.rs
Comment threadsrc/runtime.rs

tnull force-pushed the 2025-10-asyncify-more-things branch 2 times, most recently from 300e9bb to 4622fb1Compare October 27, 2025 13:08

tnull requested a review from joostjager October 27, 2025 15:02

tnull mentioned this pull request Oct 27, 2025
Use Rust server in CI and add LDK Node integration tests lightningdevkit/vss-server#62
Merged

tnull force-pushed the 2025-10-asyncify-more-things branch from 4622fb1 to e4f3ba0Compare October 28, 2025 08:36

tnull added 5 commits October 28, 2025 10:23

Add async { ..await } in remaining places
8512c26
Since it seems to make a difference to `tokio` (see https://docs.rs/tokio/latest/tokio/time/fn.timeout.html#panics) we make sure the futures are always put in an `async` closure.

Fix and run all tests under cfg(vss_test)
8cad63b
.. we previously avoided running some tests which turned out to be broken.

tnull force-pushed the 2025-10-asyncify-more-things branch from e4f3ba0 to 8cad63bCompare October 28, 2025 09:23

joostjager approved these changes Oct 28, 2025
View reviewed changes

tnull merged commit d984aca into lightningdevkit:mainOct 28, 2025
6 of 15 checks passed

tnull mentioned this pull request Oct 28, 2025
Channel splicing support #677
Merged

joostjager mentioned this pull request Nov 19, 2025
Add draft changelog for LDK Node v0.7.0 #708
Merged

Uh oh!

Conversation

tnull commented Oct 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Oct 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Oct 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnull commented Oct 21, 2025

Uh oh!

joostjager left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnull commented Oct 27, 2025

Uh oh!

tnull commented Oct 28, 2025

Uh oh!

joostjager left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tnull commented Oct 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Oct 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Oct 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnull commented Oct 21, 2025

Uh oh!

joostjager left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnull commented Oct 17, 2025•
edited
Loading

ldk-reviews-bot commented Oct 17, 2025•
edited
Loading

tnull commented Oct 17, 2025•
edited
Loading

ldk-reviews-bot commented Oct 17, 2025•
edited
Loading

tnull commented Oct 17, 2025•
edited
Loading

ldk-reviews-bot commented Oct 17, 2025•
edited
Loading