Uh oh!
There was an error while loading. Please reload this page.
Switch to async background processing and cleanup runtime handling. - #68
Merged
tnull merged 2 commits intoApr 26, 2023
Merged
Conversation
tnullforce-pushed
the
2023-03-async-background-processing
branch
from
April 21, 2023 12:42
a84efca to
ac7dffaComparejkczyz
reviewed
Apr 25, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tnullforce-pushed
the
2023-03-async-background-processing
branch
from
April 26, 2023 08:44
ac7dffa to
f175e79Comparetnull
commented
Apr 26, 2023
CollaboratorAuthor
Rebased on #71. |
jkczyz
reviewed
Apr 26, 2023
Uh oh!
There was an error while loading. Please reload this page.
We switch to an async BP as upstream now allows us to.
So far we instantiated a dedicated `Runtime` object which also held the BP. This was clunky and somewhat error-prone under different circumstances. As we now got rid of the BP object, we here remove the dedicated `Runtime` object and just pass around an `Arc<RwLock<Option<Runtime>>>` upon init, which allows us to get rid of the `set`/`drop` methods on `Wallet` as an added benefit.
tnullforce-pushed
the
2023-03-async-background-processing
branch
from
April 26, 2023 15:35
f175e79 to
944a8e2Comparetnull
commented
Apr 26, 2023
CollaboratorAuthor
Rebased on main now that 0.0.115 is in. |
jkczyz
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#37~~, currently based on lightningdevkit/rust-lightning#2199.~~
We switch to an async BP as upstream now allows us to.
We furthermore cleanup our runtime handling:
So far we instantiated a dedicated
Runtimeobject which also held the BP. This was clunky and somewhat error-prone under different circumstances. As we now got rid of the BP object, we here remove the dedicatedRuntimeobject and just pass around anArc<RwLock<Option<Runtime>>>upon init, which allows us to get rid of theset/dropmethods onWalletas an added benefit.