Uh oh!
There was an error while loading. Please reload this page.
Only use internal runtime in VssStore - #693
Conversation
👋 I see @joostjager was un-assigned. |
db2db6d to
6792792Comparejoostjager
commented
Nov 3, 2025
IIRC the previous hang was reproducible locally. Is that still the case with the hang that this PR fixes? |
We previously attempted to drop the internal runtime from `VssStore`, resulting into blocking behavior. While we recently made changes that improved our situation (having VSS CI pass again pretty reliably), we just ran into yet another case where the VSS CI hung (cf. https://github.com/lightningdevkit/vss-server/actions/runs/19023212819/job/54322173817?pr=59). Here we attempt to restore even more of the original pre- ab3d78d / lightningdevkit#623 behavior to get rid of the reappearing blocking behavior, i.e., only use the internal runtime in `VssStore`.
6792792 to
615c24aComparetnull
commented
Nov 3, 2025
Unfortunately it's not. And after kicking CI on lightningdevkit/vss-server#59, the flake went away (just as CI in generally now seemed to 'reliably' pass). I am worried though that it might reappear randomly in production. |
joostjager
commented
Nov 3, 2025
Is it reproducible by putting a loop around the test in Ci? To ensure that this PR really tackles the problem. |
4f5a9bf to
7456b95Compare51c92e2 to
e94fe69Compare837f83f to
2911920Comparetnull
commented
Nov 6, 2025
Closing this as we added the main changes to #627, given that otherwise they'd only introduce unnecessary conflicts and rebase pain. |
We previously attempted to drop the internal runtime from
VssStore, resulting into blocking behavior. While we recently made changes that improved our situation (having VSS CI pass again pretty reliably), we just ran into yet another case where the VSS CI hung (cf. https://github.com/lightningdevkit/vss-server/actions/runs/19023212819/job/54322173817?pr=59).Here we attempt to restore even more of the original pre- ab3d78d / #623 behavior to get rid of the reappearing blocking behavior, i.e., only use the internal runtime in
VssStore.