Skip to content

Add explicit type definition for ChannelDetails#703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 1 commit into from
Nov 14, 2025
Merged

Add explicit type definition for ChannelDetails #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -133,7 +133,7 @@ use io::utils::write_node_metrics;
use lightning::chain::BestBlock;
use lightning::events::bump_transaction::Wallet as LdkWallet;
use lightning::impl_writeable_tlv_based;
use lightning::ln::channel_state::ChannelShutdownState;
use lightning::ln::channel_state::{ChannelDetails as LdkChannelDetails, ChannelShutdownState};
use lightning::ln::channelmanager::PaymentId;
use lightning::ln::msgs::SocketAddress;
use lightning::routing::gossip::NodeAlias;
Expand DownExpand Up@@ -1289,7 +1289,7 @@ impl Node {
force_close_reason.is_none() || force,
"Reason can only be set for force closures"
);
let open_channels =
let open_channels: Vec<LdkChannelDetails> =
self.channel_manager.list_channels_with_counterparty(&counterparty_node_id);
if let Some(channel_details) =
open_channels.iter().find(|c| c.user_channel_id == user_channel_id.0)
Expand DownExpand Up@@ -1328,7 +1328,7 @@ impl Node {
&self, user_channel_id: &UserChannelId, counterparty_node_id: PublicKey,
channel_config: ChannelConfig,
) -> Result<(), Error> {
let open_channels =
let open_channels: Vec<LdkChannelDetails> =
self.channel_manager.list_channels_with_counterparty(&counterparty_node_id);
if let Some(channel_details) =
open_channels.iter().find(|c| c.user_channel_id == user_channel_id.0)
Expand Down