Uh oh!
There was an error while loading. Please reload this page.
bitcoind chain source: Poll tip before intialization - #706
Merged
Conversation
In the following commits we will use the chain source to poll a best tip before intializing the listener objects. As a prefactor, we here move the creation of our onchain wallet after creation of the chain source, which in turn means we'll need to use the same pattern as for the other listeners, i.e., not giving the wallet reference to `ChainSource` on creation but rather handing it in when it's being used at runtime.
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
previously approved these changes
Nov 18, 2025
benthecarman
left a comment
Contributor
There was a problem hiding this comment.
small nit otherwise lgtm.
modified the bitcoind tests to first mine 5k blocks and checked the logs, looked like we aren't syncing every block anymore, Finished synchronizing listeners in 6958ms went to 3ms
| let best_block = chain_tip_opt.unwrap_or_else(|| { | ||
| let genesis_block_hash = | ||
| bitcoin::blockdata::constants::genesis_block(config.network).block_hash(); | ||
| BestBlock::new(genesis_block_hash, 0) |
Contributor
There was a problem hiding this comment.
you can just do BestBlock::from_network instead of grabbing the genesis block yourself
Previously, we couldn't poll the chain tip in `Builder::build` as we wouldn't have a runtime available. Since we now do, we can at least attempt to poll for the chain tip before initializing objects, avoiding that fresh nodes need to re-validate everything from genesis.
tnullforce-pushed
the
2025-11-poll-tip-on-init
branch
from
November 18, 2025 14:38
88605f3 to
c0880d9Comparetnull
commented
Nov 18, 2025
CollaboratorAuthor
Force-pushed with the following changes: git diff-tree -U2 88605f34 c0880d9d
diff --git a/src/builder.rs b/src/builder.rs
index 3880e573..183c7513 100644
--- a/src/builder.rs+++ b/src/builder.rs@@ -1525,9 +1525,6 @@ fn build_with_store_internal(
} else {
// We're starting a fresh node.
- let best_block = chain_tip_opt.unwrap_or_else(|| {- let genesis_block_hash =- bitcoin::blockdata::constants::genesis_block(config.network).block_hash();- BestBlock::new(genesis_block_hash, 0)- });+ let best_block =+ chain_tip_opt.unwrap_or_else(|| BestBlock::from_network(config.network));
let chain_params = ChainParameters { network: config.network.into(), best_block }; |
benthecarman
approved these changes
Nov 18, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#415.
Previously, we couldn't poll the chain tip in
Builder::buildas we wouldn't have a runtime available. Since we now do, we can at least attempt to poll for the chain tip before initializing objects, avoiding that fresh nodes need to re-validate everything from genesis.