') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Minor follow-ups to #666 by tnull · Pull Request #740 · lightningdevkit/ldk-node · GitHub
Skip to content

Minor follow-ups to #666 - #740

Merged
tnull merged 3 commits into
lightningdevkit:mainfrom
tnull:2026-01-bitcoin-payment-instructions-follow-up
Jan 9, 2026
Merged

Minor follow-ups to #666#740
tnull merged 3 commits into
lightningdevkit:mainfrom
tnull:2026-01-bitcoin-payment-instructions-follow-up

Conversation

@tnull

@tnulltnull commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

We make some minor adjustments after #666 landed.

(cc @chuksys)

@ldk-reviews-bot

ldk-reviews-bot commented Jan 6, 2026•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

chuksys
chuksys reviewed Jan 6, 2026
View reviewed changes

@chuksyschuksys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up 🙏. Just a few observations.

Comment threadsrc/payment/unified.rs Outdated
Comment threadsrc/payment/unified.rs
@tnull
tnullforce-pushed the 2026-01-bitcoin-payment-instructions-follow-up branch 3 times, most recently from 6ff2d7f to aff52a5CompareJanuary 7, 2026 08:45
tankyleo
tankyleo reviewed Jan 7, 2026
View reviewed changes
Comment threadsrc/payment/unified.rs Outdated

/// A payment handler allowing to create [BIP 21] URIs with an on-chain, [BOLT 11], and [BOLT 12] payment
/// option.
/// A payment handler that supports creating and paying to [BIP 21] URIs with an on-chain, [BOLT 11],

@tankyleotankyleoJan 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "with on-chain" for consistency

@tnulltnullJan 8, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, that slipped through:

> git diff-tree -U2 aff52a58 8f63a279diff --git a/src/payment/unified.rs b/src/payment/unified.rs
index 3184c847..671af14f 100644
--- a/src/payment/unified.rs+++ b/src/payment/unified.rs@@ -47,5 +47,5 @@ struct Extras {
}
-/// A payment handler that supports creating and paying to [BIP 21] URIs with an on-chain, [BOLT 11],+/// A payment handler that supports creating and paying to [BIP 21] URIs with on-chain, [BOLT 11],
/// and [BOLT 12] payment options.
///

@tnull
tnullforce-pushed the 2026-01-bitcoin-payment-instructions-follow-up branch from aff52a5 to 8f63a27CompareJanuary 8, 2026 08:45
@tnull
tnull requested a review from tankyleoJanuary 8, 2026 08:46
tankyleo
tankyleo reviewed Jan 8, 2026
View reviewed changes

@tankyleotankyleo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll need a rebase before merge

@tnull
tnullforce-pushed the 2026-01-bitcoin-payment-instructions-follow-up branch from 8f63a27 to 675d644CompareJanuary 9, 2026 08:38
@tnull
tnull requested a review from tankyleoJanuary 9, 2026 08:39
@tnull
tnullforce-pushed the 2026-01-bitcoin-payment-instructions-follow-up branch from 675d644 to b167ef6CompareJanuary 9, 2026 08:57
@tnull
tnull merged commit 1f51948 into lightningdevkit:mainJan 9, 2026
17 of 18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes
+1 more reviewer
@chuksyschuksyschuksys approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tnull@ldk-reviews-bot@chuksys@tankyleo