') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add Payjoin Receiver Support (BIP 77) by Camillarhi · Pull Request #746 · lightningdevkit/ldk-node · GitHub
Skip to content

Add Payjoin Receiver Support (BIP 77) - #746

Open
Camillarhi wants to merge 1 commit into
lightningdevkit:mainfrom
Camillarhi:payjoin-receiver
Open

Add Payjoin Receiver Support (BIP 77)#746
Camillarhi wants to merge 1 commit into
lightningdevkit:mainfrom
Camillarhi:payjoin-receiver

Conversation

@Camillarhi

@CamillarhiCamillarhi commented Jan 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds support for receiving payjoin payments in LDK Node. This is currently a work in progress and implements the receiver side of the payjoin protocol.

  • Add session store for persisting payjoin receiver events across restarts
  • Implement KVStorePayjoinReceiverPersister to handle session persistence
  • Add Payjoin as a PaymentKind to the payment store
  • Add event polling mechanism for active payjoin sessions
  • Wire up payjoin payment request and receive flows

Note on persistence: The payjoin library currently only supports synchronous persistence, but they're working on adding async support(payjoin/rust-payjoin#1235). This PR sets up the persistence structure (KVStorePayjoinReceiverPersister), which will be updated to use async operations once the upstream PR is merged.

This PR partially fixes#177 and fixes#1019

@ldk-reviews-bot

ldk-reviews-bot commented Jan 8, 2026•
edited
Loading

Copy link
Copy Markdown

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

@DanGouldDanGould mentioned this pull request Jan 9, 2026
Closed
30 tasks
@DanGould

DanGould commented Jan 23, 2026

Copy link
Copy Markdown

We've merged the async persistence PR you mentioned. You might want to build your draft PR on the merged commit from there on until we cut you a release.

@Camillarhi

Camillarhi commented Jan 23, 2026

Copy link
Copy Markdown
ContributorAuthor

We've merged the async persistence PR you mentioned. You might want to build your draft PR on the merged commit from there on until we cut you a release.

Thanks for letting me know. I'll build on the merged commit.

@Camillarhi
Camillarhiforce-pushed the payjoin-receiver branch 5 times, most recently from 8f6ba65 to 6499918CompareJanuary 30, 2026 10:36
@DanGould

DanGould commented Feb 10, 2026

Copy link
Copy Markdown

Are you stuck? Did something in our library break CI @Camillarhi

@Camillarhi

Camillarhi commented Feb 10, 2026

Copy link
Copy Markdown
ContributorAuthor

Are you stuck? Did something in our library break CI @Camillarhi

Not stuck at all. I was just closing out some other PRs. Still working on this one, I'll let you know when it's ready.

@Camillarhi
Camillarhiforce-pushed the payjoin-receiver branch 2 times, most recently from 12a41ad to eb97832CompareFebruary 18, 2026 23:21
@Camillarhi
Camillarhiforce-pushed the payjoin-receiver branch 3 times, most recently from 120b089 to 8cc2a31CompareFebruary 23, 2026 15:03
@Camillarhi
Camillarhiforce-pushed the payjoin-receiver branch 10 times, most recently from 5fe1a5c to 0411adaCompareMarch 12, 2026 09:45
@Camillarhi
Camillarhi marked this pull request as ready for review March 12, 2026 09:50
@Camillarhi

Camillarhi commented Mar 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Marking this as ready for review.

The core receiver flow is implemented, including session persistence, PSBT handling, input contribution, mempool monitoring for payjoin transactions, and node restart recovery.

Two things still pending that I'll follow up with:

  • Integration tests
  • Processing/updating confirmation state for payjoin transactions in the payment and pending payment stores

Happy to get early feedback on the overall approach in the meantime.

@tnull@DanGould

@ldk-reviews-bot

ldk-reviews-bot commented Jun 13, 2026

Copy link
Copy Markdown

🔔 15th Reminder

Hey @tnull@DanGould@zealsham@spacebear21! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot

ldk-reviews-bot commented Jun 13, 2026

Copy link
Copy Markdown

🔔 15th Reminder

Hey @tnull@DanGould@zealsham@spacebear21! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 15, 2026

Copy link
Copy Markdown

🔔 17th Reminder

Hey @tnull@DanGould@zealsham@spacebear21! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot

ldk-reviews-bot commented Jun 15, 2026

Copy link
Copy Markdown

🔔 17th Reminder

Hey @tnull@DanGould@zealsham@spacebear21! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 15, 2026

Copy link
Copy Markdown

🔔 16th Reminder

Hey @tnull@DanGould@zealsham@spacebear21! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot

ldk-reviews-bot commented Jun 15, 2026

Copy link
Copy Markdown

🔔 16th Reminder

Hey @tnull@DanGould@zealsham@spacebear21! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

spacebear21
spacebear21 reviewed Jun 16, 2026
View reviewed changes

@spacebear21spacebear21 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave @Camillarhi minor feedback out-of-band, overall looks good to me but seems like this is blocked by #791 for the time being. Can we turn off the noisy PR review reminder bot for this PR?

@Camillarhi

Camillarhi commented Jun 16, 2026

Copy link
Copy Markdown
ContributorAuthor

I gave @Camillarhi minor feedback out-of-band, overall looks good to me but seems like this is blocked by #791 for the time being.

Thanks. I’m keeping an eye on spesmilo/electrum-protocol#2 which adds testmempoolaccept support, that would allow broadcast suitability checks so a node supporting payjoin payments won’t be limited to just bitcoind as a chain source.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 17, 2026

Copy link
Copy Markdown

🔔 18th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 17, 2026

Copy link
Copy Markdown

🔔 17th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot

ldk-reviews-bot commented Jun 17, 2026

Copy link
Copy Markdown

🔔 17th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 20, 2026

Copy link
Copy Markdown

🔔 19th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 20, 2026

Copy link
Copy Markdown

🔔 18th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot

ldk-reviews-bot commented Jun 20, 2026

Copy link
Copy Markdown

🔔 18th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 22, 2026

Copy link
Copy Markdown

🔔 20th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 22, 2026

Copy link
Copy Markdown

🔔 19th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot

ldk-reviews-bot commented Jun 22, 2026

Copy link
Copy Markdown

🔔 19th Reminder

Hey @tnull@DanGould@zealsham! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@tnull

tnull commented Jun 23, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

As mentioned elsewhere, we'll defer this to the 0.9 milestone. For now removed the review requests to silence the 5-fold notifications every day. Still ofc. intend to get back to this soon though.

@tnull
tnull removed their request for review June 23, 2026 11:38
@tnulltnull added this to the 0.9 milestone Jun 23, 2026
bc1cindy
bc1cindy reviewed Jul 9, 2026
View reviewed changes
Comment threadsrc/wallet/mod.rs Outdated
@Camillarhi
Camillarhiforce-pushed the payjoin-receiver branch 3 times, most recently from 33e6724 to 231c5bbCompareJuly 21, 2026 17:24
@Camillarhi
Add payjoin v2 receiver flow
5a9bf22
Implements the receiver side of the BIP 77 Payjoin v2 protocol, allowing
LDK Node users to receive payjoin payments via a payjoin directory and
OHTTP relay.
- Adds a `PayjoinPayment` handler exposing a `receive()` method that returns
a BIP 21 URI the sender can use to initiate the payjoin flow. The full
receiver state machine is implemented covering all `ReceiveSession` states:
polling the directory, validating the sender's proposal, contributing
inputs, finalizing the PSBT, and monitoring the mempool.
- Session state is persisted via `KVStorePayjoinReceiverPersister` and
survives node restarts through event log replay. Sender inputs are tracked
by `OutPoint` across polling attempts to prevent replay attacks. The
sender's fallback transaction is broadcast on cancellation or failure to
ensure the receiver still gets paid.
- Adds `PaymentKind::Payjoin` to the payment store, `PayjoinConfig` for
configuring the payjoin directory and OHTTP relay via
`Builder::set_payjoin_config`, and background tasks for session resumption
every 15 seconds and cleanup of terminal sessions after 24 hours.
@bc1cindybc1cindy mentioned this pull request Jul 28, 2026
Closed
@CamillarhiCamillarhi mentioned this pull request Aug 4, 2026
Open
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull left review comments
+5 more reviewers
@DanGouldDanGouldDanGould left review comments
@zealshamzealshamzealsham left review comments
@benallengbenallengbenalleng left review comments
@spacebear21spacebear21spacebear21 left review comments
@bc1cindybc1cindybc1cindy left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9

Development

Successfully merging this pull request may close these issues.

Payjoin V2 (BIP 77) integration Explore integration of Payjoin/PDK

8 participants

@Camillarhi@ldk-reviews-bot@DanGould@bc1cindy@spacebear21@tnull@zealsham@benalleng