Skip to content

Add matrix testing for VSS authorizer variants - #786

Closed
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage
Closed

Add matrix testing for VSS authorizer variants#786
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage

Conversation

@enigbe

Copy link
Copy Markdown
Contributor

What this PR does

With the addition of a public key-based authenticator and the option to verify JWT tokens on vss-server, the default vss-server build now requires authentication, so our integration tests need to either provide valid headers or explicitly build for the no-opauthenticator. This is why the VSS CI has been failing lately.

To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds vss-server with the appropriate flags and passes the corresponding cfg flag and features to the test runner.

The summary of changes introduced include:

  • Passing authorizer-specific cfg flags and features for test differentiation
  • The addition of test_utils feature with JWT- and signature-based header generation
  • The addition of RSA keypair fixtures for JWT signing and verification
  • The update of VSS-related tests to use auth-aware headers

Run VSS integration tests against multiple server authorizer
configurations (noop, sig, jwt). Each matrix job builds the
vss-server with the appropriate flags and passes the corresponding
cfg flag to the test runner.
- Use release builds for vss-server
- Pass authorizer-specific cfg flags for test differentiation
- Add `test_utils` feature with JWT and signature-based header generation
- Add RSA keypair fixtures for JWT signing
- Update VSS tests to use auth-aware headers
@ldk-reviews-bot

ldk-reviews-bot commented Feb 6, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.

@enigbe

Copy link
Copy Markdown
ContributorAuthor

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

@enigbeenigbe closed this Feb 6, 2026
@tnull

tnull commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

Yeah, thank you for that!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@enigbe@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add matrix testing for VSS authorizer variants by enigbe · Pull Request #786 · lightningdevkit/ldk-node · GitHub
Skip to content

Add matrix testing for VSS authorizer variants - #786

Closed
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage
Closed

Add matrix testing for VSS authorizer variants#786
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage

Conversation

@enigbe

Copy link
Copy Markdown
Contributor

What this PR does

With the addition of a public key-based authenticator and the option to verify JWT tokens on vss-server, the default vss-server build now requires authentication, so our integration tests need to either provide valid headers or explicitly build for the no-opauthenticator. This is why the VSS CI has been failing lately.

To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds vss-server with the appropriate flags and passes the corresponding cfg flag and features to the test runner.

The summary of changes introduced include:

  • Passing authorizer-specific cfg flags and features for test differentiation
  • The addition of test_utils feature with JWT- and signature-based header generation
  • The addition of RSA keypair fixtures for JWT signing and verification
  • The update of VSS-related tests to use auth-aware headers

Run VSS integration tests against multiple server authorizer
configurations (noop, sig, jwt). Each matrix job builds the
vss-server with the appropriate flags and passes the corresponding
cfg flag to the test runner.
- Use release builds for vss-server
- Pass authorizer-specific cfg flags for test differentiation
- Add `test_utils` feature with JWT and signature-based header generation
- Add RSA keypair fixtures for JWT signing
- Update VSS tests to use auth-aware headers
@ldk-reviews-bot

ldk-reviews-bot commented Feb 6, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.

@enigbe

Copy link
Copy Markdown
ContributorAuthor

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

@enigbeenigbe closed this Feb 6, 2026
@tnull

tnull commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

Yeah, thank you for that!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@enigbe@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add matrix testing for VSS authorizer variants by enigbe · Pull Request #786 · lightningdevkit/ldk-node · GitHub
Skip to content

Add matrix testing for VSS authorizer variants - #786

Closed
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage
Closed

Add matrix testing for VSS authorizer variants#786
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage

Conversation

@enigbe

Copy link
Copy Markdown
Contributor

What this PR does

With the addition of a public key-based authenticator and the option to verify JWT tokens on vss-server, the default vss-server build now requires authentication, so our integration tests need to either provide valid headers or explicitly build for the no-opauthenticator. This is why the VSS CI has been failing lately.

To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds vss-server with the appropriate flags and passes the corresponding cfg flag and features to the test runner.

The summary of changes introduced include:

  • Passing authorizer-specific cfg flags and features for test differentiation
  • The addition of test_utils feature with JWT- and signature-based header generation
  • The addition of RSA keypair fixtures for JWT signing and verification
  • The update of VSS-related tests to use auth-aware headers

Run VSS integration tests against multiple server authorizer
configurations (noop, sig, jwt). Each matrix job builds the
vss-server with the appropriate flags and passes the corresponding
cfg flag to the test runner.
- Use release builds for vss-server
- Pass authorizer-specific cfg flags for test differentiation
- Add `test_utils` feature with JWT and signature-based header generation
- Add RSA keypair fixtures for JWT signing
- Update VSS tests to use auth-aware headers
@ldk-reviews-bot

ldk-reviews-bot commented Feb 6, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.

@enigbe

Copy link
Copy Markdown
ContributorAuthor

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

@enigbeenigbe closed this Feb 6, 2026
@tnull

tnull commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

Yeah, thank you for that!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@enigbe@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add matrix testing for VSS authorizer variants by enigbe · Pull Request #786 · lightningdevkit/ldk-node · GitHub
Skip to content

Add matrix testing for VSS authorizer variants - #786

Closed
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage
Closed

Add matrix testing for VSS authorizer variants#786
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage

Conversation

@enigbe

Copy link
Copy Markdown
Contributor

What this PR does

With the addition of a public key-based authenticator and the option to verify JWT tokens on vss-server, the default vss-server build now requires authentication, so our integration tests need to either provide valid headers or explicitly build for the no-opauthenticator. This is why the VSS CI has been failing lately.

To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds vss-server with the appropriate flags and passes the corresponding cfg flag and features to the test runner.

The summary of changes introduced include:

  • Passing authorizer-specific cfg flags and features for test differentiation
  • The addition of test_utils feature with JWT- and signature-based header generation
  • The addition of RSA keypair fixtures for JWT signing and verification
  • The update of VSS-related tests to use auth-aware headers

Run VSS integration tests against multiple server authorizer
configurations (noop, sig, jwt). Each matrix job builds the
vss-server with the appropriate flags and passes the corresponding
cfg flag to the test runner.
- Use release builds for vss-server
- Pass authorizer-specific cfg flags for test differentiation
- Add `test_utils` feature with JWT and signature-based header generation
- Add RSA keypair fixtures for JWT signing
- Update VSS tests to use auth-aware headers
@ldk-reviews-bot

ldk-reviews-bot commented Feb 6, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.

@enigbe

Copy link
Copy Markdown
ContributorAuthor

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

@enigbeenigbe closed this Feb 6, 2026
@tnull

tnull commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

Yeah, thank you for that!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@enigbe@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Add matrix testing for VSS authorizer variants by enigbe · Pull Request #786 · lightningdevkit/ldk-node · GitHub
Skip to content

Add matrix testing for VSS authorizer variants - #786

Closed
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage
Closed

Add matrix testing for VSS authorizer variants#786
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage

Conversation

@enigbe

Copy link
Copy Markdown
Contributor

What this PR does

With the addition of a public key-based authenticator and the option to verify JWT tokens on vss-server, the default vss-server build now requires authentication, so our integration tests need to either provide valid headers or explicitly build for the no-opauthenticator. This is why the VSS CI has been failing lately.

To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds vss-server with the appropriate flags and passes the corresponding cfg flag and features to the test runner.

The summary of changes introduced include:

  • Passing authorizer-specific cfg flags and features for test differentiation
  • The addition of test_utils feature with JWT- and signature-based header generation
  • The addition of RSA keypair fixtures for JWT signing and verification
  • The update of VSS-related tests to use auth-aware headers

Run VSS integration tests against multiple server authorizer
configurations (noop, sig, jwt). Each matrix job builds the
vss-server with the appropriate flags and passes the corresponding
cfg flag to the test runner.
- Use release builds for vss-server
- Pass authorizer-specific cfg flags for test differentiation
- Add `test_utils` feature with JWT and signature-based header generation
- Add RSA keypair fixtures for JWT signing
- Update VSS tests to use auth-aware headers
@ldk-reviews-bot

ldk-reviews-bot commented Feb 6, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.

@enigbe

Copy link
Copy Markdown
ContributorAuthor

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

@enigbeenigbe closed this Feb 6, 2026
@tnull

tnull commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

Yeah, thank you for that!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@enigbe@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add matrix testing for VSS authorizer variants by enigbe · Pull Request #786 · lightningdevkit/ldk-node · GitHub
Skip to content

Add matrix testing for VSS authorizer variants - #786

Closed
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage
Closed

Add matrix testing for VSS authorizer variants#786
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage

Conversation

@enigbe

Copy link
Copy Markdown
Contributor

What this PR does

With the addition of a public key-based authenticator and the option to verify JWT tokens on vss-server, the default vss-server build now requires authentication, so our integration tests need to either provide valid headers or explicitly build for the no-opauthenticator. This is why the VSS CI has been failing lately.

To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds vss-server with the appropriate flags and passes the corresponding cfg flag and features to the test runner.

The summary of changes introduced include:

  • Passing authorizer-specific cfg flags and features for test differentiation
  • The addition of test_utils feature with JWT- and signature-based header generation
  • The addition of RSA keypair fixtures for JWT signing and verification
  • The update of VSS-related tests to use auth-aware headers

Run VSS integration tests against multiple server authorizer
configurations (noop, sig, jwt). Each matrix job builds the
vss-server with the appropriate flags and passes the corresponding
cfg flag to the test runner.
- Use release builds for vss-server
- Pass authorizer-specific cfg flags for test differentiation
- Add `test_utils` feature with JWT and signature-based header generation
- Add RSA keypair fixtures for JWT signing
- Update VSS tests to use auth-aware headers
@ldk-reviews-bot

ldk-reviews-bot commented Feb 6, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.

@enigbe

Copy link
Copy Markdown
ContributorAuthor

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

@enigbeenigbe closed this Feb 6, 2026
@tnull

tnull commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

Yeah, thank you for that!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@enigbe@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add matrix testing for VSS authorizer variants by enigbe · Pull Request #786 · lightningdevkit/ldk-node · GitHub
Skip to content

Add matrix testing for VSS authorizer variants - #786

Closed
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage
Closed

Add matrix testing for VSS authorizer variants#786
enigbe wants to merge 1 commit into
lightningdevkit:mainfrom
enigbe:2026-02-vss-header-authorization-coverage

Conversation

@enigbe

Copy link
Copy Markdown
Contributor

What this PR does

With the addition of a public key-based authenticator and the option to verify JWT tokens on vss-server, the default vss-server build now requires authentication, so our integration tests need to either provide valid headers or explicitly build for the no-opauthenticator. This is why the VSS CI has been failing lately.

To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds vss-server with the appropriate flags and passes the corresponding cfg flag and features to the test runner.

The summary of changes introduced include:

  • Passing authorizer-specific cfg flags and features for test differentiation
  • The addition of test_utils feature with JWT- and signature-based header generation
  • The addition of RSA keypair fixtures for JWT signing and verification
  • The update of VSS-related tests to use auth-aware headers

Run VSS integration tests against multiple server authorizer
configurations (noop, sig, jwt). Each matrix job builds the
vss-server with the appropriate flags and passes the corresponding
cfg flag to the test runner.
- Use release builds for vss-server
- Pass authorizer-specific cfg flags for test differentiation
- Add `test_utils` feature with JWT and signature-based header generation
- Add RSA keypair fixtures for JWT signing
- Update VSS tests to use auth-aware headers
@ldk-reviews-bot

ldk-reviews-bot commented Feb 6, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.

@enigbe

Copy link
Copy Markdown
ContributorAuthor

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

@enigbeenigbe closed this Feb 6, 2026
@tnull

tnull commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this.

Yeah, thank you for that!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@enigbe@ldk-reviews-bot@tnull