Uh oh!
There was an error while loading. Please reload this page.
Update rust-lightning to use default_value_vec - #850
Conversation
I've assigned @valentinewallace as a reviewer! |
| // not support JIT channels in combination with trampoline. We're not at risk of | ||
| // double-reporting a skimmed fee when we have multiple next_htlcs because we | ||
| // expect our skimmed fee to be zero. | ||
| if skimmed_fee_msat.is_some() { |
There was a problem hiding this comment.
This seems good enough for now, but will consider further changes to PaymentForwarded in LDK to possibly make this mapping a bit cleaner.
tnull
commented
Apr 8, 2026
I think this should be unblocked now, please rebase! (cc @carlaKC) |
carlaKC
commented
Apr 8, 2026
Rebased, but build is going to fail - there are some changes from lightningdevkit/rust-lightning#4266 which need to go in before we can bump to use the macro. |
tnull
commented
Apr 29, 2026
Alright, we just bumped to 044f3fab42e3085edecd40f0c9b369093edb7133, so the upstream changes you need should be available now! |
carlaKC
commented
Apr 29, 2026
Rebased w/ no conflicts except |
tnull
left a comment
There was a problem hiding this comment.
Feel free to undraft, but I think we don't need to touch the dependencies at all now?
| lightning-liquidity = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "044f3fab42e3085edecd40f0c9b369093edb7133", features = ["std"] } | ||
| lightning-macros = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "044f3fab42e3085edecd40f0c9b369093edb7133" } | ||
| lightning-dns-resolver = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "044f3fab42e3085edecd40f0c9b369093edb7133" } | ||
| lightning = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "4f5e64aa87004d6f2b214cd95a779e07a7e24f5a", features = ["std"] } |
There was a problem hiding this comment.
I think there is no reason we need to bump again from 044f3fab42e3085edecd40f0c9b369093edb7133, right?
There was a problem hiding this comment.
044f3fab42e3085edecd40f0c9b369093edb7133 doesn't contain default_value_vec because it came before the macro addition?
There was a problem hiding this comment.
Latest merge has a dep bump that includes the changes we need though!
Rebased on that, so now we indeed don't need a change to dependencies - diff.
Note that we still don't expect to receive multiple outgoing HTLCs because trampoline has not yet been enabled, but we lay the groundwork here.
Uh oh!
There was an error while loading. Please reload this page.
Depends on #4507