HRN resolution refinement and architectural clean-up by chuksys · Pull Request #887 · lightningdevkit/ldk-node

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

chuksys · 2026-04-22T16:00:14Z

Description

This is a follow-up to #630 to clean up the initial HRN resolution implementation. It focuses on improving initialization flow, reducing memory indirection, and fixing minor documentation bugs.

Changes

Initialization: Replaced the peer_manager_hook (Mutex/Option) with a deferred Weak pointer registration to resolve circular dependencies safely and efficiently.
Performance: Switched to ok_or_else in DNS Resolver setup to ensure error logging/string formatting only occurs on failure.
Type Cleanup: Removed redundant Arc wrapping around HRNResolver and implemented Clone for the enum to simplify passing it by value.
Docs: Corrected the default value description for resolution_config and realigned the configuration defaults table.
Tests: Cleaned up variable naming in the set_test_offer helper.

Fixes#883

Refactors the circular dependency between the HRNResolver and the PeerManager during the Node initialization process. Changes: - Removed the `peer_manager_hook` Mutex/Option pattern used to bridge the initialization gap. - Replaced the global initialization hook with a local deferred registration pattern using `Arc::downgrade` after the PeerManager is constructed. - Optimized `post_queue_action` by utilizing a Weak pointer upgrade instead of locking a Mutex on every call. This change improves performance for HRN resolution events and simplifies the builder logic by making the circular dependency resolution explicit and local to the builder function.

ldk-reviews-bot · 2026-04-22T16:00:17Z

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Streamlines the storage and passing of HRNResolver by holding it by value in the Node and UnifiedPayment structs. Changes: - Removed the outer Arc wrapper around HRNResolver in Node and UnifiedPayment. - Implemented Clone for HRNResolver to facilitate easy sharing of the internal Arcs. - Updated UnifiedPayment method calls to pass HRNResolver by reference instead of using .as_ref() on an outer Arc. Since HRNResolver variants already contain internal Arcs, the outer Arc was redundant and added unnecessary memory indirection.

Optimizes the DNS resolver setup by deferring log execution until an actual failure occurs. Changes: - Replaced `ok_or` with `ok_or_else` when resolving DNS server addresses. evaluation and unnecessary string formatting on successful builds. This ensures that logging overhead and string interpolation are only incurred during error states, rather than being evaluated on every successful initialization.

Updates the documentation in config.rs for better accuracy and readability. Changes: - Corrected the description of HRN resolution_config from 'Enabled' to 'Disabled' to align with the actual default value of false. - Realigned the Config defaults table to accommodate longer type names and improve Markdown rendering. These changes are strictly documentation-focused and do not alter any runtime behavior.

Cleans up the set_test_offer method by removing the underscore from the offer parameter name. Changes: - Renamed `_offer` to `offer` to reflect that the variable is actively used within the method body. - Ensures the code adheres to standard Rust naming conventions for used variables. This is a minor cleanup of the test-only API used for HRN integration testing.

ldk-reviews-bot · 2026-04-25T00:00:45Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-27T00:01:53Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Thanks, LGTM!

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

ldk-reviews-bot requested a review from tnull April 22, 2026 16:11

chuksys added 4 commits April 22, 2026 17:46

chuksys force-pushed the add-support-for-hrn-resolution-follow-up branch from 7877e09 to e29ae44Compare April 22, 2026 16:47

tnull approved these changes Apr 27, 2026
View reviewed changes

tnull merged commit 297ae84 into lightningdevkit:mainApr 27, 2026
21 checks passed

Uh oh!

Conversation

chuksys commented Apr 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Uh oh!

ldk-reviews-bot commented Apr 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Apr 25, 2026

Uh oh!

ldk-reviews-bot commented Apr 27, 2026

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chuksys commented Apr 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Uh oh!

ldk-reviews-bot commented Apr 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Apr 25, 2026

Uh oh!

ldk-reviews-bot commented Apr 27, 2026

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chuksys commented Apr 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Uh oh!

ldk-reviews-bot commented Apr 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Apr 25, 2026

Uh oh!

ldk-reviews-bot commented Apr 27, 2026

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chuksys commented Apr 22, 2026•
edited
Loading

ldk-reviews-bot commented Apr 22, 2026•
edited
Loading

chuksys commented Apr 22, 2026•
edited
Loading

ldk-reviews-bot commented Apr 22, 2026•
edited
Loading

chuksys commented Apr 22, 2026•
edited
Loading

ldk-reviews-bot commented Apr 22, 2026•
edited
Loading

chuksys commented Apr 22, 2026•
edited
Loading

ldk-reviews-bot commented Apr 22, 2026•
edited
Loading

chuksys commented Apr 22, 2026•
edited
Loading

ldk-reviews-bot commented Apr 22, 2026•
edited
Loading