') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Support LNURL resolution via optional HTTP fallback by benthecarman · Pull Request #898 · lightningdevkit/ldk-node · GitHub
Skip to content

Support LNURL resolution via optional HTTP fallback - #898

Draft
benthecarman wants to merge 1 commit into
lightningdevkit:mainfrom
benthecarman:lnurl-unified
Draft

Support LNURL resolution via optional HTTP fallback#898
benthecarman wants to merge 1 commit into
lightningdevkit:mainfrom
benthecarman:lnurl-unified

Conversation

@benthecarman

@benthecarmanbenthecarman commented May 4, 2026

Copy link
Copy Markdown
Contributor

Closes#870

Add an enable_lnurl_resolution flag to HumanReadableNamesConfig that, when set, attaches an HTTPHrnResolver as a fallback to the configured BIP 353 / bLIP-32 resolver. The fallback is consulted only when the primary resolver returns an error, so it covers LN-Address recipients that don't publish a BIP 353 record and direct LNURL-pay links, while never shadowing a successful primary resolution.

Enabling this opts in to revealing our IP and payment target to the LNURL endpoint, so it defaults to off.

Co-developed with Claude Code (claude-opus-4-7).

@benthecarman
Support LNURL resolution via optional HTTP fallback
a21ecc1
Add an `enable_lnurl_resolution` flag to `HumanReadableNamesConfig`
that, when set, attaches an `HTTPHrnResolver` as a fallback to the
configured BIP 353 / bLIP-32 resolver. The fallback is consulted only
when the primary resolver returns an error, so it covers LN-Address
recipients that don't publish a BIP 353 record and direct LNURL-pay
links, while never shadowing a successful primary resolution.
Enabling this opts in to revealing our IP and payment target to the
LNURL endpoint, so it defaults to off.
Co-developed with Claude Code (claude-opus-4-7).
@benthecarman
benthecarman requested a review from tnullMay 4, 2026 16:33
@ldk-reviews-bot

ldk-reviews-bot commented May 4, 2026•
edited
Loading

Copy link
Copy Markdown

👋 Hi! This PR is now in draft status.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt

TheBlueMatt commented May 4, 2026

Copy link
Copy Markdown
Contributor

This feels like it belongs in bitcoin-payment-instructions.

@benthecarman
benthecarman marked this pull request as draft May 4, 2026 16:56
@benthecarman

benthecarman commented May 4, 2026

Copy link
Copy Markdown
ContributorAuthor

This feels like it belongs in bitcoin-payment-instructions.

opened rust-bitcoin/bitcoin-payment-instructions#23 however I still think we'd still want some of this unless we want to add a fallback to the dns resolver too

tnull
tnull reviewed May 5, 2026
View reviewed changes
Comment threadsrc/config.rs
///
/// [LNURL-pay]: https://github.com/lnurl/luds/blob/luds/06.md
/// [`resolution_config`]: Self::resolution_config
pub enable_lnurl_resolution: bool,

@tnulltnullMay 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure we want this to be a config option to begin with? If this is just due to the possible privacy leak, it should probably be part of the respective variant on the resolution config?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unified send doesn't support lnurl

4 participants

@benthecarman@ldk-reviews-bot@TheBlueMatt@tnull