Skip to content

BOLT12 LSPS2 Support via persisted BOLT12 state - #964

Closed
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global
Closed

BOLT12 LSPS2 Support via persisted BOLT12 state#964
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Contributor

This is an alternative to #817 which uses the persisted LSPS2 parameters from https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4781. It moves away from having the receive methods specify LSPS parameters in favor of just always using them. This is somewhat required for BOLT 12 as we may have an offer from 6 months ago that we still want to receive payments to, but we've since swapped the LSPS parameters we use and we don't want to keep reusing an old LSP just because we configured it as the LSP once. Instead, the new lightning-liquidity persists the latest state for our LSPs services and, on startup, ldk-node deletes the negotiated parameters for LSPs we're no longer configured to use.

This is all just claude output, I only skimmed the code to make sure its doing what I intended.

Matt Coralloand others added 3 commits July 3, 2026 14:21
Point the Rust Lightning overrides at the local branch carrying the
LSPS2 BOLT12 router changes and carry the temporary API updates needed
to compile LDK Node.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wrap the default router with the LSPS2-aware `LSPS2Router` and wire it
to the LSPS2 client handler, so JIT-channel blinded payment paths are
injected into BOLT12 invoices based on the latest invoice parameters
negotiated with our configured LSPs.
If liquidity sources are configured, we negotiate the parameters with
the cheapest LSP once at startup. From then on they simply apply to all
BOLT12 receives, i.e., any offer created via the regular receive APIs
will have JIT-channel paths injected into its invoices, and we force a
refresh of any static invoices stored with a static invoice server so
they include the new paths, too. As the router encodes the used
parameters in the paths' payment metadata, they are available again
upon receipt and used to verify any skimmed channel opening fee against
what was negotiated.
Parameters previously negotiated with LSPs that are no longer
configured are wiped early during node building, before the node could
create any invoices or connect to peers.
The BOLT11 JIT receive flows are refactored to share the same
negotiation logic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exercise the BOLT12 receive flow with LSPS2 JIT channels via plain
BOLT12 offers relying on the parameters negotiated at startup: the
initial channel open, paying an offer after LSP restart, and wiping of
stale parameters when restarting without the LSP configured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt
TheBlueMattforce-pushed the 2026-07-lsps2-bolt12-stateful-global branch from 441801d to 5f79078CompareJuly 3, 2026 17:52
@tnull

Copy link
Copy Markdown
Collaborator

Superseded by #999.

@tnulltnull closed this Jul 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
BOLT12 LSPS2 Support via persisted BOLT12 state by TheBlueMatt · Pull Request #964 · lightningdevkit/ldk-node · GitHub
Skip to content

BOLT12 LSPS2 Support via persisted BOLT12 state - #964

Closed
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global
Closed

BOLT12 LSPS2 Support via persisted BOLT12 state#964
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Contributor

This is an alternative to #817 which uses the persisted LSPS2 parameters from https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4781. It moves away from having the receive methods specify LSPS parameters in favor of just always using them. This is somewhat required for BOLT 12 as we may have an offer from 6 months ago that we still want to receive payments to, but we've since swapped the LSPS parameters we use and we don't want to keep reusing an old LSP just because we configured it as the LSP once. Instead, the new lightning-liquidity persists the latest state for our LSPs services and, on startup, ldk-node deletes the negotiated parameters for LSPs we're no longer configured to use.

This is all just claude output, I only skimmed the code to make sure its doing what I intended.

Matt Coralloand others added 3 commits July 3, 2026 14:21
Point the Rust Lightning overrides at the local branch carrying the
LSPS2 BOLT12 router changes and carry the temporary API updates needed
to compile LDK Node.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wrap the default router with the LSPS2-aware `LSPS2Router` and wire it
to the LSPS2 client handler, so JIT-channel blinded payment paths are
injected into BOLT12 invoices based on the latest invoice parameters
negotiated with our configured LSPs.
If liquidity sources are configured, we negotiate the parameters with
the cheapest LSP once at startup. From then on they simply apply to all
BOLT12 receives, i.e., any offer created via the regular receive APIs
will have JIT-channel paths injected into its invoices, and we force a
refresh of any static invoices stored with a static invoice server so
they include the new paths, too. As the router encodes the used
parameters in the paths' payment metadata, they are available again
upon receipt and used to verify any skimmed channel opening fee against
what was negotiated.
Parameters previously negotiated with LSPs that are no longer
configured are wiped early during node building, before the node could
create any invoices or connect to peers.
The BOLT11 JIT receive flows are refactored to share the same
negotiation logic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exercise the BOLT12 receive flow with LSPS2 JIT channels via plain
BOLT12 offers relying on the parameters negotiated at startup: the
initial channel open, paying an offer after LSP restart, and wiping of
stale parameters when restarting without the LSP configured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt
TheBlueMattforce-pushed the 2026-07-lsps2-bolt12-stateful-global branch from 441801d to 5f79078CompareJuly 3, 2026 17:52
@tnull

Copy link
Copy Markdown
Collaborator

Superseded by #999.

@tnulltnull closed this Jul 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' BOLT12 LSPS2 Support via persisted BOLT12 state by TheBlueMatt · Pull Request #964 · lightningdevkit/ldk-node · GitHub
Skip to content

BOLT12 LSPS2 Support via persisted BOLT12 state - #964

Closed
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global
Closed

BOLT12 LSPS2 Support via persisted BOLT12 state#964
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Contributor

This is an alternative to #817 which uses the persisted LSPS2 parameters from https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4781. It moves away from having the receive methods specify LSPS parameters in favor of just always using them. This is somewhat required for BOLT 12 as we may have an offer from 6 months ago that we still want to receive payments to, but we've since swapped the LSPS parameters we use and we don't want to keep reusing an old LSP just because we configured it as the LSP once. Instead, the new lightning-liquidity persists the latest state for our LSPs services and, on startup, ldk-node deletes the negotiated parameters for LSPs we're no longer configured to use.

This is all just claude output, I only skimmed the code to make sure its doing what I intended.

Matt Coralloand others added 3 commits July 3, 2026 14:21
Point the Rust Lightning overrides at the local branch carrying the
LSPS2 BOLT12 router changes and carry the temporary API updates needed
to compile LDK Node.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wrap the default router with the LSPS2-aware `LSPS2Router` and wire it
to the LSPS2 client handler, so JIT-channel blinded payment paths are
injected into BOLT12 invoices based on the latest invoice parameters
negotiated with our configured LSPs.
If liquidity sources are configured, we negotiate the parameters with
the cheapest LSP once at startup. From then on they simply apply to all
BOLT12 receives, i.e., any offer created via the regular receive APIs
will have JIT-channel paths injected into its invoices, and we force a
refresh of any static invoices stored with a static invoice server so
they include the new paths, too. As the router encodes the used
parameters in the paths' payment metadata, they are available again
upon receipt and used to verify any skimmed channel opening fee against
what was negotiated.
Parameters previously negotiated with LSPs that are no longer
configured are wiped early during node building, before the node could
create any invoices or connect to peers.
The BOLT11 JIT receive flows are refactored to share the same
negotiation logic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exercise the BOLT12 receive flow with LSPS2 JIT channels via plain
BOLT12 offers relying on the parameters negotiated at startup: the
initial channel open, paying an offer after LSP restart, and wiping of
stale parameters when restarting without the LSP configured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt
TheBlueMattforce-pushed the 2026-07-lsps2-bolt12-stateful-global branch from 441801d to 5f79078CompareJuly 3, 2026 17:52
@tnull

Copy link
Copy Markdown
Collaborator

Superseded by #999.

@tnulltnull closed this Jul 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' BOLT12 LSPS2 Support via persisted BOLT12 state by TheBlueMatt · Pull Request #964 · lightningdevkit/ldk-node · GitHub
Skip to content

BOLT12 LSPS2 Support via persisted BOLT12 state - #964

Closed
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global
Closed

BOLT12 LSPS2 Support via persisted BOLT12 state#964
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Contributor

This is an alternative to #817 which uses the persisted LSPS2 parameters from https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4781. It moves away from having the receive methods specify LSPS parameters in favor of just always using them. This is somewhat required for BOLT 12 as we may have an offer from 6 months ago that we still want to receive payments to, but we've since swapped the LSPS parameters we use and we don't want to keep reusing an old LSP just because we configured it as the LSP once. Instead, the new lightning-liquidity persists the latest state for our LSPs services and, on startup, ldk-node deletes the negotiated parameters for LSPs we're no longer configured to use.

This is all just claude output, I only skimmed the code to make sure its doing what I intended.

Matt Coralloand others added 3 commits July 3, 2026 14:21
Point the Rust Lightning overrides at the local branch carrying the
LSPS2 BOLT12 router changes and carry the temporary API updates needed
to compile LDK Node.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wrap the default router with the LSPS2-aware `LSPS2Router` and wire it
to the LSPS2 client handler, so JIT-channel blinded payment paths are
injected into BOLT12 invoices based on the latest invoice parameters
negotiated with our configured LSPs.
If liquidity sources are configured, we negotiate the parameters with
the cheapest LSP once at startup. From then on they simply apply to all
BOLT12 receives, i.e., any offer created via the regular receive APIs
will have JIT-channel paths injected into its invoices, and we force a
refresh of any static invoices stored with a static invoice server so
they include the new paths, too. As the router encodes the used
parameters in the paths' payment metadata, they are available again
upon receipt and used to verify any skimmed channel opening fee against
what was negotiated.
Parameters previously negotiated with LSPs that are no longer
configured are wiped early during node building, before the node could
create any invoices or connect to peers.
The BOLT11 JIT receive flows are refactored to share the same
negotiation logic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exercise the BOLT12 receive flow with LSPS2 JIT channels via plain
BOLT12 offers relying on the parameters negotiated at startup: the
initial channel open, paying an offer after LSP restart, and wiping of
stale parameters when restarting without the LSP configured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt
TheBlueMattforce-pushed the 2026-07-lsps2-bolt12-stateful-global branch from 441801d to 5f79078CompareJuly 3, 2026 17:52
@tnull

Copy link
Copy Markdown
Collaborator

Superseded by #999.

@tnulltnull closed this Jul 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' BOLT12 LSPS2 Support via persisted BOLT12 state by TheBlueMatt · Pull Request #964 · lightningdevkit/ldk-node · GitHub
Skip to content

BOLT12 LSPS2 Support via persisted BOLT12 state - #964

Closed
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global
Closed

BOLT12 LSPS2 Support via persisted BOLT12 state#964
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Contributor

This is an alternative to #817 which uses the persisted LSPS2 parameters from https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4781. It moves away from having the receive methods specify LSPS parameters in favor of just always using them. This is somewhat required for BOLT 12 as we may have an offer from 6 months ago that we still want to receive payments to, but we've since swapped the LSPS parameters we use and we don't want to keep reusing an old LSP just because we configured it as the LSP once. Instead, the new lightning-liquidity persists the latest state for our LSPs services and, on startup, ldk-node deletes the negotiated parameters for LSPs we're no longer configured to use.

This is all just claude output, I only skimmed the code to make sure its doing what I intended.

Matt Coralloand others added 3 commits July 3, 2026 14:21
Point the Rust Lightning overrides at the local branch carrying the
LSPS2 BOLT12 router changes and carry the temporary API updates needed
to compile LDK Node.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wrap the default router with the LSPS2-aware `LSPS2Router` and wire it
to the LSPS2 client handler, so JIT-channel blinded payment paths are
injected into BOLT12 invoices based on the latest invoice parameters
negotiated with our configured LSPs.
If liquidity sources are configured, we negotiate the parameters with
the cheapest LSP once at startup. From then on they simply apply to all
BOLT12 receives, i.e., any offer created via the regular receive APIs
will have JIT-channel paths injected into its invoices, and we force a
refresh of any static invoices stored with a static invoice server so
they include the new paths, too. As the router encodes the used
parameters in the paths' payment metadata, they are available again
upon receipt and used to verify any skimmed channel opening fee against
what was negotiated.
Parameters previously negotiated with LSPs that are no longer
configured are wiped early during node building, before the node could
create any invoices or connect to peers.
The BOLT11 JIT receive flows are refactored to share the same
negotiation logic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exercise the BOLT12 receive flow with LSPS2 JIT channels via plain
BOLT12 offers relying on the parameters negotiated at startup: the
initial channel open, paying an offer after LSP restart, and wiping of
stale parameters when restarting without the LSP configured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt
TheBlueMattforce-pushed the 2026-07-lsps2-bolt12-stateful-global branch from 441801d to 5f79078CompareJuly 3, 2026 17:52
@tnull

Copy link
Copy Markdown
Collaborator

Superseded by #999.

@tnulltnull closed this Jul 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' BOLT12 LSPS2 Support via persisted BOLT12 state by TheBlueMatt · Pull Request #964 · lightningdevkit/ldk-node · GitHub
Skip to content

BOLT12 LSPS2 Support via persisted BOLT12 state - #964

Closed
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global
Closed

BOLT12 LSPS2 Support via persisted BOLT12 state#964
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Contributor

This is an alternative to #817 which uses the persisted LSPS2 parameters from https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4781. It moves away from having the receive methods specify LSPS parameters in favor of just always using them. This is somewhat required for BOLT 12 as we may have an offer from 6 months ago that we still want to receive payments to, but we've since swapped the LSPS parameters we use and we don't want to keep reusing an old LSP just because we configured it as the LSP once. Instead, the new lightning-liquidity persists the latest state for our LSPs services and, on startup, ldk-node deletes the negotiated parameters for LSPs we're no longer configured to use.

This is all just claude output, I only skimmed the code to make sure its doing what I intended.

Matt Coralloand others added 3 commits July 3, 2026 14:21
Point the Rust Lightning overrides at the local branch carrying the
LSPS2 BOLT12 router changes and carry the temporary API updates needed
to compile LDK Node.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wrap the default router with the LSPS2-aware `LSPS2Router` and wire it
to the LSPS2 client handler, so JIT-channel blinded payment paths are
injected into BOLT12 invoices based on the latest invoice parameters
negotiated with our configured LSPs.
If liquidity sources are configured, we negotiate the parameters with
the cheapest LSP once at startup. From then on they simply apply to all
BOLT12 receives, i.e., any offer created via the regular receive APIs
will have JIT-channel paths injected into its invoices, and we force a
refresh of any static invoices stored with a static invoice server so
they include the new paths, too. As the router encodes the used
parameters in the paths' payment metadata, they are available again
upon receipt and used to verify any skimmed channel opening fee against
what was negotiated.
Parameters previously negotiated with LSPs that are no longer
configured are wiped early during node building, before the node could
create any invoices or connect to peers.
The BOLT11 JIT receive flows are refactored to share the same
negotiation logic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exercise the BOLT12 receive flow with LSPS2 JIT channels via plain
BOLT12 offers relying on the parameters negotiated at startup: the
initial channel open, paying an offer after LSP restart, and wiping of
stale parameters when restarting without the LSP configured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt
TheBlueMattforce-pushed the 2026-07-lsps2-bolt12-stateful-global branch from 441801d to 5f79078CompareJuly 3, 2026 17:52
@tnull

Copy link
Copy Markdown
Collaborator

Superseded by #999.

@tnulltnull closed this Jul 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); BOLT12 LSPS2 Support via persisted BOLT12 state by TheBlueMatt · Pull Request #964 · lightningdevkit/ldk-node · GitHub
Skip to content

BOLT12 LSPS2 Support via persisted BOLT12 state - #964

Closed
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global
Closed

BOLT12 LSPS2 Support via persisted BOLT12 state#964
TheBlueMatt wants to merge 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2026-07-lsps2-bolt12-stateful-global

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Contributor

This is an alternative to #817 which uses the persisted LSPS2 parameters from https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4781. It moves away from having the receive methods specify LSPS parameters in favor of just always using them. This is somewhat required for BOLT 12 as we may have an offer from 6 months ago that we still want to receive payments to, but we've since swapped the LSPS parameters we use and we don't want to keep reusing an old LSP just because we configured it as the LSP once. Instead, the new lightning-liquidity persists the latest state for our LSPs services and, on startup, ldk-node deletes the negotiated parameters for LSPs we're no longer configured to use.

This is all just claude output, I only skimmed the code to make sure its doing what I intended.

Matt Coralloand others added 3 commits July 3, 2026 14:21
Point the Rust Lightning overrides at the local branch carrying the
LSPS2 BOLT12 router changes and carry the temporary API updates needed
to compile LDK Node.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wrap the default router with the LSPS2-aware `LSPS2Router` and wire it
to the LSPS2 client handler, so JIT-channel blinded payment paths are
injected into BOLT12 invoices based on the latest invoice parameters
negotiated with our configured LSPs.
If liquidity sources are configured, we negotiate the parameters with
the cheapest LSP once at startup. From then on they simply apply to all
BOLT12 receives, i.e., any offer created via the regular receive APIs
will have JIT-channel paths injected into its invoices, and we force a
refresh of any static invoices stored with a static invoice server so
they include the new paths, too. As the router encodes the used
parameters in the paths' payment metadata, they are available again
upon receipt and used to verify any skimmed channel opening fee against
what was negotiated.
Parameters previously negotiated with LSPs that are no longer
configured are wiped early during node building, before the node could
create any invoices or connect to peers.
The BOLT11 JIT receive flows are refactored to share the same
negotiation logic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exercise the BOLT12 receive flow with LSPS2 JIT channels via plain
BOLT12 offers relying on the parameters negotiated at startup: the
initial channel open, paying an offer after LSP restart, and wiping of
stale parameters when restarting without the LSP configured.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt
TheBlueMattforce-pushed the 2026-07-lsps2-bolt12-stateful-global branch from 441801d to 5f79078CompareJuly 3, 2026 17:52
@tnull

Copy link
Copy Markdown
Collaborator

Superseded by #999.

@tnulltnull closed this Jul 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull