RFC: Sample architecture and onboarding documentation by ariard · Pull Request #1 · lightningdevkit/ldk-sample

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

ariard · 2021-02-07T13:26:54Z

Ready for at least a high-level conceptual review.

For now, the sample is mostly a code skeleton with some commands functional (connect/open/...). Don't intend to use it beyond your local regtest.

Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.

jkczyz · 2021-02-07T16:50:20Z

Could you update the description to summarize the architecture?

TheBlueMatt

Some comments from a quick once-over, I'll take a real look later.

TheBlueMatt · 2021-02-08T19:57:23Z

+	let persister = Arc::new(FilesystemPersister::new(data_path.clone() + "/monitors"));
+
+	//TODO: if doesn't exist take best chain from bitcoind
+	let starting_blockhash = if let Ok(mut blockhash_file) = OpenOptions::new().read(true).open(data_path.clone() + "/blockhash") {


Why? Can't we just use the ChannelManager's serialized version?

TheBlueMatt · 2021-02-08T19:58:47Z

+}
+
+/// Basic JSON-RPC client storing server host and credentials 
+pub struct RpcClient {


I presume this can be dropped in favor of the one now on RL upstream?

TheBlueMatt · 2021-02-08T20:00:09Z

+const FEE_PROPORTIONAL_MILLIONTHS: u32 = 10;
+const ANNOUNCE_CHANNELS: bool = false;
+
+#[tokio::main]


You may want to specify a threaded executor :)

TheBlueMatt · 2021-02-08T20:08:40Z

+	let handles = setup_rpc_server(outbound_rpc_server_connector, ldk_port).await;
+	join_handles.push(handles);
+
+	loop {


Can't you just wait on all the join handles to finish?

TheBlueMatt · 2021-02-08T20:09:03Z

+ "invoice" => {
+ let amount = u64::from_str_radix(v_obj.get("amt").unwrap().as_str().unwrap(), 10).unwrap();
+ let payment_preimage = [1; 32];
+ //thread_rng().fill_bytes(&mut payment_preimage);


May want a TODO :)

TheBlueMatt · 2021-02-10T03:15:32Z

+
+# Why the sharing messages approach over the sharing memory one ?
+
+Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for


Note that a big part of the motivation for this in Core is that its written in a memory-unsafe language. Without unsafe code, there's little reason to do this (absent compiler and other similar bugs). Cross-host, not just cross-process, stuff is cooler, though.

Come on, playing with the security capabilities or privileges framework of your system is cool too. Or even control groups for intensive process like routing or throwing a load balancer between p2p stack and channel processing. For high-availability, high-security node, multi-process is way better :p

Lol, I mean I guess if you want capabilities enforcement that's cool. I still prefer multi-host, but whatever :)

…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable

TheBlueMatt added 30 commits June 14, 2018 18:03

Initial checkin
5c63310

Set up events handling infra and stdin reading infra
a3ff3f7

Add 3-msg outbound buffer
b575b2f

Resolve fd duplication potential panic, just use ids
829d729

Switch to RPC from REST, cause duh
be2ea8d

Update for new rust-lightning API
5e85bc6

Implement block connection/disconnect notification
14a4acc

Move socket handling to another module
9c578ac

Support creating an outbound channel
322f0b8

Fix feerate rounding by adding 3 to per-weight feerate
b0d1d36

Move chain monitoring into its own module
59ed7bb

Notify event processor when we have a block change
f904844

Fix initial chain monitor startup
cb08aa4

Use &[] instead of &Vec for rpc_client calls
38f6c7b

Implement event handling
34d3129

panic = abort
74ee3b8

Implement channelmonitor storage
b599f3e

Clean up net_manager and update for new API
4d800d9

Implement tx broadcast
d0943b1

panic on mainnet (before we start adding *actual* commands
7012e85

Poke event handler on funding transaction generation
8e8ceca

Add some useful list/channel close commands
fc69bd2

Set connect timeout to 10 secs
4012545

Update for new fee API
5b3159d

Add sending via rust-lightning-invoice BOLT11 parsing
fe197e3

Fix error handling inbound reads due to wrong initialization
90719cf

Handle PendingHTLCsForwardable events instead of panic()ing
982b854

Support receiving payments (no BOLT11 invoice creation yet)
ffe13c7

Only write one channel monitor update to disk at a time
7a32e18

Add basic README
fda4214

TheBlueMattand others added 25 commits February 15, 2020 20:01

Implement single-channel force-close
5542e4b

Bump dep head
92a0b71

Fix getblockheader response parsing
a2d5aa8
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)

Bump dep head and update to new API
c9cd8ab

Add initial block height logic
5202aa3

We already call rebraodcast_txn() regularly, we don't need to poll
000981c

set panic = abort
7f360ad

Correctly print the port number bound on at startup
59b8f51

Bump deps
b4a5e4c

Serialize + load Router
e53b1d7

Print RPC errors to stderr
9daf18a

Bump dep
ac7b340

Do io writes separately and dont hold locks during I/O
2ae4bf7

Make amount explicit
e29fd4c

Add ability to broadcast our own node_announcement
f18676d

bump deps
9718c40

Correct claim handling
22996b7

bump dep head + use released tokio again
d051da9

Print better error message if we fail to pass initial RPC check
4867837

Include date but skip file path in log entries
d41062d

Update RL
62b32c8

Build regtest invoices
85a7f6b

Bmp deps
53cb679

Switch to lightning-block-sync instead of our own block sync stuff
139a653

TheBlueMatt reviewed Feb 8, 2021
View reviewed changes

TheBlueMatt reviewed Feb 10, 2021
View reviewed changes

Add a ARCH.md
90cf120

orbitalturtle added a commit to orbitalturtle/ldk-sample that referenced this pull request Jan 17, 2024
Merge pull requestlightningdevkit#1from lndk-org/make-ldk-sample-im…
de1325a
…portable Make ldk sample importable


		# Why the sharing messages approach over the sharing memory one ?

		Long-term, it might be interesting to provide a multi-process LDK sample, better fitted for

Uh oh!

Conversation

ariard commented Feb 7, 2021

Uh oh!

jkczyz commented Feb 7, 2021

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

ariard commented Feb 7, 2021

Uh oh!

jkczyz commented Feb 7, 2021

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

ariard commented Feb 7, 2021

Uh oh!

jkczyz commented Feb 7, 2021

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment