') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Upgrade to LDK 0.0.125 by TheBlueMatt · Pull Request #136 · lightningdevkit/ldk-sample · GitHub
Skip to content
This repository was archived by the owner on Aug 3, 2026. It is now read-only.

Upgrade to LDK 0.0.125 - #136

Merged
tnull merged 5 commits into
lightningdevkit:mainfrom
TheBlueMatt:main
Oct 28, 2024
Merged

Upgrade to LDK 0.0.125#136
tnull merged 5 commits into
lightningdevkit:mainfrom
TheBlueMatt:main

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@TheBlueMatt
Drop sendonionmessage custom message sending command
6d171e0
Onion messages are now useful for various things so having a demo
use for them isn't all that interesting anymore.
@TheBlueMatt
TheBlueMattforce-pushed the main branch 5 times, most recently from f87f634 to c6bf6abCompareOctober 14, 2024 02:30
tnull
tnull reviewed Oct 14, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although one question regarding dropping sendonionmessage:

Mh, so having this command available was a real easy way to start playing with onion messages. While we don't think of LDK sample as a production node, it at least used to be the defacto default way to get started quickly with LDK. I wonder if should reconsider doing lightningdevkit/ldk-node#121 if we drop this functionality here, really just to allow users to experiment with custom onion messages, do measurements, etc (know at least two (research) projects that did stuff like that based on forked LDK sample).

Comment threadsrc/main.rs
}
},
Event::FundingTxBroadcastSafe { .. } => {
// We don't use the manual broadcasting feature, so this event should never be seen.

@tnulltnullOct 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put an unreachable or at least a debug_assert here and in the cases below?

@TheBlueMattTheBlueMattOct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we hadn't previously done that. Its possible that in the future these events get used more broadly and I'd rather not forget to remove an assertion.

@TheBlueMatt
TheBlueMattforce-pushed the main branch 2 times, most recently from fdd3822 to efba2f8CompareOctober 14, 2024 13:51
@TheBlueMatt

TheBlueMatt commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Re: custom onion message send, I'm pretty meh on it. If someone wants to use ldk-sample to do network measurements of onion messages they're gonna need both the send side and the receive side, which we hadn't implemented here. We generally have preferred to keep ldk-sample simple to demonstrate "what you need to get started", rather than showcase all the features people might use.

@TheBlueMatt

TheBlueMatt commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Also pushed a submitpackage replacement.

tnull
tnull reviewed Oct 14, 2024
View reviewed changes
Comment threadsrc/bitcoind_client.rs Outdated
tx_serialized);
print!("Warning, failed to broadcast a transaction, this is likely okay but may indicate an error: {}\n> ", err_str);
}
// We assume `submitpackage` is available (Bitcoin Core 25, at least).

@tnulltnullOct 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh, isn't it only available in general starting with v26? And wouldn't this use of it not still require v28?

@TheBlueMattTheBlueMattOct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe, I dunno I just checked my 25 node and it at least exists. Even if its just 26 seems fine to use it here? Indeed, until 28 it may not do anything, but it also shouldn't hurt. I'll update the comment at least.

@tnulltnullOct 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, well, would it actually work for broadcasting on mainnet, or is it a no-op until v0.28?

@tnulltnullOct 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it seems it will be usable just to broadcast starting with v26 (see https://bitcoincore.org/en/releases/26.0/). Good to know, might do that in lightningdevkit/ldk-node#370 from the getgo, too.

tnull
tnull reviewed Oct 14, 2024
View reviewed changes
Comment threadsrc/bitcoind_client.rs Outdated
@TheBlueMatt
Upgrade to LDK 0.0.125/rust-bitcoin 0.32
d8ab0a6
@TheBlueMatt
Use Balances to calculate balances instead of ChannelDetails
cfcd28b
LDK has deprecated the `ChannelDetails` balance retrieval because
its generally not what users want. Instead, we use the
`ChainMonitor` `Balance` list.
@TheBlueMatt
Print network graph statistics in nodeinfo
c52bf5b
@TheBlueMatt
Switch to submitpackage for broadcasting transactions
7ca1088
@TheBlueMatt

TheBlueMatt commented Oct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Switched to LDK 0.0.125 instead.

@TheBlueMattTheBlueMatt changed the title Upgrade to LDK 0.0.124Upgrade to LDK 0.0.125Oct 15, 2024
@kannapoixkannapoix mentioned this pull request Oct 23, 2024
Closed
2 tasks
@tnull
tnull merged commit 3676248 into lightningdevkit:mainOct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tnulltnulltnull approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheBlueMatt@tnull