') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update to 0.2.0 and minor tweaks by TheBlueMatt · Pull Request #141 · lightningdevkit/ldk-sample · GitHub

This repository was archived by the owner on Aug 3, 2026. It is now read-only.

Update to 0.2.0 and minor tweaks - #141

Merged

TheBlueMatt merged 10 commits into

lightningdevkit:mainfrom

TheBlueMatt:main

Feb 3, 2026

TheBlueMatt commented Sep 29, 2025

Contributor

No description provided.

ldk-reviews-bot commented Sep 29, 2025•
edited
Loading

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

TheBlueMatt mentioned this pull request

Updated to ldk main #140

Closed

ldk-reviews-bot requested a review from valentinewallace

September 29, 2025 08:09

valentinewallace commented Sep 29, 2025

Contributor

CI sad

TheBlueMatt commented Sep 29, 2025

ContributorAuthor

Cause ldk 0.2 isn't uploaded yet :)

TheBlueMatt changed the title ~~Update to 0.2.0-beta1~~Update to 0.2.0-beta1 and minor tweaks

valentinewallace reviewed

View reviewed changes

valentinewallace left a comment

Contributor

LGTM

src/main.rs Outdated

src/main.rs Outdated

TheBlueMatt force-pushed the main branch 3 times, most recently from 7c8461b to 009a548Compare

October 4, 2025 13:40

TheBlueMatt force-pushed the main branch from 009a548 to c716c05Compare

December 16, 2025 20:24

TheBlueMatt changed the title ~~Update to 0.2.0-beta1 and minor tweaks~~Update to 0.2.0 and minor tweaks

TheBlueMatt requested a review from valentinewallace

December 16, 2025 20:24

TheBlueMatt force-pushed the main branch 9 times, most recently from e0ad51d to 4961b68Compare

December 16, 2025 21:10

valentinewallace commented Dec 17, 2025

Contributor

I'm good with a squash. Also Windows CI is sad

ldk-reviews-bot commented Dec 18, 2025

🔔 1st Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Dec 22, 2025

🔔 2nd Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Dec 24, 2025

🔔 3rd Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Dec 27, 2025

🔔 4th Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Dec 29, 2025

🔔 5th Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Dec 31, 2025

🔔 6th Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Jan 3, 2026

🔔 7th Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Jan 5, 2026

🔔 8th Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

valentinewallace reviewed

View reviewed changes

valentinewallace left a comment

Contributor

Can we squash + fix CI? Should be good to go

TheBlueMatt added 9 commits

January 6, 2026 17:06

Update to LDK 0.2 keeping sync, update Cargo.lock with new deps

1a5ffa8

Naively update to LDK 0.2 using the sync wrappers to keep current
behavior.

Switch to async traits for bitcoind and KVStore outside of monitors

4d9ae57

With LDK 0.2, most traits now offer async variants. In the previous
commit we ignored these but here we migrate to them everywhere
except in the `ChannelMonitor` persistence.
Note that we have to switch to async stdin reading in cli.rs to
ensure we always reach an `await` point in a timely manner on all
tasks.

Use the new load_existing_monitor over watch_channel

3604a21

Now that we have `ChainMonitor::load_existing_monitor` we can use
it during startup to avoid the excess persistence at startup.

Switch to (beta) async persistence of ChannelMonitors

538004c

Marginally simplify checking if we're already connected

e923f41

Fix outbound payment amount tracking

1be2068

Stop persisting peer addresses to disk and use the public gossip db

64b7577

Its always been a bit strange that we persist the addresses of our
peers to disk when there's a public gossip db, its not really a
thing most LN nodes do. It might be useful for private channels but
there's not a lot of reason to have it in `ldk-sample`.

Drop tokio blocking now that poll_for_user_input is async

ad6620d

Drop redundant FilesystemStore initialization

132ef2e

TheBlueMatt force-pushed the main branch from 4961b68 to 132ef2eCompare

January 6, 2026 17:06

TheBlueMatt commented Jan 6, 2026

ContributorAuthor

Sorry for the delay, squashed and reverted the extra changes to Cargo.lock that were breaking 1.63 build.

valentinewallace reviewed

View reviewed changes

valentinewallace left a comment

Contributor

LGTM. Looks like Windows 1.63 CI is still sad

Only build for windows on rustc latest, not 1.63

de9eac1

TheBlueMatt commented Jan 15, 2026

ContributorAuthor

Not sure we care that much about windows-MSRV builds, so just disabled it.

TheBlueMatt commented Feb 3, 2026

ContributorAuthor

THe windows build is some windows crap. 1.63 didn't fail, it just was cancelled when windows did a windows thing.

TheBlueMatt merged commit 8900058 into lightningdevkit:main

2 of 4 checks passed

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.