') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update sample for 0.0.103 by jkczyz · Pull Request #40 · lightningdevkit/ldk-sample · GitHub
Skip to content
This repository was archived by the owner on Aug 3, 2026. It is now read-only.

Update sample for 0.0.103 - #40

Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
jkczyz:2021-11-release-103
Nov 4, 2021
Merged

Update sample for 0.0.103#40
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
jkczyz:2021-11-release-103

Conversation

@jkczyz

@jkczyzjkczyz commented Nov 2, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Update the sample node to use APIs from the 0.0.103 release.

  • Use InvoicePayer for routing and sending payments
  • Use find_route for keysend payments
  • Use a single Scorer instance and persist it periodically

@jkczyz
jkczyzforce-pushed the 2021-11-release-103 branch from 956a237 to 16779b1CompareNovember 2, 2021 21:37
@jkczyz
jkczyzforce-pushed the 2021-11-release-103 branch from 16779b1 to e31773bCompareNovember 3, 2021 04:13
TheBlueMatt
TheBlueMatt reviewed Nov 4, 2021
View reviewed changes
Comment threadsrc/cli.rs
Err(PaymentError::Sending(e)) => {
println!("ERROR: failed to send payment: {:?}", e);
print!("> ");
HTLCStatus::Failed

@TheBlueMattTheBlueMattNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we treat no-route differently from all-routes-failed-immediately?

@jkczyzjkczyzNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure... was just trying to maintain the same behavior. ChannelManager never gets called in this case, so maybe there's no need to update the payment storage? (cc: @valentinewallace)

@valentinewallacevalentinewallaceNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah I don’t think either would make sense to put in PaymentStorage. Don’t recall my exact reasoning tho.

@TheBlueMattTheBlueMattNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I think don't bother to store them? I'm not even sure if we need to store outbound payments anyway at this point?

@valentinewallacevalentinewallaceNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure if we need to store outbound payments anyway at this point?

list_payments currently allows you to see whether an outbound payment is pending vs completed/failed, due to storing them here. Could be exposed from ChannelManager instead tho

@TheBlueMattTheBlueMattNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened lightningdevkit/rust-lightning#1157

@jkczyzjkczyzNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah and right now neither inbound nor outbound payments are persisted in the sample. They're just used in list_payments. I can drop them entirely. Just want to note that it seems independent of the PR. Happy to do it here in a follow-up.

@TheBlueMattTheBlueMattNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, lets do it in a followup and land this for now.

@jkczyzjkczyzNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... so won't ChannelManager eventually remove the payments after they've been fulfilled? The sample would still needs to keep track of these, right? The idea of list_payments is basically a transaction log, IIUC.

@valentinewallacevalentinewallaceNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... so won't ChannelManager eventually remove the payments after they've been fulfilled? The sample would still needs to keep track of these, right? The idea of list_payments is basically a transaction log, IIUC.

I second this, though payments are currently not persisted to disk in the sample. So IMO inbound/outbound tracking shouldn’t be removed

TheBlueMatt
TheBlueMatt reviewed Nov 4, 2021
View reviewed changes
Comment threadsrc/cli.rs
let payee = Payee::for_keysend(payee_pubkey);
let params = RouteParameters { payee, final_value_msat: amt_msat, final_cltv_expiry_delta: 40 };

let route = match router::find_route(

@TheBlueMattTheBlueMattNov 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmmmm, we really need to get InvoicePayer to support spontaneous payments eventually.

@jkczyzjkczyzNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just opened issue lightningdevkit/rust-lightning#1156. Happy to take it on.

@TheBlueMattTheBlueMatt mentioned this pull request Nov 4, 2021
Closed
@TheBlueMatt
TheBlueMatt merged commit f44c400 into lightningdevkit:mainNov 4, 2021
@jkczyzjkczyz mentioned this pull request Nov 11, 2021
Open
@jkczyzjkczyz mentioned this pull request Dec 15, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkczyz@TheBlueMatt@valentinewallace