Uh oh!
There was an error while loading. Please reload this page.
Add initial service building blocks - #1
Conversation
6197a44 to
e48c89fCompareUh oh!
There was an error while loading. Please reload this page.
| println!( | ||
| "CHANNEL_PENDING: {} from counterparty {}", | ||
| channel_id, counterparty_node_id | ||
| ); |
There was a problem hiding this comment.
Fixed.
I think we'll have to drop all the printlns soon anyways in favor of some better logging. Possibly a split logger that logs to stdout and to file?
Uh oh!
There was an error while loading. Please reload this page.
| Ok(request) => match handler(node, request) { | ||
| Ok(response) => Ok(Response::builder() | ||
| .body(Full::new(Bytes::from(response.encode_to_vec()))) | ||
| // unwrap safety: body only errors when previous chained calls failed. |
There was a problem hiding this comment.
Do we plan on doing this on every unwrap? Should we do so throughout this PR if so?
There was a problem hiding this comment.
Yes I think so. Now got rid of the unwraps when building node/runtime and added another comment.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7e84e34 to
7fc39eaComparetnull
commented
Jul 23, 2024
Squashed without further changes. |
We add the additional daemon/service building blocks.