Add serde serializers for Bytes and Enums in protos by benthecarman · Pull Request #122 · lightningdevkit/ldk-server

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman · 2026-02-06T21:28:50Z

Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like "status": "SUCCEEDED" instead of "status": 1.

before:

₿ ldk-server-cli list-payments {
"payments": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": [
93,
160,
246,
39,
147,
33,
180,
246,
98,
129,
85,
25,
203,
68,
48,
58,
251,
79,
201,
51,
119,
173,
62,
224,
182,
102,
92,
126,
221,
2,
198,
163
]
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": 1,
"status": 1,
"latest_update_timestamp": 1770412903
}
]
}

after:

₿ ldk-server-cli list-payments {
"list": [
{
"id": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"kind": {
"kind": {
"bolt11": {
"hash": "0bfd4050d9251e9c8dc14d4f59e579a47db055f649ad093ac9f463b38fc63daf",
"preimage": "69172b32ae823751d37c7485c17ebb168f165b900435370dc267e6f71e381a66",
"secret": "5da0f6279321b4f662815519cb44303afb4fc93377ad3ee0b6665c7edd02c6a3"
}
}
},
"amount_msat": 1000000000,
"fee_paid_msat": 0,
"direction": "OUTBOUND",
"status": "SUCCEEDED",
"latest_update_timestamp": 1770412903
}
]
}

ldk-reviews-bot · 2026-02-06T21:28:53Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-02-09T00:00:27Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?

benthecarman · 2026-02-09T20:46:52Z

Okay found a much better way to do this. Only downside is we have the double kind in the output because of how serde handles enums but code is much cleaner/maintainable

tnull

Cool, love that it's much less invasive! One question.

Also, clippy CI is sad it seems

Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

…y-print Add serde serializers for Bytes and Enums in protos

benthecarman requested a review from tnull February 6, 2026 21:30

benthecarman force-pushed the better-pretty-print branch from f02251f to c45e341Compare February 6, 2026 21:40

benthecarman linked an issue Feb 6, 2026 that may be closed by this pull request
Add capability to *import* scorer files #114
Closed

benthecarman removed a link to an issue Feb 6, 2026
Add capability to *import* scorer files #114
Closed

This was linked to issues Feb 6, 2026
Use hex-encoded or string representation for user-facing identifiers #14
Closed
Report PaymentStatus using the variant name, not the i32 discriminant of the variant #120
Closed

tnull reviewed Feb 9, 2026
View reviewed changes

benthecarman force-pushed the better-pretty-print branch from c45e341 to 8c5c493Compare February 9, 2026 20:46

benthecarman changed the title ~~Improve CLI output readability for payment types~~Add serde serializers for Bytes and Enums in protosFeb 9, 2026

tnull reviewed Feb 10, 2026
View reviewed changes

Comment threadldk-server-protos/src/serde_utils.rs Outdated

Add serde serializers for Bytes and Enums in protos
af16148
Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.

benthecarman force-pushed the better-pretty-print branch from 8c5c493 to af16148Compare February 10, 2026 20:48

tnull approved these changes Feb 12, 2026
View reviewed changes

tnull merged commit 04e914a into lightningdevkit:mainFeb 12, 2026
7 checks passed

benthecarman deleted the better-pretty-print branch February 12, 2026 16:34

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#122from benthecarman/better-prett…
e12b84e
…y-print Add serde serializers for Bytes and Enums in protos