Add end-to-end test framework by benthecarman · Pull Request #128 · lightningdevkit/ldk-server

benthecarman · 2026-02-19T05:48:33Z

Closes#113

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building.

Tests cover all cli commands and most rabbitmq events.

Claude helped with some of the boilerplate code

Found a small place we can make the bolt12 cli better

ldk-reviews-bot · 2026-02-19T05:48:36Z

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull · 2026-02-19T08:31:40Z

+
+impl TestBitcoind {
+	pub fn new() -> Self {
+ let bitcoind = Node::from_downloaded().unwrap();


Should we enable caching like we do in LDK/LDK Node so we don't needlessly hammer bitcoincore.org with every CI job?

tnull · 2026-02-19T08:33:30Z

 	},
 	#[command(about = "Return a BOLT12 offer for receiving payments")]
 	Bolt12Receive {
+ #[arg(help = "Description to attach along with the offer")]


Why was this moved?

Something I noticed making the bolt12 test, we can't create an amountless bolt12 because the description is required but the amount is optional. I'll move to a separate commit to make it cleaner

tnull · 2026-02-20T11:43:29Z

+edition = "2021"
+
+[dependencies]
+corepc-node = { version = "0.10", features = ["download", "29_0"] }


Needs to drop the download feature now.

In CI we have set BITCOIND_SKIP_DOWNLOAD so it'll skip the download but we can keep this so it'll still download locally if you don't have it
https://github.com/rust-bitcoin/corepc/blob/master/node/build.rs#L78

Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman · 2026-02-20T23:43:53Z

Got LSPS2 functionality and the forwarded payments tested now too!

tnull · 2026-02-23T14:27:58Z

Ah, seems CI is unhappy right now.

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building. Tests cover all cli commands and rabbitmq events. Claude helped with some of the boilerplate code

benthecarman · 2026-02-23T23:29:57Z

working on more tests for here, but can always do as a follow up if we want to merge now

Add end-to-end test framework

benthecarman · 2026-02-19T05:48:33Z

Closes#113

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building.

Tests cover all cli commands and most rabbitmq events.

Claude helped with some of the boilerplate code

Found a small place we can make the bolt12 cli better

ldk-reviews-bot · 2026-02-19T05:48:36Z

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull · 2026-02-19T08:31:40Z

+
+impl TestBitcoind {
+	pub fn new() -> Self {
+ let bitcoind = Node::from_downloaded().unwrap();


Should we enable caching like we do in LDK/LDK Node so we don't needlessly hammer bitcoincore.org with every CI job?

tnull · 2026-02-19T08:33:30Z

 	},
 	#[command(about = "Return a BOLT12 offer for receiving payments")]
 	Bolt12Receive {
+ #[arg(help = "Description to attach along with the offer")]


Why was this moved?

Something I noticed making the bolt12 test, we can't create an amountless bolt12 because the description is required but the amount is optional. I'll move to a separate commit to make it cleaner

tnull · 2026-02-20T11:43:29Z

+edition = "2021"
+
+[dependencies]
+corepc-node = { version = "0.10", features = ["download", "29_0"] }


Needs to drop the download feature now.

In CI we have set BITCOIND_SKIP_DOWNLOAD so it'll skip the download but we can keep this so it'll still download locally if you don't have it
https://github.com/rust-bitcoin/corepc/blob/master/node/build.rs#L78

Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman · 2026-02-20T23:43:53Z

Got LSPS2 functionality and the forwarded payments tested now too!

tnull · 2026-02-23T14:27:58Z

Ah, seems CI is unhappy right now.

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building. Tests cover all cli commands and rabbitmq events. Claude helped with some of the boilerplate code

benthecarman · 2026-02-23T23:29:57Z

working on more tests for here, but can always do as a follow up if we want to merge now

Add end-to-end test framework

benthecarman · 2026-02-19T05:48:33Z

Closes#113

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building.

Tests cover all cli commands and most rabbitmq events.

Claude helped with some of the boilerplate code

Found a small place we can make the bolt12 cli better

ldk-reviews-bot · 2026-02-19T05:48:36Z

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull · 2026-02-19T08:31:40Z

+
+impl TestBitcoind {
+	pub fn new() -> Self {
+ let bitcoind = Node::from_downloaded().unwrap();


Should we enable caching like we do in LDK/LDK Node so we don't needlessly hammer bitcoincore.org with every CI job?

tnull · 2026-02-19T08:33:30Z

 	},
 	#[command(about = "Return a BOLT12 offer for receiving payments")]
 	Bolt12Receive {
+ #[arg(help = "Description to attach along with the offer")]


Why was this moved?

Something I noticed making the bolt12 test, we can't create an amountless bolt12 because the description is required but the amount is optional. I'll move to a separate commit to make it cleaner

tnull · 2026-02-20T11:43:29Z

+edition = "2021"
+
+[dependencies]
+corepc-node = { version = "0.10", features = ["download", "29_0"] }


Needs to drop the download feature now.

In CI we have set BITCOIND_SKIP_DOWNLOAD so it'll skip the download but we can keep this so it'll still download locally if you don't have it
https://github.com/rust-bitcoin/corepc/blob/master/node/build.rs#L78

Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman · 2026-02-20T23:43:53Z

Got LSPS2 functionality and the forwarded payments tested now too!

tnull · 2026-02-23T14:27:58Z

Ah, seems CI is unhappy right now.

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building. Tests cover all cli commands and rabbitmq events. Claude helped with some of the boilerplate code

benthecarman · 2026-02-23T23:29:57Z

working on more tests for here, but can always do as a follow up if we want to merge now

Add end-to-end test framework

benthecarman · 2026-02-19T05:48:33Z

Closes#113

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building.

Tests cover all cli commands and most rabbitmq events.

Claude helped with some of the boilerplate code

Found a small place we can make the bolt12 cli better

ldk-reviews-bot · 2026-02-19T05:48:36Z

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull · 2026-02-19T08:31:40Z

+
+impl TestBitcoind {
+	pub fn new() -> Self {
+ let bitcoind = Node::from_downloaded().unwrap();


Should we enable caching like we do in LDK/LDK Node so we don't needlessly hammer bitcoincore.org with every CI job?

tnull · 2026-02-19T08:33:30Z

 	},
 	#[command(about = "Return a BOLT12 offer for receiving payments")]
 	Bolt12Receive {
+ #[arg(help = "Description to attach along with the offer")]


Why was this moved?

Something I noticed making the bolt12 test, we can't create an amountless bolt12 because the description is required but the amount is optional. I'll move to a separate commit to make it cleaner

tnull · 2026-02-20T11:43:29Z

+edition = "2021"
+
+[dependencies]
+corepc-node = { version = "0.10", features = ["download", "29_0"] }


Needs to drop the download feature now.

In CI we have set BITCOIND_SKIP_DOWNLOAD so it'll skip the download but we can keep this so it'll still download locally if you don't have it
https://github.com/rust-bitcoin/corepc/blob/master/node/build.rs#L78

Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman · 2026-02-20T23:43:53Z

Got LSPS2 functionality and the forwarded payments tested now too!

tnull · 2026-02-23T14:27:58Z

Ah, seems CI is unhappy right now.

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building. Tests cover all cli commands and rabbitmq events. Claude helped with some of the boilerplate code

benthecarman · 2026-02-23T23:29:57Z

working on more tests for here, but can always do as a follow up if we want to merge now

Add end-to-end test framework

benthecarman · 2026-02-19T05:48:33Z

Closes#113

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building.

Tests cover all cli commands and most rabbitmq events.

Claude helped with some of the boilerplate code

Found a small place we can make the bolt12 cli better

ldk-reviews-bot · 2026-02-19T05:48:36Z

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull · 2026-02-19T08:31:40Z

+
+impl TestBitcoind {
+	pub fn new() -> Self {
+ let bitcoind = Node::from_downloaded().unwrap();


Should we enable caching like we do in LDK/LDK Node so we don't needlessly hammer bitcoincore.org with every CI job?

tnull · 2026-02-19T08:33:30Z

 	},
 	#[command(about = "Return a BOLT12 offer for receiving payments")]
 	Bolt12Receive {
+ #[arg(help = "Description to attach along with the offer")]


Why was this moved?

Something I noticed making the bolt12 test, we can't create an amountless bolt12 because the description is required but the amount is optional. I'll move to a separate commit to make it cleaner

tnull · 2026-02-20T11:43:29Z

+edition = "2021"
+
+[dependencies]
+corepc-node = { version = "0.10", features = ["download", "29_0"] }


Needs to drop the download feature now.

In CI we have set BITCOIND_SKIP_DOWNLOAD so it'll skip the download but we can keep this so it'll still download locally if you don't have it
https://github.com/rust-bitcoin/corepc/blob/master/node/build.rs#L78

Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman · 2026-02-20T23:43:53Z

Got LSPS2 functionality and the forwarded payments tested now too!

tnull · 2026-02-23T14:27:58Z

Ah, seems CI is unhappy right now.

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building. Tests cover all cli commands and rabbitmq events. Claude helped with some of the boilerplate code

benthecarman · 2026-02-23T23:29:57Z

working on more tests for here, but can always do as a follow up if we want to merge now

Add end-to-end test framework

benthecarman · 2026-02-19T05:48:33Z

Closes#113

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building.

Tests cover all cli commands and most rabbitmq events.

Claude helped with some of the boilerplate code

Found a small place we can make the bolt12 cli better

ldk-reviews-bot · 2026-02-19T05:48:36Z

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull · 2026-02-19T08:31:40Z

+
+impl TestBitcoind {
+	pub fn new() -> Self {
+ let bitcoind = Node::from_downloaded().unwrap();


Should we enable caching like we do in LDK/LDK Node so we don't needlessly hammer bitcoincore.org with every CI job?

tnull · 2026-02-19T08:33:30Z

 	},
 	#[command(about = "Return a BOLT12 offer for receiving payments")]
 	Bolt12Receive {
+ #[arg(help = "Description to attach along with the offer")]


Why was this moved?

Something I noticed making the bolt12 test, we can't create an amountless bolt12 because the description is required but the amount is optional. I'll move to a separate commit to make it cleaner

tnull · 2026-02-20T11:43:29Z

+edition = "2021"
+
+[dependencies]
+corepc-node = { version = "0.10", features = ["download", "29_0"] }


Needs to drop the download feature now.

In CI we have set BITCOIND_SKIP_DOWNLOAD so it'll skip the download but we can keep this so it'll still download locally if you don't have it
https://github.com/rust-bitcoin/corepc/blob/master/node/build.rs#L78

Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman · 2026-02-20T23:43:53Z

Got LSPS2 functionality and the forwarded payments tested now too!

tnull · 2026-02-23T14:27:58Z

Ah, seems CI is unhappy right now.

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building. Tests cover all cli commands and rabbitmq events. Claude helped with some of the boilerplate code

benthecarman · 2026-02-23T23:29:57Z

working on more tests for here, but can always do as a follow up if we want to merge now

Add end-to-end test framework

benthecarman · 2026-02-19T05:48:33Z

Closes#113

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building.

Tests cover all cli commands and most rabbitmq events.

Claude helped with some of the boilerplate code

Found a small place we can make the bolt12 cli better

ldk-reviews-bot · 2026-02-19T05:48:36Z

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull · 2026-02-19T08:31:40Z

+
+impl TestBitcoind {
+	pub fn new() -> Self {
+ let bitcoind = Node::from_downloaded().unwrap();


Should we enable caching like we do in LDK/LDK Node so we don't needlessly hammer bitcoincore.org with every CI job?

tnull · 2026-02-19T08:33:30Z

 	},
 	#[command(about = "Return a BOLT12 offer for receiving payments")]
 	Bolt12Receive {
+ #[arg(help = "Description to attach along with the offer")]


Why was this moved?

Something I noticed making the bolt12 test, we can't create an amountless bolt12 because the description is required but the amount is optional. I'll move to a separate commit to make it cleaner

tnull · 2026-02-20T11:43:29Z

+edition = "2021"
+
+[dependencies]
+corepc-node = { version = "0.10", features = ["download", "29_0"] }


Needs to drop the download feature now.

In CI we have set BITCOIND_SKIP_DOWNLOAD so it'll skip the download but we can keep this so it'll still download locally if you don't have it
https://github.com/rust-bitcoin/corepc/blob/master/node/build.rs#L78

Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman · 2026-02-20T23:43:53Z

Got LSPS2 functionality and the forwarded payments tested now too!

tnull · 2026-02-23T14:27:58Z

Ah, seems CI is unhappy right now.

Introduces an e2e-tests crate that spins up real bitcoind and ldk-server processes to test the cli -> ldk-server flow. A build.rs automatically compiles ldk-server (with events-rabbitmq) and ldk-server-cli into a separate target directory, so tests work without manual pre-building. Tests cover all cli commands and rabbitmq events. Claude helped with some of the boilerplate code

benthecarman · 2026-02-23T23:29:57Z

working on more tests for here, but can always do as a follow up if we want to merge now

Add end-to-end test framework

ldk-reviews-bot requested a review from valentinewallace February 19, 2026 05:59

tnull reviewed Feb 19, 2026
View reviewed changes

benthecarman self-assigned this Feb 19, 2026

benthecarman added this to Weekly Goals Feb 19, 2026

benthecarman force-pushed the e2e-tests branch from 4cb5f7d to 3cb2205Compare February 19, 2026 18:17

tnull reviewed Feb 20, 2026
View reviewed changes

benthecarman force-pushed the e2e-tests branch 2 times, most recently from ebf74ad to 397c4c5Compare February 20, 2026 18:17

Fix bolt12 receive cli to allow for amountless
485ec3e
Since the amount was optional and the description was required, we were unable to create an amountless bolt12 because the description was first in the positional agruments.

benthecarman force-pushed the e2e-tests branch from 397c4c5 to 348dda7Compare February 20, 2026 23:43

tnull previously approved these changes Feb 23, 2026
View reviewed changes

benthecarman added 2 commits February 23, 2026 17:03

Cache bitcoind binary on github ci
97963db

benthecarman dismissed tnull’s stale review via 97963dbFebruary 23, 2026 23:03

benthecarman force-pushed the e2e-tests branch from 348dda7 to 97963dbCompare February 23, 2026 23:03

tnull approved these changes Feb 24, 2026
View reviewed changes

tnull merged commit 57f9170 into lightningdevkit:mainFeb 24, 2026
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Feb 24, 2026

tnull mentioned this pull request Feb 25, 2026
Bump LDK Node dependency to commit 9e0cfc5#131
Merged

benthecarman mentioned this pull request Mar 3, 2026
Add e2e config startup tests #142
Merged

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#128from benthecarman/e2e-tests
9bb120d
Add end-to-end test framework