Skip to content

Add Dockerfile - #154

Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom
benthecarman:docker
May 22, 2026
Merged

Add Dockerfile#154
benthecarman merged 1 commit into
lightningdevkit:mainfrom
benthecarman:docker

Conversation

@benthecarman

@benthecarmanbenthecarman commented Mar 17, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Multi-stage build with dependency caching for faster rebuilds. Includes both ldk-server and ldk-server-cli binaries.

@ldk-reviews-bot

ldk-reviews-bot commented Mar 17, 2026•
edited
Loading

Copy link
Copy Markdown

I've assigned @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@benthecarmanbenthecarman mentioned this pull request Mar 17, 2026
Open
25 tasks
@benthecarmanbenthecarman self-assigned this May 14, 2026
@benthecarman
benthecarman marked this pull request as ready for review May 19, 2026 20:11
@benthecarman@claude
Add Dockerfile
1a7d9e4
Multi-stage build with dependency caching for faster rebuilds.
Includes both ldk-server and ldk-server-cli binaries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lorenzolfm
lorenzolfm reviewed May 20, 2026
View reviewed changes
Comment threadDockerfile

# Copy real source and rebuild
COPY . .
RUN touch ldk-server/src/main.rs ldk-server-cli/src/main.rs \

@lorenzolfmlorenzolfmMay 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing ldk-server-mcp here? You added the dummy for it above

@benthecarmanbenthecarmanMay 20, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the mcp server in the docker build, that's something you run locally

@lorenzolfmlorenzolfmMay 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, maybe line 21 is irrelevant then

lorenzolfm
lorenzolfm reviewed May 20, 2026
View reviewed changes
Comment threadDockerfile
COPY ldk-server-grpc/build.rs ldk-server-grpc/build.rs
COPY ldk-server-mcp/Cargo.toml ldk-server-mcp/Cargo.toml

# Create dummy source files so cargo can resolve and build dependencies

@lorenzolfmlorenzolfmMay 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use cargo-chef for this, btw. This way a workspace change would require a change in the dockerfile.

I understand wanting to avoid dependencies in the world we live in, tho haha

@benthecarmanbenthecarmanMay 20, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is easier to understand in my head too

lorenzolfm
lorenzolfm reviewed May 20, 2026
View reviewed changes
Comment threadDockerfile

EXPOSE 9735 3536

ENTRYPOINT ["ldk-server"]

@lorenzolfmlorenzolfmMay 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about running this with a non-root user?

@benthecarmanbenthecarmanMay 20, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is pretty self contained, so the usual benefits aren't as much here. People can always run it as a different user in docker-compose if they want as well. Just want to the base docker image to be something simple to run

@ldk-reviews-bot

ldk-reviews-bot commented May 21, 2026

Copy link
Copy Markdown

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo
tankyleo approved these changes May 21, 2026
View reviewed changes

@tankyleotankyleo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed this through multiple AIs

@benthecarman
benthecarman merged commit 62ef9c9 into lightningdevkit:mainMay 22, 2026
10 checks passed
@benthecarman
benthecarman deleted the docker branch May 22, 2026 02:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes
+1 more reviewer
@lorenzolfmlorenzolfmlorenzolfm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@benthecarmanbenthecarman

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benthecarman@ldk-reviews-bot@lorenzolfm@tankyleo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add Dockerfile by benthecarman · Pull Request #154 · lightningdevkit/ldk-server · GitHub
Skip to content
Add Dockerfile - #154
Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
May 22, 2026
Merged
Add Dockerfile#154
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
Conversation
@benthecarman
@benthecarmanbenthecarman
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Multi-stage build with dependency caching for faster rebuilds. Includes both ldk-server and ldk-server-cli binaries.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

I've assigned @tankyleo as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@benthecarmanbenthecarman
mentioned this pull request
Mar 17, 2026

Open

25 tasks
@benthecarmanbenthecarman
self-assigned this
May 14, 2026
@benthecarman
benthecarman
marked this pull request as ready for review
May 19, 2026 20:11
@benthecarman@claude
Add Dockerfile
1a7d9e4
Multi-stage build with dependency caching for faster rebuilds.
Includes both ldk-server and ldk-server-cli binaries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

# Copy real source and rebuild
COPY . .
RUN touch ldk-server/src/main.rs ldk-server-cli/src/main.rs \
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing ldk-server-mcp here? You added the dummy for it above
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the mcp server in the docker build, that's something you run locally
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, maybe line 21 is irrelevant then
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile
COPY ldk-server-grpc/build.rs ldk-server-grpc/build.rs
COPY ldk-server-mcp/Cargo.toml ldk-server-mcp/Cargo.toml

# Create dummy source files so cargo can resolve and build dependencies
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use cargo-chef for this, btw. This way a workspace change would require a change in the dockerfile.
I understand wanting to avoid dependencies in the world we live in, tho haha
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is easier to understand in my head too
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

EXPOSE 9735 3536

ENTRYPOINT ["ldk-server"]
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about running this with a non-root user?
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is pretty self contained, so the usual benefits aren't as much here. People can always run it as a different user in docker-compose if they want as well. Just want to the base docker image to be something simple to run
@ldk-reviews-bot
ldk-reviews-bot
commented
May 21, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @tankyleo! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
tankyleo
tankyleo
approved these changes
May 21, 2026
View reviewed changes
@tankyleotankyleo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed this through multiple AIs
@benthecarman
benthecarman
merged commit 62ef9c9
into
lightningdevkit:mainMay 22, 2026

10 checks passed

@benthecarman
benthecarman
deleted the

docker

branch
May 22, 2026 02:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes

+1 more reviewer

@lorenzolfmlorenzolfmlorenzolfm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@benthecarmanbenthecarman

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@benthecarman@ldk-reviews-bot@lorenzolfm@tankyleo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add Dockerfile by benthecarman · Pull Request #154 · lightningdevkit/ldk-server · GitHub
Skip to content
Add Dockerfile - #154
Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
May 22, 2026
Merged
Add Dockerfile#154
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
Conversation
@benthecarman
@benthecarmanbenthecarman
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Multi-stage build with dependency caching for faster rebuilds. Includes both ldk-server and ldk-server-cli binaries.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

I've assigned @tankyleo as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@benthecarmanbenthecarman
mentioned this pull request
Mar 17, 2026

Open

25 tasks
@benthecarmanbenthecarman
self-assigned this
May 14, 2026
@benthecarman
benthecarman
marked this pull request as ready for review
May 19, 2026 20:11
@benthecarman@claude
Add Dockerfile
1a7d9e4
Multi-stage build with dependency caching for faster rebuilds.
Includes both ldk-server and ldk-server-cli binaries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

# Copy real source and rebuild
COPY . .
RUN touch ldk-server/src/main.rs ldk-server-cli/src/main.rs \
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing ldk-server-mcp here? You added the dummy for it above
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the mcp server in the docker build, that's something you run locally
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, maybe line 21 is irrelevant then
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile
COPY ldk-server-grpc/build.rs ldk-server-grpc/build.rs
COPY ldk-server-mcp/Cargo.toml ldk-server-mcp/Cargo.toml

# Create dummy source files so cargo can resolve and build dependencies
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use cargo-chef for this, btw. This way a workspace change would require a change in the dockerfile.
I understand wanting to avoid dependencies in the world we live in, tho haha
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is easier to understand in my head too
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

EXPOSE 9735 3536

ENTRYPOINT ["ldk-server"]
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about running this with a non-root user?
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is pretty self contained, so the usual benefits aren't as much here. People can always run it as a different user in docker-compose if they want as well. Just want to the base docker image to be something simple to run
@ldk-reviews-bot
ldk-reviews-bot
commented
May 21, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @tankyleo! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
tankyleo
tankyleo
approved these changes
May 21, 2026
View reviewed changes
@tankyleotankyleo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed this through multiple AIs
@benthecarman
benthecarman
merged commit 62ef9c9
into
lightningdevkit:mainMay 22, 2026

10 checks passed

@benthecarman
benthecarman
deleted the

docker

branch
May 22, 2026 02:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes

+1 more reviewer

@lorenzolfmlorenzolfmlorenzolfm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@benthecarmanbenthecarman

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@benthecarman@ldk-reviews-bot@lorenzolfm@tankyleo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add Dockerfile by benthecarman · Pull Request #154 · lightningdevkit/ldk-server · GitHub
Skip to content
Add Dockerfile - #154
Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
May 22, 2026
Merged
Add Dockerfile#154
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
Conversation
@benthecarman
@benthecarmanbenthecarman
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Multi-stage build with dependency caching for faster rebuilds. Includes both ldk-server and ldk-server-cli binaries.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

I've assigned @tankyleo as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@benthecarmanbenthecarman
mentioned this pull request
Mar 17, 2026

Open

25 tasks
@benthecarmanbenthecarman
self-assigned this
May 14, 2026
@benthecarman
benthecarman
marked this pull request as ready for review
May 19, 2026 20:11
@benthecarman@claude
Add Dockerfile
1a7d9e4
Multi-stage build with dependency caching for faster rebuilds.
Includes both ldk-server and ldk-server-cli binaries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

# Copy real source and rebuild
COPY . .
RUN touch ldk-server/src/main.rs ldk-server-cli/src/main.rs \
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing ldk-server-mcp here? You added the dummy for it above
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the mcp server in the docker build, that's something you run locally
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, maybe line 21 is irrelevant then
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile
COPY ldk-server-grpc/build.rs ldk-server-grpc/build.rs
COPY ldk-server-mcp/Cargo.toml ldk-server-mcp/Cargo.toml

# Create dummy source files so cargo can resolve and build dependencies
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use cargo-chef for this, btw. This way a workspace change would require a change in the dockerfile.
I understand wanting to avoid dependencies in the world we live in, tho haha
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is easier to understand in my head too
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

EXPOSE 9735 3536

ENTRYPOINT ["ldk-server"]
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about running this with a non-root user?
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is pretty self contained, so the usual benefits aren't as much here. People can always run it as a different user in docker-compose if they want as well. Just want to the base docker image to be something simple to run
@ldk-reviews-bot
ldk-reviews-bot
commented
May 21, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @tankyleo! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
tankyleo
tankyleo
approved these changes
May 21, 2026
View reviewed changes
@tankyleotankyleo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed this through multiple AIs
@benthecarman
benthecarman
merged commit 62ef9c9
into
lightningdevkit:mainMay 22, 2026

10 checks passed

@benthecarman
benthecarman
deleted the

docker

branch
May 22, 2026 02:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes

+1 more reviewer

@lorenzolfmlorenzolfmlorenzolfm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@benthecarmanbenthecarman

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@benthecarman@ldk-reviews-bot@lorenzolfm@tankyleo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add Dockerfile by benthecarman · Pull Request #154 · lightningdevkit/ldk-server · GitHub
Skip to content
Add Dockerfile - #154
Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
May 22, 2026
Merged
Add Dockerfile#154
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
Conversation
@benthecarman
@benthecarmanbenthecarman
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Multi-stage build with dependency caching for faster rebuilds. Includes both ldk-server and ldk-server-cli binaries.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

I've assigned @tankyleo as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@benthecarmanbenthecarman
mentioned this pull request
Mar 17, 2026

Open

25 tasks
@benthecarmanbenthecarman
self-assigned this
May 14, 2026
@benthecarman
benthecarman
marked this pull request as ready for review
May 19, 2026 20:11
@benthecarman@claude
Add Dockerfile
1a7d9e4
Multi-stage build with dependency caching for faster rebuilds.
Includes both ldk-server and ldk-server-cli binaries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

# Copy real source and rebuild
COPY . .
RUN touch ldk-server/src/main.rs ldk-server-cli/src/main.rs \
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing ldk-server-mcp here? You added the dummy for it above
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the mcp server in the docker build, that's something you run locally
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, maybe line 21 is irrelevant then
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile
COPY ldk-server-grpc/build.rs ldk-server-grpc/build.rs
COPY ldk-server-mcp/Cargo.toml ldk-server-mcp/Cargo.toml

# Create dummy source files so cargo can resolve and build dependencies
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use cargo-chef for this, btw. This way a workspace change would require a change in the dockerfile.
I understand wanting to avoid dependencies in the world we live in, tho haha
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is easier to understand in my head too
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

EXPOSE 9735 3536

ENTRYPOINT ["ldk-server"]
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about running this with a non-root user?
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is pretty self contained, so the usual benefits aren't as much here. People can always run it as a different user in docker-compose if they want as well. Just want to the base docker image to be something simple to run
@ldk-reviews-bot
ldk-reviews-bot
commented
May 21, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @tankyleo! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
tankyleo
tankyleo
approved these changes
May 21, 2026
View reviewed changes
@tankyleotankyleo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed this through multiple AIs
@benthecarman
benthecarman
merged commit 62ef9c9
into
lightningdevkit:mainMay 22, 2026

10 checks passed

@benthecarman
benthecarman
deleted the

docker

branch
May 22, 2026 02:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes

+1 more reviewer

@lorenzolfmlorenzolfmlorenzolfm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@benthecarmanbenthecarman

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@benthecarman@ldk-reviews-bot@lorenzolfm@tankyleo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add Dockerfile by benthecarman · Pull Request #154 · lightningdevkit/ldk-server · GitHub
Skip to content
Add Dockerfile - #154
Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
May 22, 2026
Merged
Add Dockerfile#154
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
Conversation
@benthecarman
@benthecarmanbenthecarman
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Multi-stage build with dependency caching for faster rebuilds. Includes both ldk-server and ldk-server-cli binaries.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

I've assigned @tankyleo as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@benthecarmanbenthecarman
mentioned this pull request
Mar 17, 2026

Open

25 tasks
@benthecarmanbenthecarman
self-assigned this
May 14, 2026
@benthecarman
benthecarman
marked this pull request as ready for review
May 19, 2026 20:11
@benthecarman@claude
Add Dockerfile
1a7d9e4
Multi-stage build with dependency caching for faster rebuilds.
Includes both ldk-server and ldk-server-cli binaries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

# Copy real source and rebuild
COPY . .
RUN touch ldk-server/src/main.rs ldk-server-cli/src/main.rs \
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing ldk-server-mcp here? You added the dummy for it above
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the mcp server in the docker build, that's something you run locally
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, maybe line 21 is irrelevant then
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile
COPY ldk-server-grpc/build.rs ldk-server-grpc/build.rs
COPY ldk-server-mcp/Cargo.toml ldk-server-mcp/Cargo.toml

# Create dummy source files so cargo can resolve and build dependencies
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use cargo-chef for this, btw. This way a workspace change would require a change in the dockerfile.
I understand wanting to avoid dependencies in the world we live in, tho haha
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is easier to understand in my head too
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

EXPOSE 9735 3536

ENTRYPOINT ["ldk-server"]
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about running this with a non-root user?
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is pretty self contained, so the usual benefits aren't as much here. People can always run it as a different user in docker-compose if they want as well. Just want to the base docker image to be something simple to run
@ldk-reviews-bot
ldk-reviews-bot
commented
May 21, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @tankyleo! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
tankyleo
tankyleo
approved these changes
May 21, 2026
View reviewed changes
@tankyleotankyleo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed this through multiple AIs
@benthecarman
benthecarman
merged commit 62ef9c9
into
lightningdevkit:mainMay 22, 2026

10 checks passed

@benthecarman
benthecarman
deleted the

docker

branch
May 22, 2026 02:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes

+1 more reviewer

@lorenzolfmlorenzolfmlorenzolfm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@benthecarmanbenthecarman

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@benthecarman@ldk-reviews-bot@lorenzolfm@tankyleo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Add Dockerfile by benthecarman · Pull Request #154 · lightningdevkit/ldk-server · GitHub
Skip to content
Add Dockerfile - #154
Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
May 22, 2026
Merged
Add Dockerfile#154
benthecarman merged 1 commit into
lightningdevkit:mainfrom 
benthecarman:docker
Conversation
@benthecarman
@benthecarmanbenthecarman
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Multi-stage build with dependency caching for faster rebuilds. Includes both ldk-server and ldk-server-cli binaries.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 17, 2026•

edited

Loading

Copy link


Copy Markdown

I've assigned @tankyleo as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@benthecarmanbenthecarman
mentioned this pull request
Mar 17, 2026

Open

25 tasks
@benthecarmanbenthecarman
self-assigned this
May 14, 2026
@benthecarman
benthecarman
marked this pull request as ready for review
May 19, 2026 20:11
@benthecarman@claude
Add Dockerfile
1a7d9e4
Multi-stage build with dependency caching for faster rebuilds.
Includes both ldk-server and ldk-server-cli binaries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

# Copy real source and rebuild
COPY . .
RUN touch ldk-server/src/main.rs ldk-server-cli/src/main.rs \
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing ldk-server-mcp here? You added the dummy for it above
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the mcp server in the docker build, that's something you run locally
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, maybe line 21 is irrelevant then
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile
COPY ldk-server-grpc/build.rs ldk-server-grpc/build.rs
COPY ldk-server-mcp/Cargo.toml ldk-server-mcp/Cargo.toml

# Create dummy source files so cargo can resolve and build dependencies
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use cargo-chef for this, btw. This way a workspace change would require a change in the dockerfile.
I understand wanting to avoid dependencies in the world we live in, tho haha
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is easier to understand in my head too
lorenzolfm
lorenzolfm
reviewed
May 20, 2026
View reviewed changes
Comment threadDockerfile

EXPOSE 9735 3536

ENTRYPOINT ["ldk-server"]
@lorenzolfmlorenzolfmMay 20, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about running this with a non-root user?
@benthecarmanbenthecarmanMay 20, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is pretty self contained, so the usual benefits aren't as much here. People can always run it as a different user in docker-compose if they want as well. Just want to the base docker image to be something simple to run
@ldk-reviews-bot
ldk-reviews-bot
commented
May 21, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @tankyleo! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
tankyleo
tankyleo
approved these changes
May 21, 2026
View reviewed changes
@tankyleotankyleo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed this through multiple AIs
@benthecarman
benthecarman
merged commit 62ef9c9
into
lightningdevkit:mainMay 22, 2026

10 checks passed

@benthecarman
benthecarman
deleted the

docker

branch
May 22, 2026 02:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes

+1 more reviewer

@lorenzolfmlorenzolfmlorenzolfm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@benthecarmanbenthecarman

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@benthecarman@ldk-reviews-bot@lorenzolfm@tankyleo