Implement configurable native size/time log rotation & deletion by Anyitechs · Pull Request #189 · lightningdevkit/ldk-server

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

Anyitechs · 2026-04-15T18:25:31Z

This introduces a configurable native size/time log rotation & deletion functionality. It updates the ServerLogger to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values max_size_mb/rotation_interval_hours are unset. We keep only max_files (defaults to 5) rotated log files at a time, deleting older log files.

We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the max_size_mb and rotation_interval_hours params to 0

ldk-reviews-bot · 2026-04-15T18:25:35Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2026-04-15T19:36:04Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

Anyitechs · 2026-04-17T20:12:15Z

I would rather keep the old version. I like all the handling for the different signals in main.rs, makes things easier to reason about imo.

As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure logrotate.

ldk-reviews-bot · 2026-04-20T00:00:54Z

🔔 1st Reminder

Hey @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

benthecarman · 2026-04-20T00:41:58Z

+/// Maximum size of the log file before it gets rotated (50 MB)
+const MAX_LOG_SIZE_BYTES: usize = 50 * 1024 * 1024;
+/// Maximum age of the log file before it gets rotated (24 hours)
+const ROTATION_INTERVAL_SECS: u64 = 24 * 60 * 60;


these should be configurable

benthecarman · 2026-04-20T00:43:41Z

+ state.created_at = SystemTime::now();
+
+ // Spawn independent OS thread to compress the old file using native gzip
+ thread::spawn(move || match Command::new("gzip").arg("-f").arg(&rotated_path).status() {


This is assuming they have gzip installed and we have permissions to run it. I would rather just have the rust code do this

It doesn't really seem worth taking a gzip dependency just to do log rotation. We can just rotate and delete as-is and tell people to use the system log (which handles this properly) otherwise. Really we shouldn't be doing logging ourselves anyway - log should go to stdout/err and systemd or some other logic should figure out what to do with it.

I'm happy to drop the compression so we do a rotate and delete. If that works for everyone, I'll update this to introduce a configurable max_rotated_files that will default to the last 5 uncompressed files. Does that work?

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.

I'm in favor of just doing deletion instead of compression but I would really rather keep the log file and not rely on just stdout/stderr. If we don't have an easy log file and rely on the user's systemd/docker/whatever to do and persist the logs, we will likely not have logs for lots of users and make it much harder to do support.
I'm also leaning towards just not logging to file. However I see your point that it might lead to nothing being logged at all. In that case we should however at the very least add the option to disable logging to file, and also update our docs and checked-in systemd ldk-server.service to use that mode, so that everybody who runs it that way will just use journald rather than our custom filesystem logger.

Yeah I like that

Just added an option to disable logging to file by default and a configurable native rotate and delete here b54e0a5

benthecarman · 2026-05-01T20:40:32Z

 	}

 	runtime.block_on(async {
- // Register SIGHUP handler for log rotation


looks like you actually removed the SIGHUP handling even though in the docs you say we have it

Ah, good catch. Thanks!

Anyitechs · 2026-05-02T01:23:35Z

Addressed review comment here 42cd66a and rebased to fix conflict.

tnull · 2026-05-05T09:32:34Z

 }
 	}

 	fn flush(&self) {


Codex:
P1 File logs are now buffered with BufWriter (ldk-server/src/util/logger.rs:83), but normal writes do not flush (ldk-server/src/util/logger.rs:184) and shutdown does not call log::logger().flush() after the final log line (ldk-server/src/main.rs:527). Since the logger is installed
globally, recent file logs from short runs or shutdown can remain in memory and never reach disk.

benthecarman · 2026-06-02T16:57:06Z

+	log_max_size_bytes: usize,
+	log_rotation_interval_secs: u64,
+	log_max_files: usize,
+	internal_rotation_enabled: bool,


We have internal_rotation_enabled but I don't see anyway to actually disable the rotation. Below its set to log_to_file so there is probably a bug here, either way its very confusing.

Either way if we are going to keep the SIGHUP handling, we should have a way to disable the log rotation because otherwise the 2 systems would be fighting over each other. Made have it so if you set the param to 0 we don't rotate on that metric?

Ah true, thank you. I've adopted your suggestion and dropped the internal_rotation_enabled field entirely. We now allow disabling internal rotation by setting the log_max_size_bytes and log_rotation_interval_secs to 0 for users who want to keep logging to file but have something else do the rotation for them.

Anyitechs · 2026-06-09T14:27:02Z

Addressed latest review comments and took the opportunity to squash fixup commits.

Ready for another look!

benthecarman

few more small things and this should be good!

Anyitechs · 2026-06-23T10:15:04Z

Please excuse the delay here!

I've addressed all the latest comments here c8386a3. Let me know if/when I can squash.

Anyitechs · 2026-06-23T23:50:10Z

Addressed latest review comments and squashed fixups.

Ready for another look!

benthecarman

couple docs fixes then we're good

This introduces a configurable native size/time log rotation & deletion functionality. It updates the `ServerLogger` to track file size and age internally, triggering rotation at a default size of 50MB or 24 hours, if the config values `max_size_mb`/`rotation_interval_hours` are unset. We keep only `max_files` (defaults to 5) rotated log files at a time, deleting older log files. We also now allow users to turn off logging to file, but the default is logging to file and stdout/stderr. Internal rotation can be disabled for file logging by setting the `max_size_mb` and `rotation_interval_hours` params to `0`. Co-Authored-By: Gemini 3.0 Pro

ldk-reviews-bot requested a review from benthecarman April 15, 2026 18:36

Anyitechs marked this pull request as draft April 15, 2026 19:35

Anyitechs force-pushed the log-rotation branch from afaee78 to 0bd62ffCompare April 17, 2026 19:55

Anyitechs changed the title ~~refactor: encapsulate log rotation logic~~Implement native size/time log rotation with gzip compressionApr 17, 2026

Anyitechs marked this pull request as ready for review April 17, 2026 19:58

benthecarman requested changes Apr 20, 2026
View reviewed changes

Anyitechs force-pushed the log-rotation branch from 0bd62ff to b54e0a5Compare April 22, 2026 17:59

benthecarman requested changes May 1, 2026
View reviewed changes

Anyitechs force-pushed the log-rotation branch from b54e0a5 to 42cd66aCompare May 2, 2026 01:13

Anyitechs changed the title ~~Implement native size/time log rotation with gzip compression~~Implement configurable native size/time log rotation & deletionMay 2, 2026

tnull reviewed May 5, 2026
View reviewed changes

benthecarman mentioned this pull request May 7, 2026
Beta Release #121
Open
25 tasks

benthecarman requested changes Jun 2, 2026
View reviewed changes

Anyitechs requested a review from benthecarman June 3, 2026 19:21

benthecarman requested changes Jun 5, 2026
View reviewed changes

Comment threaddocs/operations.md Outdated
Comment threadcontrib/ldk-server-config.toml
Comment threadldk-server/src/util/logger.rs Outdated

Anyitechs force-pushed the log-rotation branch from ca7d3ff to e982113Compare June 9, 2026 14:19

Anyitechs requested a review from benthecarman June 9, 2026 14:27

benthecarman requested changes Jun 10, 2026
View reviewed changes

benthecarman mentioned this pull request Jun 16, 2026
Add crate version and commit hash to ldk-server #229
Merged

Anyitechs requested a review from benthecarman June 23, 2026 10:15

benthecarman reviewed Jun 23, 2026
View reviewed changes

Comment threadldk-server/src/util/logger.rs Outdated
Comment threadcontrib/ldk-server-config.toml Outdated
Comment threaddocs/configuration.md Outdated
Comment threaddocs/operations.md Outdated

Anyitechs force-pushed the log-rotation branch from c8386a3 to 35c158dCompare June 23, 2026 23:46

benthecarman reviewed Jun 24, 2026
View reviewed changes

Comment threaddocs/operations.md Outdated
Comment threadcontrib/ldk-server-config.toml Outdated

Anyitechs force-pushed the log-rotation branch from 35c158d to 6a1af28Compare June 24, 2026 18:26

benthecarman approved these changes Jun 24, 2026
View reviewed changes

benthecarman merged commit 628d95f into lightningdevkit:mainJun 24, 2026
8 checks passed