Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Optimize paginated payment listing queries - #240

Closed
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values
Closed

Optimize paginated payment listing queries#240
joostjager wants to merge 2 commits into
lightningdevkit:mainfrom
joostjager:fix-paginated-list-values

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

This replaces the SQLite pagination index with one that matches the actual paginated store access pattern: namespace filters first, followed by creation_time DESC, key ASC for cursor ordering. The previous creation_time-only index did not fit these queries well and could scan unrelated namespaces or require extra sorting.

It also adds a required list_values paginated store method and implements it in SqliteStore with a single query returning keys and serialized values. ListPayments and ListForwardedPayments now decode those returned values directly, avoiding the previous page-level N+1 pattern where listing 100 items could require 101 SQLite queries.

Use a composite namespace/time/key index because paginated store
queries first constrain primary_namespace and secondary_namespace, then
page and order by creation_time DESC and key ASC. The prior
creation_time-only index did not match that access pattern and could
scan rows from unrelated namespaces or require extra sorting.
Existing databases may retain idx_creation_time; this change only
stops creating it for new databases and creates
idx_paginated_kv_namespace_time_key instead.
Add a required list_values method to the paginated store abstraction
and implement it in SqliteStore with a single query that returns each
page of keys and serialized values. Keep the existing cursor predicate,
ordering, and page-token behavior.
Switch ListPayments and ListForwardedPayments to decode the returned
values directly so each page avoids the per-key read loop.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're about to drop the SQLite / local forwarded payment store from Server as we're close to finally add all parts to LDK Node. So I don't think it makes sense to make changes to it right now?

@tnull
tnull removed the request for review from valentinewallaceJuly 3, 2026 08:29
@joostjager

Copy link
Copy Markdown
ContributorAuthor

Opened this PR because I still had the code lying around from an older analysis, but I wasn’t fully up to date with what had happened in ldk-node.

The main thing to distill from it is probably this question on ldk-node#959, if it hasn’t already been answered elsewhere: lightningdevkit/ldk-node#959 (comment)

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

@tnull

tnull commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

One meta note: the split between ldk-node and ldk-server does make this kind of thing a bit harder to track from the ldk-server side.

Yes, well, that split is exactly what we're trying to reduce currently, i.e., move any remaining custom 'logic' into Node so that Server is really just responsible for the API, dealing with the daemon etc.

@joostjager

Copy link
Copy Markdown
ContributorAuthor

Once ldk-server is cleaned up again and this stateful logic has moved into ldk-node, I think it would be good to define the boundary strictly so we avoid future work and rework like this.

And I still think keeping this split across two repos introduces unnecessary visibility and change friction, but you all know my stance on that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull