Upgrade LDK Node by G8XSU · Pull Request #45 · lightningdevkit/ldk-server

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU · 2025-02-19T23:51:04Z

Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]

arik-so · 2025-02-21T21:10:48Z

Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version.

G8XSU · 2025-02-21T23:11:51Z

@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node.

arik-so · 2025-02-24T17:34:02Z

Looks fine to me, just adding some context to some of the commits might be a good idea.

LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Since they are not required for existing logging.

Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU · 2025-02-24T22:27:27Z

Added.

arik-so · 2025-02-24T23:45:43Z

+// The on-chain transaction is confirmed in the best chain.
+message Confirmed {
+ // The hash of the block in which the transaction was confirmed.
+ string block_hash = 1;


should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans

Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.

Onchain payments now provide additional information such as transaction_id and confirmation_status.

…-log

G8XSU changed the title ~~WIP: Ldk node upgrade~~Upgrade LDK NodeFeb 20, 2025

G8XSU requested a review from arik-so February 20, 2025 23:17

G8XSU marked this pull request as ready for review February 20, 2025 23:17

G8XSU force-pushed the ldk-node-upgrade-for-log branch 2 times, most recently from 0c26c06 to 8f64073Compare February 21, 2025 23:15

G8XSU added 9 commits February 24, 2025 14:20

Upgrade LDK Node version.
5281fb5

Update Cargo.lock
4ea2759

Bump MSRV to 1.75.0
8430068
LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.

Add prev_node_id and next_node_id in PaymentForwarded proto.
f801489
In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Start storing prev_node_id and next_node_id for PaymentForwardedEvents.
136d8e9
In PaymentForwarded events, we now have access to prev_node_id and next_node_id.

Ignore new fields for PaymentReceived event.
d8a3d15
Since they are not required for existing logging.

Account for Bolt11InvoiceDescription.
c15b001
Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.

Account for FeeRate in OnchainSend.
35049a7
Onchain sends now support setting a custom fee-rate, account for this api change in ldk.

Configure logging using new LDK Node api.
28575c6
LDK Node now supports logging through log facade and there are minor associated api changes.

G8XSU force-pushed the ldk-node-upgrade-for-log branch from 8f64073 to b887021Compare February 24, 2025 22:27

arik-so reviewed Feb 24, 2025
View reviewed changes

Expose txid and confirmation_status for onchain payments.
50f9f6b
Onchain payments now provide additional information such as transaction_id and confirmation_status.

G8XSU force-pushed the ldk-node-upgrade-for-log branch from b887021 to 50f9f6bCompare February 25, 2025 01:06

arik-so approved these changes Feb 25, 2025
View reviewed changes

G8XSU merged commit cd2a532 into lightningdevkit:mainFeb 25, 2025

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#45from G8XSU/ldk-node-upgrade-for…
f2fe127
…-log