Skip to content

Use LdkServerError for error handling in all APIs. - #46

Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom
G8XSU:25-02-error-handling
Feb 28, 2025
Merged

Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom
G8XSU:25-02-error-handling

Conversation

@G8XSU

@G8XSUG8XSU commented Feb 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Use LdkServerError for error handling in all APIs.

@G8XSU
G8XSU requested a review from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed the 25-02-error-handling branch from f2e47f5 to 878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU marked this pull request as ready for review February 27, 2025 00:40
@G8XSUG8XSU mentioned this pull request Feb 27, 2025
Closed
13 tasks
@G8XSUG8XSU added the Weekly Goal Someone wants to land this this week label Feb 27, 2025
jkczyz
jkczyz reviewed Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
| NodeError::ChannelCreationFailed
| NodeError::ChannelClosingFailed
| NodeError::ChannelConfigUpdateFailed
| NodeError::DuplicatePayment

@jkczyzjkczyzFeb 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.

@G8XSUG8XSUFeb 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.
Ideally, DuplicatePayment should become a sub-error within the lightning error category.

We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.

Comment threadldk-server/src/api/onchain_send.rs
Comment on lines +17 to +20
LdkServerError::new(
InvalidRequestError,
"Address is not valid for LdkServer's configured network.".to_string(),
)

@jkczyzjkczyzFeb 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?

@G8XSUG8XSUFeb 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.
We use it where we can but provide more context by directly using LdkServerError to be more helpful.

@jkczyzjkczyzFeb 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.

Comment threadldk-server/src/api/get_payment_details.rs Outdated
@G8XSU
G8XSU requested a review from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz reviewed Feb 28, 2025
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.

@G8XSU
G8XSUforce-pushed the 25-02-error-handling branch from d60055d to f795976CompareFebruary 28, 2025 20:40
@G8XSU

G8XSU commented Feb 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Squashed fixups.

@G8XSU
G8XSU merged commit b70ab5b into lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees

No one assigned

Labels

Weekly GoalSomeone wants to land this this week

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Use LdkServerError for error handling in all APIs. by G8XSU · Pull Request #46 · lightningdevkit/ldk-server · GitHub
Skip to content
Use LdkServerError for error handling in all APIs. - #46
Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Feb 28, 2025
Merged
Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Conversation
@G8XSU
@G8XSUG8XSU
commented
Feb 26, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Use LdkServerError for error handling in all APIs.
@G8XSU
G8XSU
requested a review
from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
f2e47f5 to
878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU
marked this pull request as ready for review
February 27, 2025 00:40
@G8XSUG8XSU
mentioned this pull request
Feb 27, 2025

Closed

13 tasks
@G8XSUG8XSU
added
the 
Weekly Goal
Someone wants to land this this week
label
Feb 27, 2025
jkczyz
jkczyz
reviewed
Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
 | NodeError::ChannelCreationFailed
 | NodeError::ChannelClosingFailed
 | NodeError::ChannelConfigUpdateFailed
 | NodeError::DuplicatePayment
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.

Ideally, DuplicatePayment should become a sub-error within the lightning error category.
We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.
Comment threadldk-server/src/api/onchain_send.rs

Comment on lines

+17
 to 
+20

 LdkServerError::new(
 InvalidRequestError,
 "Address is not valid for LdkServer's configured network.".to_string(),
 )
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.

We use it where we can but provide more context by directly using LdkServerError to be more helpful.
@jkczyzjkczyzFeb 28, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.
Comment threadldk-server/src/api/get_payment_details.rs
Outdated

@G8XSU
G8XSU
requested a review
from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz
reviewed
Feb 28, 2025
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
d60055d to
f795976CompareFebruary 28, 2025 20:40
@G8XSU
G8XSU
commented
Feb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Squashed fixups.
@G8XSU
G8XSU
merged commit b70ab5b
into
lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels

Weekly GoalSomeone wants to land this this week

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use LdkServerError for error handling in all APIs. by G8XSU · Pull Request #46 · lightningdevkit/ldk-server · GitHub
Skip to content
Use LdkServerError for error handling in all APIs. - #46
Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Feb 28, 2025
Merged
Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Conversation
@G8XSU
@G8XSUG8XSU
commented
Feb 26, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Use LdkServerError for error handling in all APIs.
@G8XSU
G8XSU
requested a review
from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
f2e47f5 to
878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU
marked this pull request as ready for review
February 27, 2025 00:40
@G8XSUG8XSU
mentioned this pull request
Feb 27, 2025

Closed

13 tasks
@G8XSUG8XSU
added
the 
Weekly Goal
Someone wants to land this this week
label
Feb 27, 2025
jkczyz
jkczyz
reviewed
Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
 | NodeError::ChannelCreationFailed
 | NodeError::ChannelClosingFailed
 | NodeError::ChannelConfigUpdateFailed
 | NodeError::DuplicatePayment
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.

Ideally, DuplicatePayment should become a sub-error within the lightning error category.
We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.
Comment threadldk-server/src/api/onchain_send.rs

Comment on lines

+17
 to 
+20

 LdkServerError::new(
 InvalidRequestError,
 "Address is not valid for LdkServer's configured network.".to_string(),
 )
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.

We use it where we can but provide more context by directly using LdkServerError to be more helpful.
@jkczyzjkczyzFeb 28, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.
Comment threadldk-server/src/api/get_payment_details.rs
Outdated

@G8XSU
G8XSU
requested a review
from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz
reviewed
Feb 28, 2025
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
d60055d to
f795976CompareFebruary 28, 2025 20:40
@G8XSU
G8XSU
commented
Feb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Squashed fixups.
@G8XSU
G8XSU
merged commit b70ab5b
into
lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels

Weekly GoalSomeone wants to land this this week

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use LdkServerError for error handling in all APIs. by G8XSU · Pull Request #46 · lightningdevkit/ldk-server · GitHub
Skip to content
Use LdkServerError for error handling in all APIs. - #46
Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Feb 28, 2025
Merged
Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Conversation
@G8XSU
@G8XSUG8XSU
commented
Feb 26, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Use LdkServerError for error handling in all APIs.
@G8XSU
G8XSU
requested a review
from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
f2e47f5 to
878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU
marked this pull request as ready for review
February 27, 2025 00:40
@G8XSUG8XSU
mentioned this pull request
Feb 27, 2025

Closed

13 tasks
@G8XSUG8XSU
added
the 
Weekly Goal
Someone wants to land this this week
label
Feb 27, 2025
jkczyz
jkczyz
reviewed
Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
 | NodeError::ChannelCreationFailed
 | NodeError::ChannelClosingFailed
 | NodeError::ChannelConfigUpdateFailed
 | NodeError::DuplicatePayment
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.

Ideally, DuplicatePayment should become a sub-error within the lightning error category.
We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.
Comment threadldk-server/src/api/onchain_send.rs

Comment on lines

+17
 to 
+20

 LdkServerError::new(
 InvalidRequestError,
 "Address is not valid for LdkServer's configured network.".to_string(),
 )
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.

We use it where we can but provide more context by directly using LdkServerError to be more helpful.
@jkczyzjkczyzFeb 28, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.
Comment threadldk-server/src/api/get_payment_details.rs
Outdated

@G8XSU
G8XSU
requested a review
from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz
reviewed
Feb 28, 2025
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
d60055d to
f795976CompareFebruary 28, 2025 20:40
@G8XSU
G8XSU
commented
Feb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Squashed fixups.
@G8XSU
G8XSU
merged commit b70ab5b
into
lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels

Weekly GoalSomeone wants to land this this week

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Use LdkServerError for error handling in all APIs. by G8XSU · Pull Request #46 · lightningdevkit/ldk-server · GitHub
Skip to content
Use LdkServerError for error handling in all APIs. - #46
Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Feb 28, 2025
Merged
Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Conversation
@G8XSU
@G8XSUG8XSU
commented
Feb 26, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Use LdkServerError for error handling in all APIs.
@G8XSU
G8XSU
requested a review
from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
f2e47f5 to
878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU
marked this pull request as ready for review
February 27, 2025 00:40
@G8XSUG8XSU
mentioned this pull request
Feb 27, 2025

Closed

13 tasks
@G8XSUG8XSU
added
the 
Weekly Goal
Someone wants to land this this week
label
Feb 27, 2025
jkczyz
jkczyz
reviewed
Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
 | NodeError::ChannelCreationFailed
 | NodeError::ChannelClosingFailed
 | NodeError::ChannelConfigUpdateFailed
 | NodeError::DuplicatePayment
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.

Ideally, DuplicatePayment should become a sub-error within the lightning error category.
We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.
Comment threadldk-server/src/api/onchain_send.rs

Comment on lines

+17
 to 
+20

 LdkServerError::new(
 InvalidRequestError,
 "Address is not valid for LdkServer's configured network.".to_string(),
 )
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.

We use it where we can but provide more context by directly using LdkServerError to be more helpful.
@jkczyzjkczyzFeb 28, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.
Comment threadldk-server/src/api/get_payment_details.rs
Outdated

@G8XSU
G8XSU
requested a review
from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz
reviewed
Feb 28, 2025
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
d60055d to
f795976CompareFebruary 28, 2025 20:40
@G8XSU
G8XSU
commented
Feb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Squashed fixups.
@G8XSU
G8XSU
merged commit b70ab5b
into
lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels

Weekly GoalSomeone wants to land this this week

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use LdkServerError for error handling in all APIs. by G8XSU · Pull Request #46 · lightningdevkit/ldk-server · GitHub
Skip to content
Use LdkServerError for error handling in all APIs. - #46
Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Feb 28, 2025
Merged
Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Conversation
@G8XSU
@G8XSUG8XSU
commented
Feb 26, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Use LdkServerError for error handling in all APIs.
@G8XSU
G8XSU
requested a review
from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
f2e47f5 to
878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU
marked this pull request as ready for review
February 27, 2025 00:40
@G8XSUG8XSU
mentioned this pull request
Feb 27, 2025

Closed

13 tasks
@G8XSUG8XSU
added
the 
Weekly Goal
Someone wants to land this this week
label
Feb 27, 2025
jkczyz
jkczyz
reviewed
Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
 | NodeError::ChannelCreationFailed
 | NodeError::ChannelClosingFailed
 | NodeError::ChannelConfigUpdateFailed
 | NodeError::DuplicatePayment
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.

Ideally, DuplicatePayment should become a sub-error within the lightning error category.
We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.
Comment threadldk-server/src/api/onchain_send.rs

Comment on lines

+17
 to 
+20

 LdkServerError::new(
 InvalidRequestError,
 "Address is not valid for LdkServer's configured network.".to_string(),
 )
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.

We use it where we can but provide more context by directly using LdkServerError to be more helpful.
@jkczyzjkczyzFeb 28, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.
Comment threadldk-server/src/api/get_payment_details.rs
Outdated

@G8XSU
G8XSU
requested a review
from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz
reviewed
Feb 28, 2025
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
d60055d to
f795976CompareFebruary 28, 2025 20:40
@G8XSU
G8XSU
commented
Feb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Squashed fixups.
@G8XSU
G8XSU
merged commit b70ab5b
into
lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels

Weekly GoalSomeone wants to land this this week

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use LdkServerError for error handling in all APIs. by G8XSU · Pull Request #46 · lightningdevkit/ldk-server · GitHub
Skip to content
Use LdkServerError for error handling in all APIs. - #46
Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Feb 28, 2025
Merged
Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Conversation
@G8XSU
@G8XSUG8XSU
commented
Feb 26, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Use LdkServerError for error handling in all APIs.
@G8XSU
G8XSU
requested a review
from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
f2e47f5 to
878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU
marked this pull request as ready for review
February 27, 2025 00:40
@G8XSUG8XSU
mentioned this pull request
Feb 27, 2025

Closed

13 tasks
@G8XSUG8XSU
added
the 
Weekly Goal
Someone wants to land this this week
label
Feb 27, 2025
jkczyz
jkczyz
reviewed
Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
 | NodeError::ChannelCreationFailed
 | NodeError::ChannelClosingFailed
 | NodeError::ChannelConfigUpdateFailed
 | NodeError::DuplicatePayment
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.

Ideally, DuplicatePayment should become a sub-error within the lightning error category.
We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.
Comment threadldk-server/src/api/onchain_send.rs

Comment on lines

+17
 to 
+20

 LdkServerError::new(
 InvalidRequestError,
 "Address is not valid for LdkServer's configured network.".to_string(),
 )
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.

We use it where we can but provide more context by directly using LdkServerError to be more helpful.
@jkczyzjkczyzFeb 28, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.
Comment threadldk-server/src/api/get_payment_details.rs
Outdated

@G8XSU
G8XSU
requested a review
from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz
reviewed
Feb 28, 2025
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
d60055d to
f795976CompareFebruary 28, 2025 20:40
@G8XSU
G8XSU
commented
Feb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Squashed fixups.
@G8XSU
G8XSU
merged commit b70ab5b
into
lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels

Weekly GoalSomeone wants to land this this week

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Use LdkServerError for error handling in all APIs. by G8XSU · Pull Request #46 · lightningdevkit/ldk-server · GitHub
Skip to content
Use LdkServerError for error handling in all APIs. - #46
Merged
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Feb 28, 2025
Merged
Use LdkServerError for error handling in all APIs.#46
G8XSU merged 24 commits into
lightningdevkit:mainfrom 
G8XSU:25-02-error-handling
Conversation
@G8XSU
@G8XSUG8XSU
commented
Feb 26, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Use LdkServerError for error handling in all APIs.
@G8XSU
G8XSU
requested a review
from jkczyzFebruary 27, 2025 00:38
@G8XSU
Derive traits for LdkServerError.
2fb0278
@G8XSU
Implement Display & std::Error for LdkServerError.
87e6c01
@G8XSU
Add constructor for LdkServerError.
5389155
@G8XSU
Return LdkServerError from NodeService.
0e9181b
@G8XSU
Return LdkServerError from GetNodeInfo API.
221116f
@G8XSU
Return LdkServerError from GetBalances API.
88095eb
@G8XSU
Impl from<NodeError> for LdkServerError.
8dd2ae0
@G8XSU
Return LdkServerError from OnchainReceive API.
3b8c96b
@G8XSU
Return LdkServerError from OnchainSend API.
d43f9f0
@G8XSU
Return LdkServerError from Bolt11Receive API.
5c08b42
@G8XSU
Return LdkServerError from Bolt11Send API.
bc0cb45
@G8XSU
Return LdkServerError from Bolt12Receive API.
8aa6bde
@G8XSU
Return LdkServerError from Bolt12Send API.
403941b
@G8XSU
Return LdkServerError from OpenChannel API.
d6cc6d9
@G8XSU
Return LdkServerError from CloseChannel API.
029a28d
@G8XSU
Return LdkServerError from ListChannels API.
cd91495
@G8XSU
Return LdkServerError from UpdateChannelConfig API.
f8015cd
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
f2e47f5 to
878b52eCompareFebruary 27, 2025 00:39
@G8XSU
G8XSU
marked this pull request as ready for review
February 27, 2025 00:40
@G8XSUG8XSU
mentioned this pull request
Feb 27, 2025

Closed

13 tasks
@G8XSUG8XSU
added
the 
Weekly Goal
Someone wants to land this this week
label
Feb 27, 2025
jkczyz
jkczyz
reviewed
Feb 27, 2025
View reviewed changes
Comment threadldk-server/src/api/error.rs
 | NodeError::ChannelCreationFailed
 | NodeError::ChannelClosingFailed
 | NodeError::ChannelConfigUpdateFailed
 | NodeError::DuplicatePayment
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked through these exhaustively, but for BOLT11 DuplicatePayment is returned if the user tries to pay an invoice with the same payment hash twice. So shouldn't it map to an InvalidRequestError? Though for BOLT12 it would happen if we randomly generate the same payment id, which shouldn't happen.
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mark DuplicatePayment as invalid-request with certainty, it could be a legitimate race-condition on client side or idempotency failure.

Ideally, DuplicatePayment should become a sub-error within the lightning error category.
We typically use invalid-request for requests that can be safely ignored or can’t be fixed programmatically, but DuplicatePayment might indicate a successful payment the client didn’t register.
Comment threadldk-server/src/api/onchain_send.rs

Comment on lines

+17
 to 
+20

 LdkServerError::new(
 InvalidRequestError,
 "Address is not valid for LdkServer's configured network.".to_string(),
 )
@jkczyzjkczyzFeb 27, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need use the mapping here in order to provide a more specific error?
@G8XSUG8XSUFeb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, using the mapping makes the error less specific, since we can't customize the error message for specific scenario.

We use it where we can but provide more context by directly using LdkServerError to be more helpful.
@jkczyzjkczyzFeb 28, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant to say "not use" not "need use" lol.
Comment threadldk-server/src/api/get_payment_details.rs
Outdated

@G8XSU
G8XSU
requested a review
from jkczyzFebruary 28, 2025 19:56
jkczyz
jkczyz
reviewed
Feb 28, 2025
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.
@G8XSU
G8XSUforce-pushed
the
25-02-error-handling
branch
from
d60055d to
f795976CompareFebruary 28, 2025 20:40
@G8XSU
G8XSU
commented
Feb 28, 2025

Copy link


Copy Markdown

ContributorAuthor
Squashed fixups.
@G8XSU
G8XSU
merged commit b70ab5b
into
lightningdevkit:mainFeb 28, 2025
rsafier pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
@G8XSU
Merge pull requestlightningdevkit#46from G8XSU/25-02-error-handling
9281da1
Use LdkServerError for error handling in all APIs.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels

Weekly GoalSomeone wants to land this this week

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@jkczyz