Hook up ChannelConfig in open channel endpoint & add to cli by benthecarman · Pull Request #81 · lightningdevkit/ldk-server

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

benthecarman · 2025-12-10T00:33:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

ldk-reviews-bot · 2025-12-10T00:33:55Z

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

tnull · 2025-12-10T09:08:53Z

We had this in the proto files but was not hooked up on the server side or on the cli. This adds it on both ends

Hmm, I think context might be lightningdevkit/ldk-node#385 / #16 (comment). Do you think it's fine to move ahead as-is now, or do we really need ldk-node#385? If not, can we close the latter for now?

benthecarman · 2025-12-10T09:29:52Z

I saw that todo but it seemed separate. That is for updating the channel config, not setting it on open

wpaulino · 2025-12-10T19:00:51Z

+ #[arg(long, help = "Forwarding fee proportional (in millionths of a satoshi)")]
+ forwarding_fee_proportional_millionths: Option<u32>,
+ #[arg(long, help = "Forwarding fee base (in milli-satoshi)")]
+ forwarding_fee_base_msat: Option<u32>,
+ #[arg(long, help = "CLTV expiry delta")]
+ cltv_expiry_delta: Option<u32>,
+ #[arg(long, help = "Force close avoidance max fee (in satoshis)")]
+ force_close_avoidance_max_fee_satoshis: Option<u64>,
+ #[arg(long, help = "Accept underpaying HTLCs")]
+ accept_underpaying_htlcs: Option<bool>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fixed limit (in milli-satoshi)",
+ conflicts_with = "max_dust_htlc_fee_rate_multiplier"
+ )]
+ max_dust_htlc_fixed_limit_msat: Option<u64>,
+ #[arg(
+ long,
+ help = "Max dust HTLC exposure as fee rate multiplier",
+ conflicts_with = "max_dust_htlc_fixed_limit_msat"
+ )]
+ max_dust_htlc_fee_rate_multiplier: Option<u64>,


Some of these options could really use some more documentation, but at the same time, I wouldn't expect users to set these in most cases. Maybe we just keep the forwarding specific ones for now and revisit the others if there's interest from users?

Added more docs and removed some of the options that doesn't really make sense for users

These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Hook up ChannelConfig in open channel endpoint
40f5ddc

ldk-reviews-bot requested a review from wpaulino December 10, 2025 00:44

tnull requested review from tnull and removed request for wpaulino December 10, 2025 09:07

wpaulino reviewed Dec 10, 2025
View reviewed changes

benthecarman force-pushed the open-channel-cfg branch from 5dc39d2 to 3fd7800Compare December 11, 2025 00:20

tnull removed their request for review December 11, 2025 13:42

wpaulino reviewed Dec 11, 2025
View reviewed changes

Comment threadldk-server-cli/src/main.rs Outdated

benthecarman added this to Weekly Goals Dec 11, 2025

benthecarman self-assigned this Dec 11, 2025

Add ChannelConfig options to open channel cli command
22cae11
These were available on the server side but not in the cli. Not all options are given as they aren't likely to be used and more likely to be confusing to users.

benthecarman force-pushed the open-channel-cfg branch from 3fd7800 to 22cae11Compare December 11, 2025 18:05

wpaulino approved these changes Dec 11, 2025
View reviewed changes

wpaulino merged commit 0d02e50 into lightningdevkit:mainDec 11, 2025
7 checks passed

github-project-automationBot moved this to Done in Weekly Goals Dec 11, 2025

benthecarman deleted the open-channel-cfg branch December 11, 2025 18:24

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#81from benthecarman/open-channel-cfg
6448c25
Hook up ChannelConfig in open channel endpoint & add to cli

Uh oh!

Conversation

benthecarman commented Dec 10, 2025

Uh oh!

ldk-reviews-bot commented Dec 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tnull commented Dec 10, 2025

Uh oh!

benthecarman commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

benthecarman commented Dec 10, 2025

Uh oh!

ldk-reviews-bot commented Dec 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tnull commented Dec 10, 2025

Uh oh!

benthecarman commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

benthecarman commented Dec 10, 2025

Uh oh!

ldk-reviews-bot commented Dec 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tnull commented Dec 10, 2025

Uh oh!

benthecarman commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

benthecarman commented Dec 10, 2025

Uh oh!

ldk-reviews-bot commented Dec 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

ldk-reviews-bot commented Dec 10, 2025•
edited
Loading

ldk-reviews-bot commented Dec 10, 2025•
edited
Loading

ldk-reviews-bot commented Dec 10, 2025•
edited
Loading

ldk-reviews-bot commented Dec 10, 2025•
edited
Loading

ldk-reviews-bot commented Dec 10, 2025•
edited
Loading