Remove explicit print in lightning-net-tokio, reduce redundant block connection logging by TheBlueMatt · Pull Request #1048 · lightningdevkit/rust-lightning

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt · 2021-08-17T00:49:06Z

Fixes#980.

codecov · 2021-08-17T02:55:33Z

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## main #1048 +/- ##
==========================================
+ Coverage 90.96% 92.26% +1.30% 
==========================================
Files 64 65 +1 Lines 32447 38813 +6366 ==========================================
+ Hits 29515 35812 +6297 - Misses 2932 3001 +69

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	`93.75% <ø> (ø)`
lightning-net-tokio/src/lib.rs	`76.98% <50.00%> (-0.38%)`	⬇️
lightning/src/ln/peer_handler.rs	`45.75% <75.00%> (-0.23%)`	⬇️
lightning/src/chain/chainmonitor.rs	`95.91% <100.00%> (+0.11%)`	⬆️
lightning/src/chain/channelmonitor.rs	`91.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/ser_macros.rs	`90.50% <0.00%> (-5.24%)`	⬇️
lightning/src/ln/shutdown_tests.rs	`95.58% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.90% <0.00%> (+0.03%)`	⬆️
lightning/src/ln/functional_tests.rs	`98.66% <0.00%> (+1.36%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

TheBlueMatt · 2021-08-17T19:48:32Z

Addressed feedback and added one more commit to clean up docs.

valentinewallace · 2021-08-17T20:24:06Z

 	}

 	fn transaction_unconfirmed(&self, txid: &Txid) {
+ log_debug!(self.logger, "{} reorganized out of chain", txid);


suggestion: s/{}/txid {}

How about Transaction {}?

It isn't exactly a critical error situation when we disconnect a socket, so we shouldn't be printing to stderr, entirely bypassing user logging, when it happens. We do still print to stderr if we fail to write the first message to the socket, but this should never happen unless the user has a reasonably-configured system with at least one packet in bytes available for the socket buffer.

For users with many ChannelMonitors, we log a large volume per block simply because each ChannelMonitor lots several times per block. Instead, we move to log only once at the TRACE level per block call in ChannelMonitors, relying instead on a DEBUG level log in ChainMonitor before we call any ChannelMonitor functions. For most users, this will reduce redundant logging and also log at the DEBUG level for block events, which is appropriate. Fixeslightningdevkit#980.

TheBlueMatt · 2021-08-17T21:03:49Z

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
fn transaction_unconfirmed(&self, txid: &Txid) {
- log_debug!(self.logger, "{} reorganized out of chain", txid);
+ log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
let monitors = self.monitors.read().unwrap();

This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt · 2021-08-17T21:12:48Z

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
///
$

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

TheBlueMatt added this to the 0.0.101 milestone Aug 17, 2021

jkczyz reviewed Aug 17, 2021
View reviewed changes

Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated

TheBlueMatt force-pushed the 2021-08-no-net-print branch from cf84655 to 0fa452eCompare August 17, 2021 02:21

jkczyz approved these changes Aug 17, 2021
View reviewed changes

Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/chainmonitor.rs Outdated
Comment threadlightning/src/chain/channelmonitor.rs Outdated

jkczyz approved these changes Aug 17, 2021
View reviewed changes

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

TheBlueMatt added 3 commits August 17, 2021 21:03

Ensure we always at least log at TRACE when a peer disconnects
2e02aa7

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 77178c6 to 5d84704Compare August 17, 2021 21:03

valentinewallace approved these changes Aug 17, 2021
View reviewed changes

Clarify docs on ShutdownScript::new_witness_program somewhat
35d0b7a
This is especially important for C or other language bindings clients as the `version` field may be exported as a `u8`.

TheBlueMatt force-pushed the 2021-08-no-net-print branch from 5d84704 to 35d0b7aCompare August 17, 2021 21:12

TheBlueMatt merged commit 803d804 into lightningdevkit:mainAug 18, 2021

Uh oh!

Conversation

TheBlueMatt commented Aug 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 17, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheBlueMatt commented Aug 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Aug 17, 2021

Uh oh!

TheBlueMatt commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

TheBlueMatt commented Aug 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 17, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheBlueMatt commented Aug 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Aug 17, 2021

Uh oh!

TheBlueMatt commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

TheBlueMatt commented Aug 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 17, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 17, 2021•
edited
Loading

codecovBot commented Aug 17, 2021•
edited
Loading

codecovBot commented Aug 17, 2021•
edited
Loading

codecovBot commented Aug 17, 2021•
edited
Loading