Skip to content

One final fix + cut 0.0.103 - #1153

Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged

One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2021-11-0.0.103

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Nov 3, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

@TheBlueMattTheBlueMatt added this to the 0.0.103 milestone Nov 3, 2021
@codecov

codecovBot commented Nov 3, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.

ariard
ariard reviewed Nov 3, 2021
View reviewed changes

@ariardariard left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.

Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed the 2021-11-0.0.103 branch 2 times, most recently from e4511b0 to b43e814CompareNovember 3, 2021 02:12
@ariard

ariard commented Nov 3, 2021

Copy link
Copy Markdown

ACK b43e814

@TheBlueMatt

TheBlueMatt commented Nov 3, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Squashed without diff. Will land after CI 🎉

$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt merged commit e3bdfa0 into lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz reviewed Nov 3, 2021
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉

Comment threadCHANGELOG.md
## API Updates
* This release is almost entirely focused on a new API in the
`lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
struct which takes a reference to a `ChannelManager` and a `NetworkGraph`

@jkczyzjkczyzNov 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.

@TheBlueMattTheBlueMattNov 3, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment on lines +44 to +48
* If a payment is sent, creating an outbound HTLC and sending it to our
counterparty (implying the `ChannelMonitor` was persisted on disk), but the
`ChannelManager` was not persisted prior to shutdown/crash, no
`Event::PaymentPathFailed` event will be generated if the HTLC is eventually
failed on chain (#1104).

@jkczyzjkczyzNov 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.

@TheBlueMattTheBlueMattNov 3, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.

@TheBlueMattTheBlueMatt mentioned this pull request Nov 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes
+1 more reviewer
@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
One final fix + cut 0.0.103 by TheBlueMatt · Pull Request #1153 · lightningdevkit/rust-lightning · GitHub
Skip to content
One final fix + cut 0.0.103 - #1153
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged
One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.103 milestone
Nov 3, 2021
@codecov
codecovBot
commented
Nov 3, 2021•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3 
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.
ariard
ariard
reviewed
Nov 3, 2021
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed
the
2021-11-0.0.103
branch
2 times, most recently
from
e4511b0 to
b43e814CompareNovember 3, 2021 02:12
@ariard
ariard
commented
Nov 3, 2021

Copy link


Copy Markdown

ACK b43e814
@TheBlueMatt
TheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Squashed without diff. Will land after CI 🎉
$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt
merged commit e3bdfa0
into
lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz
reviewed
Nov 3, 2021
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉
Comment threadCHANGELOG.md
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md

Comment on lines

+44
 to 
+48

 * If a payment is sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.
@TheBlueMattTheBlueMatt
mentioned this pull request
Nov 3, 2021
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
One final fix + cut 0.0.103 by TheBlueMatt · Pull Request #1153 · lightningdevkit/rust-lightning · GitHub
Skip to content
One final fix + cut 0.0.103 - #1153
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged
One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.103 milestone
Nov 3, 2021
@codecov
codecovBot
commented
Nov 3, 2021•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3 
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.
ariard
ariard
reviewed
Nov 3, 2021
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed
the
2021-11-0.0.103
branch
2 times, most recently
from
e4511b0 to
b43e814CompareNovember 3, 2021 02:12
@ariard
ariard
commented
Nov 3, 2021

Copy link


Copy Markdown

ACK b43e814
@TheBlueMatt
TheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Squashed without diff. Will land after CI 🎉
$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt
merged commit e3bdfa0
into
lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz
reviewed
Nov 3, 2021
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉
Comment threadCHANGELOG.md
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md

Comment on lines

+44
 to 
+48

 * If a payment is sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.
@TheBlueMattTheBlueMatt
mentioned this pull request
Nov 3, 2021
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
One final fix + cut 0.0.103 by TheBlueMatt · Pull Request #1153 · lightningdevkit/rust-lightning · GitHub
Skip to content
One final fix + cut 0.0.103 - #1153
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged
One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.103 milestone
Nov 3, 2021
@codecov
codecovBot
commented
Nov 3, 2021•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3 
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.
ariard
ariard
reviewed
Nov 3, 2021
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed
the
2021-11-0.0.103
branch
2 times, most recently
from
e4511b0 to
b43e814CompareNovember 3, 2021 02:12
@ariard
ariard
commented
Nov 3, 2021

Copy link


Copy Markdown

ACK b43e814
@TheBlueMatt
TheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Squashed without diff. Will land after CI 🎉
$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt
merged commit e3bdfa0
into
lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz
reviewed
Nov 3, 2021
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉
Comment threadCHANGELOG.md
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md

Comment on lines

+44
 to 
+48

 * If a payment is sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.
@TheBlueMattTheBlueMatt
mentioned this pull request
Nov 3, 2021
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
One final fix + cut 0.0.103 by TheBlueMatt · Pull Request #1153 · lightningdevkit/rust-lightning · GitHub
Skip to content
One final fix + cut 0.0.103 - #1153
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged
One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.103 milestone
Nov 3, 2021
@codecov
codecovBot
commented
Nov 3, 2021•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3 
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.
ariard
ariard
reviewed
Nov 3, 2021
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed
the
2021-11-0.0.103
branch
2 times, most recently
from
e4511b0 to
b43e814CompareNovember 3, 2021 02:12
@ariard
ariard
commented
Nov 3, 2021

Copy link


Copy Markdown

ACK b43e814
@TheBlueMatt
TheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Squashed without diff. Will land after CI 🎉
$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt
merged commit e3bdfa0
into
lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz
reviewed
Nov 3, 2021
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉
Comment threadCHANGELOG.md
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md

Comment on lines

+44
 to 
+48

 * If a payment is sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.
@TheBlueMattTheBlueMatt
mentioned this pull request
Nov 3, 2021
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
One final fix + cut 0.0.103 by TheBlueMatt · Pull Request #1153 · lightningdevkit/rust-lightning · GitHub
Skip to content
One final fix + cut 0.0.103 - #1153
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged
One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.103 milestone
Nov 3, 2021
@codecov
codecovBot
commented
Nov 3, 2021•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3 
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.
ariard
ariard
reviewed
Nov 3, 2021
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed
the
2021-11-0.0.103
branch
2 times, most recently
from
e4511b0 to
b43e814CompareNovember 3, 2021 02:12
@ariard
ariard
commented
Nov 3, 2021

Copy link


Copy Markdown

ACK b43e814
@TheBlueMatt
TheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Squashed without diff. Will land after CI 🎉
$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt
merged commit e3bdfa0
into
lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz
reviewed
Nov 3, 2021
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉
Comment threadCHANGELOG.md
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md

Comment on lines

+44
 to 
+48

 * If a payment is sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.
@TheBlueMattTheBlueMatt
mentioned this pull request
Nov 3, 2021
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
One final fix + cut 0.0.103 by TheBlueMatt · Pull Request #1153 · lightningdevkit/rust-lightning · GitHub
Skip to content
One final fix + cut 0.0.103 - #1153
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged
One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.103 milestone
Nov 3, 2021
@codecov
codecovBot
commented
Nov 3, 2021•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3 
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.
ariard
ariard
reviewed
Nov 3, 2021
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed
the
2021-11-0.0.103
branch
2 times, most recently
from
e4511b0 to
b43e814CompareNovember 3, 2021 02:12
@ariard
ariard
commented
Nov 3, 2021

Copy link


Copy Markdown

ACK b43e814
@TheBlueMatt
TheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Squashed without diff. Will land after CI 🎉
$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt
merged commit e3bdfa0
into
lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz
reviewed
Nov 3, 2021
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉
Comment threadCHANGELOG.md
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md

Comment on lines

+44
 to 
+48

 * If a payment is sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.
@TheBlueMattTheBlueMatt
mentioned this pull request
Nov 3, 2021
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
One final fix + cut 0.0.103 by TheBlueMatt · Pull Request #1153 · lightningdevkit/rust-lightning · GitHub
Skip to content
One final fix + cut 0.0.103 - #1153
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Nov 3, 2021
Merged
One final fix + cut 0.0.103#1153
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2021-11-0.0.103
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.103 milestone
Nov 3, 2021
@codecov
codecovBot
commented
Nov 3, 2021•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1153 (2b837bb) into main (55fc0a1) will decrease coverage by 0.00%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## main #1153 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01% 
==========================================
Files 70 70 Lines 36386 36386 ==========================================
- Hits 32804 32801 -3 - Misses 3582 3585 +3 
Impacted FilesCoverage Δ
lightning/src/routing/scorer.rs34.42% <ø> (ø)
lightning/src/ln/functional_tests.rs97.29% <0.00%> (-0.06%)⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 55fc0a1...2b837bb. Read the comment docs.
ariard
ariard
reviewed
Nov 3, 2021
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM. I checked the change logs since 0.0.102 and that all relevant new stuff is mentioned.
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMattforce-pushed
the
2021-11-0.0.103
branch
2 times, most recently
from
e4511b0 to
b43e814CompareNovember 3, 2021 02:12
@ariard
ariard
commented
Nov 3, 2021

Copy link


Copy Markdown

ACK b43e814
@TheBlueMatt
TheBlueMatt
commented
Nov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Squashed without diff. Will land after CI 🎉
$ git diff-tree -U1 b43e81402 2b837bb27
$

@TheBlueMatt
TheBlueMatt
merged commit e3bdfa0
into
lightningdevkit:mainNov 3, 2021
jkczyz
jkczyz
reviewed
Nov 3, 2021
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review of the CHANGELOG. All else LGTM! 🎉
Comment threadCHANGELOG.md
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace NetworkGraph with Router. I almost wonder if we should move the Router trait to the lightning crate.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, IMO.
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md

Comment on lines

+44
 to 
+48

 * If a payment is sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
@jkczyzjkczyzNov 3, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be worded in terms of what the bug was whereas the previous bullet is worded in terms of how the bug was fixed.
@TheBlueMattTheBlueMattNov 3, 2021

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we've generally worded in terms of the bug, but I wasn't really sure how to word the previous in terms of the bug and still have it be clear. I'll try, though.
@TheBlueMattTheBlueMatt
mentioned this pull request
Nov 3, 2021
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.103

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@ariard@jkczyz@valentinewallace