Skip to content

0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Nov 5, 2021
Merged

0.0.103 CHANGELOG tweaks from Jeff #1154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31cd00e
0.0.103 CHANGELOG tweaks from Jeff
TheBlueMatt Nov 3, 2021
7df087a
Add note about PaymentId fields to 0.0.103 changelog
TheBlueMatt Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
* This release is almost entirely focused on a new API in the
`lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
struct which takes a reference to a `ChannelManager` and a `Router`
and retries payments as paths fail. It limits retries to a configurable
number, but is not serialized to disk and may retry additional times across
a serialization/load. In order to learn about failed payments, it must
receive `Event`s directly from the `ChannelManager`, wrapping a
user-provided `EventHandler` which it provides all unhandled events to
(#1059).
* `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
struct in replacement of a number of its long list of arguments (#1134).
`Payee` is further stored in the `Route` object returned and provided in the
`RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
* `ChannelMonitor`s must now be persisted after calls which provide new block
* `get_route` has been renamed `find_route` (#1059) and now takes a
`RouteParameters` struct in replacement of a number of its long list of
arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
`Route` object returned and provided in the `RouteParameters` contained in
`Event::PaymentPathFailed` (#1059).
* `ChannelMonitor`s must now be persisted after calls that provide new block
data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
processing. If you are using a `ChainMonitor` this is handled for you.
The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
* `Event::PaymentSent` now includes the full fee which was spent across all
payment paths which were fulfilled or pending when the payment was fulfilled
(#1142).
* `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
`PaymentId` which matches the `PaymentId` returned from
`ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
* `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
shared references to the graph data to make serialization and references to
the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
* `routing::Score::channel_penalty_msat` has been updated to provide the
`NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
* Delay disconnecting peers if we receive messages from them even if it takes
a while to receive a pong from them. Further, avoid sending too many gossip
messages between pings to ensure we should always receive pongs in a timely
manner. Together, these should significantly reduce instances of us failing
to remain connected to a peer during initial gossip sync (#1137).
* If a payment is sent, creating an outbound HTLC and sending it to our
* Previous versions would often disconnect peers during initial graph sync due
to ping timeouts while processing large numbers of gossip messages. We now
delay disconnecting peers if we receive messages from them even if it takes
a while to receive a pong from them. Further, we avoid sending too many
gossip messages between pings to ensure we should always receive pongs in a
timely manner (#1137).
* If a payment was sent, creating an outbound HTLC and sending it to our
counterparty (implying the `ChannelMonitor` was persisted on disk), but the
`ChannelManager` was not persisted prior to shutdown/crash, no
`Event::PaymentPathFailed` event will be generated if the HTLC is eventually
failed on chain (#1104).
`Event::PaymentPathFailed` event was generated if the HTLC was eventually
failed on chain. Events are now consistent irrespective of `ChannelManager`
persistence or non-persistence (#1104).

## Serialization Compatibility
* All above new Events/fields are ignored by prior clients. All above new
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
0.0.103 CHANGELOG tweaks from Jeff by TheBlueMatt · Pull Request #1154 · lightningdevkit/rust-lightning · GitHub
Skip to content
0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Nov 5, 2021
 Merged


0.0.103 CHANGELOG tweaks from Jeff
#1154
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
31cd00e

0.0.103 CHANGELOG tweaks from Jeff


TheBlueMatt Nov 3, 2021
7df087a

Add note about PaymentId fields to 0.0.103 changelog


TheBlueMatt Nov 3, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


34 changes: 20 additions & 14 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
 struct which takes a reference to a `ChannelManager` and a `Router`
 and retries payments as paths fail. It limits retries to a configurable
 number, but is not serialized to disk and may retry additional times across
 a serialization/load. In order to learn about failed payments, it must
 receive `Event`s directly from the `ChannelManager`, wrapping a
 user-provided `EventHandler` which it provides all unhandled events to
 (#1059).
 * `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
 struct in replacement of a number of its long list of arguments (#1134).
 `Payee` is further stored in the `Route` object returned and provided in the
 `RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls which provide new block
 * `get_route` has been renamed `find_route` (#1059) and now takes a
 `RouteParameters` struct in replacement of a number of its long list of
 arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
 `Route` object returned and provided in the `RouteParameters` contained in
 `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls that provide new block
 data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
 processing. If you are using a `ChainMonitor` this is handled for you.
 The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
 * `Event::PaymentSent` now includes the full fee which was spent across all
 payment paths which were fulfilled or pending when the payment was fulfilled
 (#1142).
 * `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
 `PaymentId` which matches the `PaymentId` returned from
 `ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
 * `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
 shared references to the graph data to make serialization and references to
 the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
 * `routing::Score::channel_penalty_msat` has been updated to provide the
 `NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
 * Delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, avoid sending too many gossip
 messages between pings to ensure we should always receive pongs in a timely
 manner. Together, these should significantly reduce instances of us failing
 to remain connected to a peer during initial gossip sync (#1137).
 * If a payment is sent, creating an outbound HTLC and sending it to our
 * Previous versions would often disconnect peers during initial graph sync due
 to ping timeouts while processing large numbers of gossip messages. We now
 delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, we avoid sending too many
 gossip messages between pings to ensure we should always receive pongs in a
 timely manner (#1137).
 * If a payment was sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
 `Event::PaymentPathFailed` event was generated if the HTLC was eventually
 failed on chain. Events are now consistent irrespective of `ChannelManager`
 persistence or non-persistence (#1104).

## Serialization Compatibility
 * All above new Events/fields are ignored by prior clients. All above new
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
0.0.103 CHANGELOG tweaks from Jeff by TheBlueMatt · Pull Request #1154 · lightningdevkit/rust-lightning · GitHub
Skip to content
0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Nov 5, 2021
 Merged


0.0.103 CHANGELOG tweaks from Jeff
#1154
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
31cd00e

0.0.103 CHANGELOG tweaks from Jeff


TheBlueMatt Nov 3, 2021
7df087a

Add note about PaymentId fields to 0.0.103 changelog


TheBlueMatt Nov 3, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


34 changes: 20 additions & 14 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
 struct which takes a reference to a `ChannelManager` and a `Router`
 and retries payments as paths fail. It limits retries to a configurable
 number, but is not serialized to disk and may retry additional times across
 a serialization/load. In order to learn about failed payments, it must
 receive `Event`s directly from the `ChannelManager`, wrapping a
 user-provided `EventHandler` which it provides all unhandled events to
 (#1059).
 * `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
 struct in replacement of a number of its long list of arguments (#1134).
 `Payee` is further stored in the `Route` object returned and provided in the
 `RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls which provide new block
 * `get_route` has been renamed `find_route` (#1059) and now takes a
 `RouteParameters` struct in replacement of a number of its long list of
 arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
 `Route` object returned and provided in the `RouteParameters` contained in
 `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls that provide new block
 data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
 processing. If you are using a `ChainMonitor` this is handled for you.
 The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
 * `Event::PaymentSent` now includes the full fee which was spent across all
 payment paths which were fulfilled or pending when the payment was fulfilled
 (#1142).
 * `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
 `PaymentId` which matches the `PaymentId` returned from
 `ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
 * `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
 shared references to the graph data to make serialization and references to
 the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
 * `routing::Score::channel_penalty_msat` has been updated to provide the
 `NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
 * Delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, avoid sending too many gossip
 messages between pings to ensure we should always receive pongs in a timely
 manner. Together, these should significantly reduce instances of us failing
 to remain connected to a peer during initial gossip sync (#1137).
 * If a payment is sent, creating an outbound HTLC and sending it to our
 * Previous versions would often disconnect peers during initial graph sync due
 to ping timeouts while processing large numbers of gossip messages. We now
 delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, we avoid sending too many
 gossip messages between pings to ensure we should always receive pongs in a
 timely manner (#1137).
 * If a payment was sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
 `Event::PaymentPathFailed` event was generated if the HTLC was eventually
 failed on chain. Events are now consistent irrespective of `ChannelManager`
 persistence or non-persistence (#1104).

## Serialization Compatibility
 * All above new Events/fields are ignored by prior clients. All above new
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
0.0.103 CHANGELOG tweaks from Jeff by TheBlueMatt · Pull Request #1154 · lightningdevkit/rust-lightning · GitHub
Skip to content
0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Nov 5, 2021
 Merged


0.0.103 CHANGELOG tweaks from Jeff
#1154
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
31cd00e

0.0.103 CHANGELOG tweaks from Jeff


TheBlueMatt Nov 3, 2021
7df087a

Add note about PaymentId fields to 0.0.103 changelog


TheBlueMatt Nov 3, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


34 changes: 20 additions & 14 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
 struct which takes a reference to a `ChannelManager` and a `Router`
 and retries payments as paths fail. It limits retries to a configurable
 number, but is not serialized to disk and may retry additional times across
 a serialization/load. In order to learn about failed payments, it must
 receive `Event`s directly from the `ChannelManager`, wrapping a
 user-provided `EventHandler` which it provides all unhandled events to
 (#1059).
 * `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
 struct in replacement of a number of its long list of arguments (#1134).
 `Payee` is further stored in the `Route` object returned and provided in the
 `RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls which provide new block
 * `get_route` has been renamed `find_route` (#1059) and now takes a
 `RouteParameters` struct in replacement of a number of its long list of
 arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
 `Route` object returned and provided in the `RouteParameters` contained in
 `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls that provide new block
 data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
 processing. If you are using a `ChainMonitor` this is handled for you.
 The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
 * `Event::PaymentSent` now includes the full fee which was spent across all
 payment paths which were fulfilled or pending when the payment was fulfilled
 (#1142).
 * `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
 `PaymentId` which matches the `PaymentId` returned from
 `ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
 * `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
 shared references to the graph data to make serialization and references to
 the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
 * `routing::Score::channel_penalty_msat` has been updated to provide the
 `NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
 * Delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, avoid sending too many gossip
 messages between pings to ensure we should always receive pongs in a timely
 manner. Together, these should significantly reduce instances of us failing
 to remain connected to a peer during initial gossip sync (#1137).
 * If a payment is sent, creating an outbound HTLC and sending it to our
 * Previous versions would often disconnect peers during initial graph sync due
 to ping timeouts while processing large numbers of gossip messages. We now
 delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, we avoid sending too many
 gossip messages between pings to ensure we should always receive pongs in a
 timely manner (#1137).
 * If a payment was sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
 `Event::PaymentPathFailed` event was generated if the HTLC was eventually
 failed on chain. Events are now consistent irrespective of `ChannelManager`
 persistence or non-persistence (#1104).

## Serialization Compatibility
 * All above new Events/fields are ignored by prior clients. All above new
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
0.0.103 CHANGELOG tweaks from Jeff by TheBlueMatt · Pull Request #1154 · lightningdevkit/rust-lightning · GitHub
Skip to content
0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Nov 5, 2021
 Merged


0.0.103 CHANGELOG tweaks from Jeff
#1154
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
31cd00e

0.0.103 CHANGELOG tweaks from Jeff


TheBlueMatt Nov 3, 2021
7df087a

Add note about PaymentId fields to 0.0.103 changelog


TheBlueMatt Nov 3, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


34 changes: 20 additions & 14 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
 struct which takes a reference to a `ChannelManager` and a `Router`
 and retries payments as paths fail. It limits retries to a configurable
 number, but is not serialized to disk and may retry additional times across
 a serialization/load. In order to learn about failed payments, it must
 receive `Event`s directly from the `ChannelManager`, wrapping a
 user-provided `EventHandler` which it provides all unhandled events to
 (#1059).
 * `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
 struct in replacement of a number of its long list of arguments (#1134).
 `Payee` is further stored in the `Route` object returned and provided in the
 `RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls which provide new block
 * `get_route` has been renamed `find_route` (#1059) and now takes a
 `RouteParameters` struct in replacement of a number of its long list of
 arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
 `Route` object returned and provided in the `RouteParameters` contained in
 `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls that provide new block
 data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
 processing. If you are using a `ChainMonitor` this is handled for you.
 The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
 * `Event::PaymentSent` now includes the full fee which was spent across all
 payment paths which were fulfilled or pending when the payment was fulfilled
 (#1142).
 * `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
 `PaymentId` which matches the `PaymentId` returned from
 `ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
 * `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
 shared references to the graph data to make serialization and references to
 the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
 * `routing::Score::channel_penalty_msat` has been updated to provide the
 `NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
 * Delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, avoid sending too many gossip
 messages between pings to ensure we should always receive pongs in a timely
 manner. Together, these should significantly reduce instances of us failing
 to remain connected to a peer during initial gossip sync (#1137).
 * If a payment is sent, creating an outbound HTLC and sending it to our
 * Previous versions would often disconnect peers during initial graph sync due
 to ping timeouts while processing large numbers of gossip messages. We now
 delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, we avoid sending too many
 gossip messages between pings to ensure we should always receive pongs in a
 timely manner (#1137).
 * If a payment was sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
 `Event::PaymentPathFailed` event was generated if the HTLC was eventually
 failed on chain. Events are now consistent irrespective of `ChannelManager`
 persistence or non-persistence (#1104).

## Serialization Compatibility
 * All above new Events/fields are ignored by prior clients. All above new
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
0.0.103 CHANGELOG tweaks from Jeff by TheBlueMatt · Pull Request #1154 · lightningdevkit/rust-lightning · GitHub
Skip to content
0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Nov 5, 2021
 Merged


0.0.103 CHANGELOG tweaks from Jeff
#1154
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
31cd00e

0.0.103 CHANGELOG tweaks from Jeff


TheBlueMatt Nov 3, 2021
7df087a

Add note about PaymentId fields to 0.0.103 changelog


TheBlueMatt Nov 3, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


34 changes: 20 additions & 14 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
 struct which takes a reference to a `ChannelManager` and a `Router`
 and retries payments as paths fail. It limits retries to a configurable
 number, but is not serialized to disk and may retry additional times across
 a serialization/load. In order to learn about failed payments, it must
 receive `Event`s directly from the `ChannelManager`, wrapping a
 user-provided `EventHandler` which it provides all unhandled events to
 (#1059).
 * `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
 struct in replacement of a number of its long list of arguments (#1134).
 `Payee` is further stored in the `Route` object returned and provided in the
 `RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls which provide new block
 * `get_route` has been renamed `find_route` (#1059) and now takes a
 `RouteParameters` struct in replacement of a number of its long list of
 arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
 `Route` object returned and provided in the `RouteParameters` contained in
 `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls that provide new block
 data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
 processing. If you are using a `ChainMonitor` this is handled for you.
 The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
 * `Event::PaymentSent` now includes the full fee which was spent across all
 payment paths which were fulfilled or pending when the payment was fulfilled
 (#1142).
 * `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
 `PaymentId` which matches the `PaymentId` returned from
 `ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
 * `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
 shared references to the graph data to make serialization and references to
 the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
 * `routing::Score::channel_penalty_msat` has been updated to provide the
 `NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
 * Delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, avoid sending too many gossip
 messages between pings to ensure we should always receive pongs in a timely
 manner. Together, these should significantly reduce instances of us failing
 to remain connected to a peer during initial gossip sync (#1137).
 * If a payment is sent, creating an outbound HTLC and sending it to our
 * Previous versions would often disconnect peers during initial graph sync due
 to ping timeouts while processing large numbers of gossip messages. We now
 delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, we avoid sending too many
 gossip messages between pings to ensure we should always receive pongs in a
 timely manner (#1137).
 * If a payment was sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
 `Event::PaymentPathFailed` event was generated if the HTLC was eventually
 failed on chain. Events are now consistent irrespective of `ChannelManager`
 persistence or non-persistence (#1104).

## Serialization Compatibility
 * All above new Events/fields are ignored by prior clients. All above new
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
0.0.103 CHANGELOG tweaks from Jeff by TheBlueMatt · Pull Request #1154 · lightningdevkit/rust-lightning · GitHub
Skip to content
0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Nov 5, 2021
 Merged


0.0.103 CHANGELOG tweaks from Jeff
#1154
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
31cd00e

0.0.103 CHANGELOG tweaks from Jeff


TheBlueMatt Nov 3, 2021
7df087a

Add note about PaymentId fields to 0.0.103 changelog


TheBlueMatt Nov 3, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


34 changes: 20 additions & 14 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
 struct which takes a reference to a `ChannelManager` and a `Router`
 and retries payments as paths fail. It limits retries to a configurable
 number, but is not serialized to disk and may retry additional times across
 a serialization/load. In order to learn about failed payments, it must
 receive `Event`s directly from the `ChannelManager`, wrapping a
 user-provided `EventHandler` which it provides all unhandled events to
 (#1059).
 * `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
 struct in replacement of a number of its long list of arguments (#1134).
 `Payee` is further stored in the `Route` object returned and provided in the
 `RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls which provide new block
 * `get_route` has been renamed `find_route` (#1059) and now takes a
 `RouteParameters` struct in replacement of a number of its long list of
 arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
 `Route` object returned and provided in the `RouteParameters` contained in
 `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls that provide new block
 data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
 processing. If you are using a `ChainMonitor` this is handled for you.
 The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
 * `Event::PaymentSent` now includes the full fee which was spent across all
 payment paths which were fulfilled or pending when the payment was fulfilled
 (#1142).
 * `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
 `PaymentId` which matches the `PaymentId` returned from
 `ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
 * `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
 shared references to the graph data to make serialization and references to
 the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
 * `routing::Score::channel_penalty_msat` has been updated to provide the
 `NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
 * Delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, avoid sending too many gossip
 messages between pings to ensure we should always receive pongs in a timely
 manner. Together, these should significantly reduce instances of us failing
 to remain connected to a peer during initial gossip sync (#1137).
 * If a payment is sent, creating an outbound HTLC and sending it to our
 * Previous versions would often disconnect peers during initial graph sync due
 to ping timeouts while processing large numbers of gossip messages. We now
 delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, we avoid sending too many
 gossip messages between pings to ensure we should always receive pongs in a
 timely manner (#1137).
 * If a payment was sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
 `Event::PaymentPathFailed` event was generated if the HTLC was eventually
 failed on chain. Events are now consistent irrespective of `ChannelManager`
 persistence or non-persistence (#1104).

## Serialization Compatibility
 * All above new Events/fields are ignored by prior clients. All above new
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
0.0.103 CHANGELOG tweaks from Jeff by TheBlueMatt · Pull Request #1154 · lightningdevkit/rust-lightning · GitHub
Skip to content
0.0.103 CHANGELOG tweaks from Jeff#1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Nov 5, 2021
 Merged


0.0.103 CHANGELOG tweaks from Jeff
#1154
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
31cd00e

0.0.103 CHANGELOG tweaks from Jeff


TheBlueMatt Nov 3, 2021
7df087a

Add note about PaymentId fields to 0.0.103 changelog


TheBlueMatt Nov 3, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


34 changes: 20 additions & 14 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,18 +3,19 @@
## API Updates
 * This release is almost entirely focused on a new API in the
 `lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
 struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
 struct which takes a reference to a `ChannelManager` and a `Router`
 and retries payments as paths fail. It limits retries to a configurable
 number, but is not serialized to disk and may retry additional times across
 a serialization/load. In order to learn about failed payments, it must
 receive `Event`s directly from the `ChannelManager`, wrapping a
 user-provided `EventHandler` which it provides all unhandled events to
 (#1059).
 * `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
 struct in replacement of a number of its long list of arguments (#1134).
 `Payee` is further stored in the `Route` object returned and provided in the
 `RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls which provide new block
 * `get_route` has been renamed `find_route` (#1059) and now takes a
 `RouteParameters` struct in replacement of a number of its long list of
 arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
 `Route` object returned and provided in the `RouteParameters` contained in
 `Event::PaymentPathFailed` (#1059).
 * `ChannelMonitor`s must now be persisted after calls that provide new block
 data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
 processing. If you are using a `ChainMonitor` this is handled for you.
 The `Persist` API has been updated to `Option`ally take the
Expand All@@ -29,23 +30,28 @@
 * `Event::PaymentSent` now includes the full fee which was spent across all
 payment paths which were fulfilled or pending when the payment was fulfilled
 (#1142).
 * `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
 `PaymentId` which matches the `PaymentId` returned from
 `ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
 * `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
 shared references to the graph data to make serialization and references to
 the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
 * `routing::Score::channel_penalty_msat` has been updated to provide the
 `NodeId` of both the source and destination nodes of a channel (#1133).

## Bug Fixes
 * Delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, avoid sending too many gossip
 messages between pings to ensure we should always receive pongs in a timely
 manner. Together, these should significantly reduce instances of us failing
 to remain connected to a peer during initial gossip sync (#1137).
 * If a payment is sent, creating an outbound HTLC and sending it to our
 * Previous versions would often disconnect peers during initial graph sync due
 to ping timeouts while processing large numbers of gossip messages. We now
 delay disconnecting peers if we receive messages from them even if it takes
 a while to receive a pong from them. Further, we avoid sending too many
 gossip messages between pings to ensure we should always receive pongs in a
 timely manner (#1137).
 * If a payment was sent, creating an outbound HTLC and sending it to our
 counterparty (implying the `ChannelMonitor` was persisted on disk), but the
 `ChannelManager` was not persisted prior to shutdown/crash, no
 `Event::PaymentPathFailed` event will be generated if the HTLC is eventually
 failed on chain (#1104).
 `Event::PaymentPathFailed` event was generated if the HTLC was eventually
 failed on chain. Events are now consistent irrespective of `ChannelManager`
 persistence or non-persistence (#1104).

## Serialization Compatibility
 * All above new Events/fields are ignored by prior clients. All above new
Expand Down