Uh oh!
There was an error while loading. Please reload this page.
ChannelManager-less phantom invoices - #1384
Merged
TheBlueMatt merged 2 commits intoApr 13, 2022
Merged
Conversation
As part of preparing to expose some of its methods as pub for ChannelManager-less phantom invoice generation. Pure code move of the module + the addition of module-level documentation
valentinewallaceforce-pushed
the
2022-03-chanmanless-phantom-invoices
branch
from
March 28, 2022 20:05
e21cb5f to
8e506f2CompareCodecov Report
@@ Coverage Diff @@## main #1384 +/- ##
==========================================
+ Coverage 90.82% 91.79% +0.97%
==========================================
Files 73 74 +1 Lines 41237 49074 +7837 Branches 41237 49074 +7837 ==========================================
+ Hits 37452 45046 +7594 - Misses 3785 4028 +243
Continue to review full report at Codecov.
|
dunxen
reviewed
Apr 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TheBlueMatt
previously approved these changes
Apr 10, 2022
TheBlueMatt
left a comment
Collaborator
There was a problem hiding this comment.
LGTM modulo the above grammar suggestions.
jkczyz
self-requested a review
April 11, 2022 14:30
TheBlueMatt
commented
Apr 11, 2022
Collaborator
Please squash! |
valentinewallaceforce-pushed
the
2022-03-chanmanless-phantom-invoices
branch
from
April 11, 2022 22:44
ae4cf6d to
204dd42Comparedunxen
approved these changes
Apr 12, 2022
jkczyz
approved these changes
Apr 12, 2022
TheBlueMatt
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#1295
Basically a code move plus some docs updates