Uh oh!
There was an error while loading. Please reload this page.
Pass counterparty_node_id to fail_holding_cell_htlcs - #1524
Conversation
codecov-commenter
commented
Jun 6, 2022
Codecov Report
@@ Coverage Diff @@## main #1524 +/- ##
==========================================
- Coverage 90.93% 90.88% -0.05%
==========================================
Files 80 80 Lines 43386 43375 -11 Branches 43386 43375 -11 ==========================================
- Hits 39451 39422 -29 - Misses 3935 3953 +18
Continue to review full report at Codecov.
|
tnull
left a comment
There was a problem hiding this comment.
LGTM, only two tiny formatting nits.
| // failed backwards or, if they were one of our outgoing HTLCs, then their failure needs to | ||
| // be surfaced to the user. | ||
| fn fail_holding_cell_htlcs(&self, mut htlcs_to_fail: Vec<(HTLCSource, PaymentHash)>, channel_id: [u8; 32]) { | ||
| fn fail_holding_cell_htlcs(&self, mut htlcs_to_fail: Vec<(HTLCSource, PaymentHash)>, channel_id: [u8; 32], _counterparty_node_id: &PublicKey) { |
There was a problem hiding this comment.
nit: you probably should wrap this line at 100 characters width.
| Ok((commitment_opt, holding_cell_failed_htlcs)) => { | ||
| if !holding_cell_failed_htlcs.is_empty() { | ||
| failed_htlcs.push((holding_cell_failed_htlcs, *channel_id)); | ||
| failed_htlcs.push((holding_cell_failed_htlcs, *channel_id, chan.get_counterparty_node_id())); |
There was a problem hiding this comment.
nit: same here: wrap at 100 chars.
ViktorT-11
commented
Jun 7, 2022
tnull
commented
Jun 8, 2022
Yeah, I think we currently follow the policy to slowly improve the quality and formatting in parts we touch. Hopefully, though, we may be able to adopt |
cd59bc8 to
6032a56CompareViktorT-11
commented
Jun 8, 2022
Ok great thanks :)! Squashed the line wrapping fixup without changes. |
Both #1507 and #1403 needs the
counterparty_node_idto be passed toChannelManager::fail_holding_cell_htlcs. This PR simply passes the parameter to the function, so that both PRs can be based on this.