Uh oh!
There was an error while loading. Please reload this page.
Cut 0.0.109 - #1582
Conversation
Codecov Report
@@ Coverage Diff @@## main #1582 +/- ##
==========================================
+ Coverage 91.04% 91.18% +0.14%
==========================================
Files 80 80 Lines 44095 45354 +1259 Branches 44095 45354 +1259 ==========================================
+ Hits 40145 41357 +1212 - Misses 3950 3997 +47
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
9a9f53f to
43ecbb0Compare| * `ChannelDetails` now contains a copy of the current `ChannelConfig` (#1527). | ||
| * The `lightning-invoice` crate now optionally depends on `serde`, with | ||
| `Invoice` implementing `serde::{Deserialize,Serialize}` if enabled (#1548). | ||
| * Several fields in `UserConfig` have been renamed for clarity (#1540). |
There was a problem hiding this comment.
Maybe add a mention of #1531, from now on transactions given to funding_transaction_generated() must be final and ready to broadcast ?
There was a problem hiding this comment.
Hmm, I figured skip it - we certainly already required that transactions be final, so its not a change, its just a stricter enforcement of existing preconditions.
| * Jeffrey Czyz | ||
| * Matt Corallo | ||
| * Matt Faltyn | ||
| * NicolaLS |
There was a problem hiding this comment.
According to git log :
- Matt Faltyn -> Mateusz Faltyn
- NicolaLS -> Nicola Leonardo Susca
(o any contributor reading the releasing notes, if we mispel or get wrong the names, please accept our excuses, if you also have a preference to be listed with GH handle or other nickname, let it know I think we're fine with that.
There was a problem hiding this comment.
Huh? I see the following for NicolaLS. Where did you get the name, or the name for Mr Faltyn? I don't see Mateusz anywhere? CC @NicolaLS and @mattfaltyn.
In general I prefer to just use git shortlog (ie what is configured with git commit --author=... cause it makes it easy to automate things, but if someone prefers a different name we can replace.
commit 6c15de1399f2c1a3f9b1c384af17e59135d7f335 (upstream/pull/1548)
Author: NicolaLS <email omitted>
There was a problem hiding this comment.
mhm I don't even know how I set the name (it's def not in my config) but it's fine for me either way :)
There was a problem hiding this comment.
mhm I don't even know how I set the name (it's def not in my config)
You can simply set it via git config user.name "My Name" for each repository, but may add the --global flag if you'd like to make it ... global.
There was a problem hiding this comment.
I get the following when I do `git log | grep "Faltyn".Author: Mateusz Faltyn <mateuszfaltyn@Mateuszs-MacBook-Air-2.local>
So I dunno.
There was a problem hiding this comment.
Ah, I was going based on github profile, indeed, it seems he's changed his configured name on git. I guess we should be consistent, I'm happy to pick either one. For now I'll update the 107 release notes to use just "Matt" given that's on his GH.
| backward compatibility wrapper is required, please open an issue. | ||
| In total, this release features 32 files changed, 1839 insertions, 490 | ||
| deletions in 31 commits from 9 authors, in alphabetical order: |
There was a problem hiding this comment.
from 15 PRs, I don't thing it matters but good for me to tick them to check we have forgotten nothing of worthy a mention.
There was a problem hiding this comment.
Yes, definitely still worth checking if there's anything we missed.
43ecbb0 to
27ba14eCompareTheBlueMatt
commented
Jul 1, 2022
Updated with #1585, will need a squash after that lands. |
TheBlueMatt
commented
Jul 1, 2022
Rebased after #1585 and squashed, should be good to go! |
No description provided.