Cut 0.0.111 - #1712

Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged

Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2022-09-111

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Sep 9, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@TheBlueMattTheBlueMatt added this to the 0.0.111 milestone Sep 9, 2022
valentinewallace
valentinewallace reviewed Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md Outdated
valentinewallace
valentinewallace reviewed Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
* HTLCs which fail prior to being sent over their first hop are now marked as
retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
* Dust HTLCs are now considered failed in the payment tracking logic after the
commitment transaction confirms, allowing retry on restart (#1691).

@valentinewallacevalentinewallaceSep 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?

@wpaulinowpaulinoSep 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.

@TheBlueMattTheBlueMattSep 9, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.

@valentinewallace

valentinewallace commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already

@ariard

ariard commented Sep 9, 2022

Copy link
Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already

Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things

@wpaulino

wpaulino commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

Wondering how people check if any PRs are missing?

My go-to is git log --merges v0.0.110..HEAD.

@valentinewallace

valentinewallace commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

git log --merges v0.0.110..HEAD

Super handy, thanks!

tnull
tnull reviewed Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md Outdated
to avoid delaying other messages (#1604. #1660, #1683).
* Rather than spawning a full OS thread, `lightning-background-processor` has
a new `process_events_async` method which takes the place of a
`BackgroundProcessor` for those using Rust async (#1657).

@tnulltnullSep 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).

@TheBlueMattTheBlueMattSep 9, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s

Comment threadCHANGELOG.md Outdated
valentinewallace
valentinewallace reviewed Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace reviewed Sep 9, 2022
View reviewed changes

@valentinewallacevalentinewallace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback

Comment threadCHANGELOG.md
jkczyz
jkczyz reviewed Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated

## Backwards Compatibility
* The new `current_time` argument to `PeerManager` constructors must be set to
a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)

@jkczyzjkczyzSep 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period

@TheBlueMattTheBlueMattSep 9, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".

Comment threadCHANGELOG.md
ariard
ariard reviewed Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard reviewed Sep 9, 2022
View reviewed changes

@ariardariard left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM

Comment threadCHANGELOG.md
* Dust HTLCs are now considered failed in the payment tracking logic after the
commitment transaction confirms, allowing retry on restart (#1691).
* On machines with buggy "monotonic" clocks, LDK will no longer panic if time
goes backwards (#1692).

@ariardariardSep 9, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.

@TheBlueMattTheBlueMattSep 9, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)

@TheBlueMatt
TheBlueMattforce-pushed the 2022-09-111 branch 2 times, most recently from 7e90cbc to e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter

codecov-commenter commented Sep 9, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TheBlueMatt

TheBlueMatt commented Sep 9, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).

jkczyz
jkczyz previously approved these changes Sep 9, 2022
View reviewed changes
ariard
ariard previously approved these changes Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt dismissed stale reviews from ariard and jkczyz via c3f5d51September 11, 2022 16:58
@TheBlueMatt

TheBlueMatt commented Sep 11, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.

@TheBlueMatt

TheBlueMatt commented Sep 12, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Okay, hopefully the last CHANGELOG update, fixed the stats again.

@TheBlueMatt

TheBlueMatt commented Sep 12, 2022•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Squashed, the relevant changes are:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman

valentinewallace
valentinewallace previously approved these changes Sep 12, 2022
View reviewed changes
jkczyz
jkczyz previously approved these changes Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
@TheBlueMatt

TheBlueMatt commented Sep 12, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.

@TheBlueMatt

TheBlueMatt commented Sep 12, 2022

Copy link
Copy Markdown
CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).

@TheBlueMatt
TheBlueMatt merged commit 4ae65e8 into lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes
+1 more reviewer
@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Cut 0.0.111 - #1712
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged
Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.111 milestone
Sep 9, 2022
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
 * HTLCs which fail prior to being sent over their first hop are now marked as
 retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
@valentinewallacevalentinewallaceSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?
@wpaulinowpaulinoSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
@ariard
ariard
commented
Sep 9, 2022

Copy link


Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things
@wpaulino
wpaulino
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing?
My go-to is git log --merges v0.0.110..HEAD.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
git log --merges v0.0.110..HEAD
Super handy, thanks!
tnull
tnull
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

 to avoid delaying other messages (#1604. #1660, #1683).
 * Rather than spawning a full OS thread, `lightning-background-processor` has
 a new `process_events_async` method which takes the place of a
 `BackgroundProcessor` for those using Rust async (#1657).
@tnulltnullSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback
Comment threadCHANGELOG.md
jkczyz
jkczyz
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


## Backwards Compatibility
 * The new `current_time` argument to `PeerManager` constructors must be set to
 a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)
@jkczyzjkczyzSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM
Comment threadCHANGELOG.md
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
 * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
 goes backwards (#1692).
@ariardariardSep 9, 2022

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)
@TheBlueMatt
TheBlueMattforce-pushed
the
2022-09-111
branch
2 times, most recently
from
7e90cbc to
e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter
codecov-commenter
commented
Sep 9, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.

The diff coverage is n/a.
@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2 
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@TheBlueMatt
TheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).
jkczyz
jkczyz
previously approved these changes
Sep 9, 2022
View reviewed changes
ariard
ariard
previously approved these changes
Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt
dismissed stale reviews from ariard and jkczyz
via
c3f5d51September 11, 2022 16:58
@TheBlueMatt
TheBlueMatt
commented
Sep 11, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Okay, hopefully the last CHANGELOG update, fixed the stats again.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Squashed, the relevant changes are:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman
valentinewallace
valentinewallace
previously approved these changes
Sep 12, 2022
View reviewed changes
jkczyz
jkczyz
previously approved these changes
Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).
@TheBlueMatt
TheBlueMatt
merged commit 4ae65e8
into
lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.111 - #1712
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged
Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.111 milestone
Sep 9, 2022
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
 * HTLCs which fail prior to being sent over their first hop are now marked as
 retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
@valentinewallacevalentinewallaceSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?
@wpaulinowpaulinoSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
@ariard
ariard
commented
Sep 9, 2022

Copy link


Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things
@wpaulino
wpaulino
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing?
My go-to is git log --merges v0.0.110..HEAD.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
git log --merges v0.0.110..HEAD
Super handy, thanks!
tnull
tnull
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

 to avoid delaying other messages (#1604. #1660, #1683).
 * Rather than spawning a full OS thread, `lightning-background-processor` has
 a new `process_events_async` method which takes the place of a
 `BackgroundProcessor` for those using Rust async (#1657).
@tnulltnullSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback
Comment threadCHANGELOG.md
jkczyz
jkczyz
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


## Backwards Compatibility
 * The new `current_time` argument to `PeerManager` constructors must be set to
 a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)
@jkczyzjkczyzSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM
Comment threadCHANGELOG.md
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
 * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
 goes backwards (#1692).
@ariardariardSep 9, 2022

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)
@TheBlueMatt
TheBlueMattforce-pushed
the
2022-09-111
branch
2 times, most recently
from
7e90cbc to
e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter
codecov-commenter
commented
Sep 9, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.

The diff coverage is n/a.
@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2 
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@TheBlueMatt
TheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).
jkczyz
jkczyz
previously approved these changes
Sep 9, 2022
View reviewed changes
ariard
ariard
previously approved these changes
Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt
dismissed stale reviews from ariard and jkczyz
via
c3f5d51September 11, 2022 16:58
@TheBlueMatt
TheBlueMatt
commented
Sep 11, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Okay, hopefully the last CHANGELOG update, fixed the stats again.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Squashed, the relevant changes are:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman
valentinewallace
valentinewallace
previously approved these changes
Sep 12, 2022
View reviewed changes
jkczyz
jkczyz
previously approved these changes
Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).
@TheBlueMatt
TheBlueMatt
merged commit 4ae65e8
into
lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.111 - #1712
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged
Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.111 milestone
Sep 9, 2022
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
 * HTLCs which fail prior to being sent over their first hop are now marked as
 retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
@valentinewallacevalentinewallaceSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?
@wpaulinowpaulinoSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
@ariard
ariard
commented
Sep 9, 2022

Copy link


Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things
@wpaulino
wpaulino
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing?
My go-to is git log --merges v0.0.110..HEAD.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
git log --merges v0.0.110..HEAD
Super handy, thanks!
tnull
tnull
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

 to avoid delaying other messages (#1604. #1660, #1683).
 * Rather than spawning a full OS thread, `lightning-background-processor` has
 a new `process_events_async` method which takes the place of a
 `BackgroundProcessor` for those using Rust async (#1657).
@tnulltnullSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback
Comment threadCHANGELOG.md
jkczyz
jkczyz
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


## Backwards Compatibility
 * The new `current_time` argument to `PeerManager` constructors must be set to
 a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)
@jkczyzjkczyzSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM
Comment threadCHANGELOG.md
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
 * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
 goes backwards (#1692).
@ariardariardSep 9, 2022

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)
@TheBlueMatt
TheBlueMattforce-pushed
the
2022-09-111
branch
2 times, most recently
from
7e90cbc to
e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter
codecov-commenter
commented
Sep 9, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.

The diff coverage is n/a.
@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2 
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@TheBlueMatt
TheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).
jkczyz
jkczyz
previously approved these changes
Sep 9, 2022
View reviewed changes
ariard
ariard
previously approved these changes
Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt
dismissed stale reviews from ariard and jkczyz
via
c3f5d51September 11, 2022 16:58
@TheBlueMatt
TheBlueMatt
commented
Sep 11, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Okay, hopefully the last CHANGELOG update, fixed the stats again.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Squashed, the relevant changes are:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman
valentinewallace
valentinewallace
previously approved these changes
Sep 12, 2022
View reviewed changes
jkczyz
jkczyz
previously approved these changes
Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).
@TheBlueMatt
TheBlueMatt
merged commit 4ae65e8
into
lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Cut 0.0.111 - #1712
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged
Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.111 milestone
Sep 9, 2022
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
 * HTLCs which fail prior to being sent over their first hop are now marked as
 retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
@valentinewallacevalentinewallaceSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?
@wpaulinowpaulinoSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
@ariard
ariard
commented
Sep 9, 2022

Copy link


Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things
@wpaulino
wpaulino
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing?
My go-to is git log --merges v0.0.110..HEAD.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
git log --merges v0.0.110..HEAD
Super handy, thanks!
tnull
tnull
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

 to avoid delaying other messages (#1604. #1660, #1683).
 * Rather than spawning a full OS thread, `lightning-background-processor` has
 a new `process_events_async` method which takes the place of a
 `BackgroundProcessor` for those using Rust async (#1657).
@tnulltnullSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback
Comment threadCHANGELOG.md
jkczyz
jkczyz
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


## Backwards Compatibility
 * The new `current_time` argument to `PeerManager` constructors must be set to
 a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)
@jkczyzjkczyzSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM
Comment threadCHANGELOG.md
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
 * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
 goes backwards (#1692).
@ariardariardSep 9, 2022

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)
@TheBlueMatt
TheBlueMattforce-pushed
the
2022-09-111
branch
2 times, most recently
from
7e90cbc to
e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter
codecov-commenter
commented
Sep 9, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.

The diff coverage is n/a.
@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2 
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@TheBlueMatt
TheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).
jkczyz
jkczyz
previously approved these changes
Sep 9, 2022
View reviewed changes
ariard
ariard
previously approved these changes
Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt
dismissed stale reviews from ariard and jkczyz
via
c3f5d51September 11, 2022 16:58
@TheBlueMatt
TheBlueMatt
commented
Sep 11, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Okay, hopefully the last CHANGELOG update, fixed the stats again.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Squashed, the relevant changes are:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman
valentinewallace
valentinewallace
previously approved these changes
Sep 12, 2022
View reviewed changes
jkczyz
jkczyz
previously approved these changes
Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).
@TheBlueMatt
TheBlueMatt
merged commit 4ae65e8
into
lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.111 - #1712
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged
Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.111 milestone
Sep 9, 2022
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
 * HTLCs which fail prior to being sent over their first hop are now marked as
 retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
@valentinewallacevalentinewallaceSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?
@wpaulinowpaulinoSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
@ariard
ariard
commented
Sep 9, 2022

Copy link


Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things
@wpaulino
wpaulino
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing?
My go-to is git log --merges v0.0.110..HEAD.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
git log --merges v0.0.110..HEAD
Super handy, thanks!
tnull
tnull
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

 to avoid delaying other messages (#1604. #1660, #1683).
 * Rather than spawning a full OS thread, `lightning-background-processor` has
 a new `process_events_async` method which takes the place of a
 `BackgroundProcessor` for those using Rust async (#1657).
@tnulltnullSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback
Comment threadCHANGELOG.md
jkczyz
jkczyz
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


## Backwards Compatibility
 * The new `current_time` argument to `PeerManager` constructors must be set to
 a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)
@jkczyzjkczyzSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM
Comment threadCHANGELOG.md
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
 * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
 goes backwards (#1692).
@ariardariardSep 9, 2022

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)
@TheBlueMatt
TheBlueMattforce-pushed
the
2022-09-111
branch
2 times, most recently
from
7e90cbc to
e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter
codecov-commenter
commented
Sep 9, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.

The diff coverage is n/a.
@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2 
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@TheBlueMatt
TheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).
jkczyz
jkczyz
previously approved these changes
Sep 9, 2022
View reviewed changes
ariard
ariard
previously approved these changes
Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt
dismissed stale reviews from ariard and jkczyz
via
c3f5d51September 11, 2022 16:58
@TheBlueMatt
TheBlueMatt
commented
Sep 11, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Okay, hopefully the last CHANGELOG update, fixed the stats again.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Squashed, the relevant changes are:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman
valentinewallace
valentinewallace
previously approved these changes
Sep 12, 2022
View reviewed changes
jkczyz
jkczyz
previously approved these changes
Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).
@TheBlueMatt
TheBlueMatt
merged commit 4ae65e8
into
lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.111 - #1712
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged
Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.111 milestone
Sep 9, 2022
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
 * HTLCs which fail prior to being sent over their first hop are now marked as
 retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
@valentinewallacevalentinewallaceSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?
@wpaulinowpaulinoSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
@ariard
ariard
commented
Sep 9, 2022

Copy link


Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things
@wpaulino
wpaulino
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing?
My go-to is git log --merges v0.0.110..HEAD.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
git log --merges v0.0.110..HEAD
Super handy, thanks!
tnull
tnull
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

 to avoid delaying other messages (#1604. #1660, #1683).
 * Rather than spawning a full OS thread, `lightning-background-processor` has
 a new `process_events_async` method which takes the place of a
 `BackgroundProcessor` for those using Rust async (#1657).
@tnulltnullSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback
Comment threadCHANGELOG.md
jkczyz
jkczyz
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


## Backwards Compatibility
 * The new `current_time` argument to `PeerManager` constructors must be set to
 a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)
@jkczyzjkczyzSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM
Comment threadCHANGELOG.md
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
 * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
 goes backwards (#1692).
@ariardariardSep 9, 2022

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)
@TheBlueMatt
TheBlueMattforce-pushed
the
2022-09-111
branch
2 times, most recently
from
7e90cbc to
e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter
codecov-commenter
commented
Sep 9, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.

The diff coverage is n/a.
@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2 
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@TheBlueMatt
TheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).
jkczyz
jkczyz
previously approved these changes
Sep 9, 2022
View reviewed changes
ariard
ariard
previously approved these changes
Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt
dismissed stale reviews from ariard and jkczyz
via
c3f5d51September 11, 2022 16:58
@TheBlueMatt
TheBlueMatt
commented
Sep 11, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Okay, hopefully the last CHANGELOG update, fixed the stats again.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Squashed, the relevant changes are:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman
valentinewallace
valentinewallace
previously approved these changes
Sep 12, 2022
View reviewed changes
jkczyz
jkczyz
previously approved these changes
Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).
@TheBlueMatt
TheBlueMatt
merged commit 4ae65e8
into
lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Cut 0.0.111 - #1712
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Sep 13, 2022
Merged
Cut 0.0.111#1712
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2022-09-111
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

Collaborator
 No description provided. 
@TheBlueMattTheBlueMatt
added this to the 0.0.111 milestone
Sep 9, 2022
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
 * HTLCs which fail prior to being sent over their first hop are now marked as
 retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
@valentinewallacevalentinewallaceSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ChannelMonitors safe to remove now?
@wpaulinowpaulinoSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
@ariard
ariard
commented
Sep 9, 2022

Copy link


Copy Markdown

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already
Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things
@wpaulino
wpaulino
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
Wondering how people check if any PRs are missing?
My go-to is git log --merges v0.0.110..HEAD.
@valentinewallace
valentinewallace
commented
Sep 9, 2022

Copy link


Copy Markdown

Contributor
git log --merges v0.0.110..HEAD
Super handy, thanks!
tnull
tnull
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

 to avoid delaying other messages (#1604. #1660, #1683).
 * Rather than spawning a full OS thread, `lightning-background-processor` has
 a new `process_events_async` method which takes the place of a
 `BackgroundProcessor` for those using Rust async (#1657).
@tnulltnullSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

`BackgroundProcessor` for those using Rustasync (#1657).
`BackgroundProcessor` for those using Rust's `async` (#1657).
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"async" isn't a name? Its a programming paradigm, I don't think it needs `s
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Sep 9, 2022
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after outstanding feedback
Comment threadCHANGELOG.md
jkczyz
jkczyz
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


## Backwards Compatibility
 * The new `current_time` argument to `PeerManager` constructors must be set to
 a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)
@jkczyzjkczyzSep 9, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
Comment threadCHANGELOG.md
ariard
ariard
reviewed
Sep 9, 2022
View reviewed changes
@ariardariard
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of PRs SGTM
Comment threadCHANGELOG.md
 * Dust HTLCs are now considered failed in the payment tracking logic after the
 commitment transaction confirms, allowing retry on restart (#1691).
 * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
 goes backwards (#1692).
@ariardariardSep 9, 2022

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if #1659 should be added or to minor.
@TheBlueMattTheBlueMattSep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1712 (comment)
@TheBlueMatt
TheBlueMattforce-pushed
the
2022-09-111
branch
2 times, most recently
from
7e90cbc to
e54a795CompareSeptember 9, 2022 20:20
@codecov-commenter
codecov-commenter
commented
Sep 9, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.

The diff coverage is n/a.
@@ Coverage Diff @@## main #1712 +/- ##
=======================================
Coverage 90.80% 90.80% =======================================
Files 86 86 Lines 46482 46482 Branches 46482 46482 =======================================
+ Hits 42208 42210 +2 + Misses 4274 4272 -2 
Impacted FilesCoverage Δ
lightning/src/ln/monitor_tests.rs99.44% <0.00%> (-0.12%)⬇️
lightning/src/ln/functional_tests.rs96.81% <0.00%> (-0.02%)⬇️
lightning/src/ln/channelmanager.rs85.00% <0.00%> (+0.02%)⬆️
lightning/src/chain/onchaintx.rs94.71% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@TheBlueMatt
TheBlueMatt
commented
Sep 9, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).
jkczyz
jkczyz
previously approved these changes
Sep 9, 2022
View reviewed changes
ariard
ariard
previously approved these changes
Sep 9, 2022
View reviewed changes
@TheBlueMatt
TheBlueMatt
dismissed stale reviews from ariard and jkczyz
via
c3f5d51September 11, 2022 16:58
@TheBlueMatt
TheBlueMatt
commented
Sep 11, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Okay, hopefully the last CHANGELOG update, fixed the stats again.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Squashed, the relevant changes are:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -33,2 +33,3 @@
* `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
* `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
-In total, this release features 82 files changed, 6227 insertions, 1949-deletions in 115 commits from 11 authors, in alphabetical order:+In total, this release features 84 files changed, 6306 insertions, 1960+deletions in 121 commits from 11 authors, in alphabetical order:
* Arik Sosman
valentinewallace
valentinewallace
previously approved these changes
Sep 12, 2022
View reviewed changes
jkczyz
jkczyz
previously approved these changes
Sep 12, 2022
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.
@TheBlueMatt
TheBlueMatt
commented
Sep 12, 2022

Copy link


Copy Markdown

CollaboratorAuthor
$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -1,2 +1,2 @@-# 0.0.111 - 2022-09-09 - "Saturated with Messages"+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"@@ -17,4 +17,4 @@
very difficult to correctly implement (i.e., without blocking). Users
- previously using it should instead pass dependent transactions in via new- `chain::Confirm::transactions_confirmed` calls (#1663).+ previously using it should instead pass dependent transactions in via+ additional `chain::Confirm::transactions_confirmed` calls (#1663).
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
* The new `current_time` argument to `PeerManager` constructors must be set to
- a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).+ a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
* `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
- channels which were observed to go on-chain with LDK versions prior to+ channels that were observed to go on-chain with LDK versions prior to
0.0.111 (#1495).
@TheBlueMatt
TheBlueMatt
merged commit 4ae65e8
into
lightningdevkit:mainSep 13, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments
@wpaulinowpaulinowpaulino left review comments
@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.111

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@valentinewallace@ariard@wpaulino@codecov-commenter@tnull@jkczyz