Expose the channel via which we received a payment by tnull · Pull Request #1856 · lightningdevkit/rust-lightning

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull · 2022-11-16T14:44:16Z

Fixes#1800.
~~Based on #1855~~.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

tnull · 2022-11-16T14:46:06Z

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

TheBlueMatt · 2022-11-16T20:12:52Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

tnull · 2022-11-17T10:40:26Z

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

codecov-commenter · 2022-11-17T12:11:50Z

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (64b9e83) to head (b1b3666).
⚠️ Report is 6930 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/events.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1856 +/- ##
==========================================
- Coverage 90.72% 90.71% -0.01% 
==========================================
Files 91 91 Lines 47999 48042 +43 Branches 47999 48042 +43 ==========================================
+ Hits 43546 43583 +37 - Misses 4453 4459 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

valentinewallace

Basically LGTM

valentinewallace

LGTM after squash

tnull · 2022-11-21T20:43:44Z

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

TheBlueMatt · 2022-11-28T17:34:57Z

Needs rebase now.

tnull · 2022-11-28T17:54:27Z

Rebased on main.

valentinewallace

LGTM after squash :)

TheBlueMatt · 2022-11-29T17:46:38Z

Yes, please squash :)

We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

We expose the current number of confirmations in `ChannelDetails`.

tnull · 2022-11-29T17:51:33Z

Squashed without further changes.

tnull marked this pull request as draft November 16, 2022 14:44

tnull force-pushed the 2022-10-expose-channel-id branch from 0fb6e3e to 132d5daCompare November 17, 2022 10:31

tnull marked this pull request as ready for review November 17, 2022 10:32

tnull added the Seeking Code Review label Nov 17, 2022

tnull added this to the 0.0.113 milestone Nov 17, 2022

tnull force-pushed the 2022-10-expose-channel-id branch 2 times, most recently from 3b6d2df to 86e2039Compare November 17, 2022 12:10

TheBlueMatt reviewed Nov 17, 2022
View reviewed changes

Comment threadlightning/src/ln/channelmanager.rs Outdated

tnull force-pushed the 2022-10-expose-channel-id branch from 86e2039 to c8a9140Compare November 18, 2022 08:55

tnull mentioned this pull request Nov 18, 2022
adds node_id to Event::Payment{Received, Claimed} #1766
Merged

valentinewallace reviewed Nov 21, 2022
View reviewed changes

Comment threadlightning/src/ln/reorg_tests.rs
Comment threadlightning/src/ln/chanmon_update_fail_tests.rs Outdated
Comment threadlightning/src/ln/channel.rs Outdated

valentinewallace removed the Seeking Code Review label Nov 21, 2022

valentinewallace assigned valentinewallace and TheBlueMatt and unassigned valentinewallace Nov 21, 2022

tnull force-pushed the 2022-10-expose-channel-id branch from c8a9140 to e809b92Compare November 21, 2022 19:52

valentinewallace previously approved these changes Nov 21, 2022
View reviewed changes

tnull dismissed valentinewallace’s stale review via fde6014November 21, 2022 20:41

tnull force-pushed the 2022-10-expose-channel-id branch from e809b92 to fde6014Compare November 21, 2022 20:41

valentinewallace previously approved these changes Nov 21, 2022
View reviewed changes

tnull dismissed valentinewallace’s stale review via a6fe64aNovember 28, 2022 17:53

tnull force-pushed the 2022-10-expose-channel-id branch from fde6014 to a6fe64aCompare November 28, 2022 17:53

tnull commented Nov 28, 2022
View reviewed changes

Comment threadlightning/src/ln/channelmanager.rs Outdated

tnull force-pushed the 2022-10-expose-channel-id branch 2 times, most recently from b28bdae to 3625608Compare November 29, 2022 09:53

valentinewallace reviewed Nov 29, 2022
View reviewed changes

tnull added 2 commits November 29, 2022 18:49

Expose the channel via which we received a payment
0edb0e2
We expose the `channel_id` and `user_channel_id` via which we received a payment in the `PaymentReceived` event.

Expose confirmations via ChannelDetails
b1b3666
We expose the current number of confirmations in `ChannelDetails`.

tnull force-pushed the 2022-10-expose-channel-id branch from 3625608 to b1b3666Compare November 29, 2022 17:50

valentinewallace approved these changes Nov 29, 2022
View reviewed changes

TheBlueMatt approved these changes Nov 29, 2022
View reviewed changes

TheBlueMatt merged commit 2c57878 into lightningdevkit:mainNov 29, 2022

shaavan mentioned this pull request Mar 12, 2025
Expand PaymentClaimable to include all inbound channel IDs for a payment #3655
Merged