Skip to content

BOLT 12 spec updates - #1972

Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged

BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom
jkczyz:2023-01-bolt12-spec-updates

Conversation

@jkczyz

@jkczyzjkczyz commented Jan 19, 2023

Copy link
Copy Markdown
Contributor

A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:

  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds

This PR updates the offers module to reflect these. Based on #1926.

@codecov-commenter

codecov-commenter commented Jan 19, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉

Coverage data is based on head (61c9fcb) compared to base (15f1295).
Patch coverage: 97.50% of modified lines in pull request are covered.

❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinewallace

valentinewallace commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

Needs rebase

@jkczyz
jkczyzforce-pushed the 2023-01-bolt12-spec-updates branch 2 times, most recently from 6459cb8 to 61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace reviewed Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs Outdated
@jkczyz
jkczyzforce-pushed the 2023-01-bolt12-spec-updates branch from 61c9fcb to 04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz mentioned this pull request Jan 26, 2023
Merged
TheBlueMatt
TheBlueMatt previously approved these changes Jan 26, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.

valentinewallace
valentinewallace previously approved these changes Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed the 2023-01-bolt12-spec-updates branch from 04d89ce to 5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt reviewed Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
Bounded(NonZeroU64),
/// One or more items.
///
/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item

@TheBlueMattTheBlueMattJan 30, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.

@jkczyzjkczyzJan 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL

@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed the 2023-01-bolt12-spec-updates branch from 5d6469f to 22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt merged commit ccf9215 into lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz mentioned this pull request May 10, 2023
Open
60 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

@valentinewallacevalentinewallace

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
BOLT 12 spec updates by jkczyz · Pull Request #1972 · lightningdevkit/rust-lightning · GitHub
Skip to content
BOLT 12 spec updates - #1972
Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged
BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Conversation
@jkczyz
@jkczyzjkczyz
commented
Jan 19, 2023

Copy link


Copy Markdown

Contributor
A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:
  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds
This PR updates the offers module to reflect these. Based on #1926.
@codecov-commenter
codecov-commenter
commented
Jan 19, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉
Coverage data is based on head (61c9fcb) compared to base (15f1295).

Patch coverage: 97.50% of modified lines in pull request are covered.
❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28 
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallace
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Needs rebase
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
2 times, most recently
from
6459cb8 to
61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace
reviewed
Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs
Outdated

@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
61c9fcb to
04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz
mentioned this pull request
Jan 26, 2023
 Merged

TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 26, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.
valentinewallace
valentinewallace
previously approved these changes
Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
04d89ce to
5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt
reviewed
Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
	Bounded(NonZeroU64),
	/// One or more items.
	///
	/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item
@TheBlueMattTheBlueMattJan 30, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.
@jkczyzjkczyzJan 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL
@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
5d6469f to
22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt
merged commit ccf9215
into
lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
BOLT 12 spec updates by jkczyz · Pull Request #1972 · lightningdevkit/rust-lightning · GitHub
Skip to content
BOLT 12 spec updates - #1972
Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged
BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Conversation
@jkczyz
@jkczyzjkczyz
commented
Jan 19, 2023

Copy link


Copy Markdown

Contributor
A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:
  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds
This PR updates the offers module to reflect these. Based on #1926.
@codecov-commenter
codecov-commenter
commented
Jan 19, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉
Coverage data is based on head (61c9fcb) compared to base (15f1295).

Patch coverage: 97.50% of modified lines in pull request are covered.
❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28 
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallace
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Needs rebase
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
2 times, most recently
from
6459cb8 to
61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace
reviewed
Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs
Outdated

@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
61c9fcb to
04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz
mentioned this pull request
Jan 26, 2023
 Merged

TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 26, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.
valentinewallace
valentinewallace
previously approved these changes
Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
04d89ce to
5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt
reviewed
Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
	Bounded(NonZeroU64),
	/// One or more items.
	///
	/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item
@TheBlueMattTheBlueMattJan 30, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.
@jkczyzjkczyzJan 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL
@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
5d6469f to
22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt
merged commit ccf9215
into
lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
BOLT 12 spec updates by jkczyz · Pull Request #1972 · lightningdevkit/rust-lightning · GitHub
Skip to content
BOLT 12 spec updates - #1972
Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged
BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Conversation
@jkczyz
@jkczyzjkczyz
commented
Jan 19, 2023

Copy link


Copy Markdown

Contributor
A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:
  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds
This PR updates the offers module to reflect these. Based on #1926.
@codecov-commenter
codecov-commenter
commented
Jan 19, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉
Coverage data is based on head (61c9fcb) compared to base (15f1295).

Patch coverage: 97.50% of modified lines in pull request are covered.
❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28 
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallace
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Needs rebase
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
2 times, most recently
from
6459cb8 to
61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace
reviewed
Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs
Outdated

@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
61c9fcb to
04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz
mentioned this pull request
Jan 26, 2023
 Merged

TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 26, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.
valentinewallace
valentinewallace
previously approved these changes
Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
04d89ce to
5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt
reviewed
Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
	Bounded(NonZeroU64),
	/// One or more items.
	///
	/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item
@TheBlueMattTheBlueMattJan 30, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.
@jkczyzjkczyzJan 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL
@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
5d6469f to
22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt
merged commit ccf9215
into
lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
BOLT 12 spec updates by jkczyz · Pull Request #1972 · lightningdevkit/rust-lightning · GitHub
Skip to content
BOLT 12 spec updates - #1972
Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged
BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Conversation
@jkczyz
@jkczyzjkczyz
commented
Jan 19, 2023

Copy link


Copy Markdown

Contributor
A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:
  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds
This PR updates the offers module to reflect these. Based on #1926.
@codecov-commenter
codecov-commenter
commented
Jan 19, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉
Coverage data is based on head (61c9fcb) compared to base (15f1295).

Patch coverage: 97.50% of modified lines in pull request are covered.
❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28 
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallace
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Needs rebase
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
2 times, most recently
from
6459cb8 to
61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace
reviewed
Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs
Outdated

@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
61c9fcb to
04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz
mentioned this pull request
Jan 26, 2023
 Merged

TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 26, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.
valentinewallace
valentinewallace
previously approved these changes
Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
04d89ce to
5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt
reviewed
Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
	Bounded(NonZeroU64),
	/// One or more items.
	///
	/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item
@TheBlueMattTheBlueMattJan 30, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.
@jkczyzjkczyzJan 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL
@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
5d6469f to
22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt
merged commit ccf9215
into
lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
BOLT 12 spec updates by jkczyz · Pull Request #1972 · lightningdevkit/rust-lightning · GitHub
Skip to content
BOLT 12 spec updates - #1972
Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged
BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Conversation
@jkczyz
@jkczyzjkczyz
commented
Jan 19, 2023

Copy link


Copy Markdown

Contributor
A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:
  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds
This PR updates the offers module to reflect these. Based on #1926.
@codecov-commenter
codecov-commenter
commented
Jan 19, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉
Coverage data is based on head (61c9fcb) compared to base (15f1295).

Patch coverage: 97.50% of modified lines in pull request are covered.
❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28 
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallace
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Needs rebase
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
2 times, most recently
from
6459cb8 to
61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace
reviewed
Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs
Outdated

@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
61c9fcb to
04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz
mentioned this pull request
Jan 26, 2023
 Merged

TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 26, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.
valentinewallace
valentinewallace
previously approved these changes
Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
04d89ce to
5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt
reviewed
Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
	Bounded(NonZeroU64),
	/// One or more items.
	///
	/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item
@TheBlueMattTheBlueMattJan 30, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.
@jkczyzjkczyzJan 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL
@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
5d6469f to
22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt
merged commit ccf9215
into
lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
BOLT 12 spec updates by jkczyz · Pull Request #1972 · lightningdevkit/rust-lightning · GitHub
Skip to content
BOLT 12 spec updates - #1972
Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged
BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Conversation
@jkczyz
@jkczyzjkczyz
commented
Jan 19, 2023

Copy link


Copy Markdown

Contributor
A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:
  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds
This PR updates the offers module to reflect these. Based on #1926.
@codecov-commenter
codecov-commenter
commented
Jan 19, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉
Coverage data is based on head (61c9fcb) compared to base (15f1295).

Patch coverage: 97.50% of modified lines in pull request are covered.
❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28 
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallace
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Needs rebase
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
2 times, most recently
from
6459cb8 to
61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace
reviewed
Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs
Outdated

@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
61c9fcb to
04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz
mentioned this pull request
Jan 26, 2023
 Merged

TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 26, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.
valentinewallace
valentinewallace
previously approved these changes
Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
04d89ce to
5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt
reviewed
Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
	Bounded(NonZeroU64),
	/// One or more items.
	///
	/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item
@TheBlueMattTheBlueMattJan 30, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.
@jkczyzjkczyzJan 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL
@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
5d6469f to
22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt
merged commit ccf9215
into
lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
BOLT 12 spec updates by jkczyz · Pull Request #1972 · lightningdevkit/rust-lightning · GitHub
Skip to content
BOLT 12 spec updates - #1972
Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Jan 30, 2023
Merged
BOLT 12 spec updates#1972
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom 
jkczyz:2023-01-bolt12-spec-updates
Conversation
@jkczyz
@jkczyzjkczyz
commented
Jan 19, 2023

Copy link


Copy Markdown

Contributor
A few changes / clarifications to the BOLT 12 spec (lightning/bolts#798) were made after some recent discussions:
  • allow offer_quantity_max = 1
  • allow invreq_quantity in refunds
  • disallow offer_metadata in refunds
This PR updates the offers module to reflect these. Based on #1926.
@codecov-commenter
codecov-commenter
commented
Jan 19, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.39% // Head: 91.66% // Increases project coverage by +0.27% 🎉
Coverage data is based on head (61c9fcb) compared to base (15f1295).

Patch coverage: 97.50% of modified lines in pull request are covered.
❗ Current head 61c9fcb differs from pull request most recent head 22ea505. Consider uploading reports for the commit 22ea505 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #1972 +/- ##
==========================================
+ Coverage 91.39% 91.66% +0.27% 
==========================================
Files 98 98 Lines 57080 58640 +1560 Branches 57080 58640 +1560 ==========================================
+ Hits 52167 53755 +1588 + Misses 4913 4885 -28 
Impacted FilesCoverage Δ
lightning/src/offers/invoice.rs94.79% <ø> (ø)
lightning/src/offers/parse.rs94.00% <ø> (ø)
lightning/src/offers/offer.rs92.99% <91.66%> (-0.34%)⬇️
lightning/src/offers/invoice_request.rs96.24% <100.00%> (+0.11%)⬆️
lightning/src/offers/refund.rs96.04% <100.00%> (+0.15%)⬆️
lightning/src/chain/onchaintx.rs94.35% <0.00%> (-0.84%)⬇️
lightning/src/ln/inbound_payment.rs92.69% <0.00%> (-0.81%)⬇️
lightning/src/chain/keysinterface.rs86.25% <0.00%> (-0.71%)⬇️
lightning-net-tokio/src/lib.rs85.80% <0.00%> (-0.21%)⬇️
lightning/src/ln/functional_tests.rs96.97% <0.00%> (-0.03%)⬇️
... and 9 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallace
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Needs rebase
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
2 times, most recently
from
6459cb8 to
61c9fcbCompareJanuary 25, 2023 15:57
valentinewallace
valentinewallace
reviewed
Jan 25, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
Comment threadlightning/src/offers/refund.rs
Outdated

@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
61c9fcb to
04d89ceCompareJanuary 26, 2023 04:51
@jkczyzjkczyz
mentioned this pull request
Jan 26, 2023
 Merged

TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 26, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother checking the BOLTs, but code looks good.
valentinewallace
valentinewallace
previously approved these changes
Jan 27, 2023
View reviewed changes
Comment threadlightning/src/offers/invoice_request.rs
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
04d89ce to
5d6469fCompareJanuary 28, 2023 00:42
TheBlueMatt
TheBlueMatt
reviewed
Jan 30, 2023
View reviewed changes
Comment threadlightning/src/offers/offer.rs
	Bounded(NonZeroU64),
	/// One or more items.
	///
	/// May be used with `NonZeroU64::new(1)` but prefer to use [`Quantity::One`] if only one item
@TheBlueMattTheBlueMattJan 30, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this comment on the wrong variant. More generally, I'd expect this to tell me why I should use one or the other, not just that I should.
@jkczyzjkczyzJan 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed and further documented each variant. PTAL
@jkczyz
Support explicit quantity_max = 1 in Offer
4059677
The spec was modified to allow setting offer_quantity_max explicitly to
one. This is to support a use case where more than one item is supported
but only one item is left in the inventory. Introduce a Quantity::One
variant to replace Quantity::Bounded(1) so the later can be used for the
explicit setting.
@jkczyz
Allow quantity in Refund
6236e0d
The spec always allowed this but the reason was unclear. It's useful if
the refund is for an invoice paid for offer where a quantity was given
in the request. The description in the refund would be from the offer,
which may have given a unit for each item. So allowing a quantity makes
it clear how many items the refund is for.
@jkczyz
Disallow offer_metadata in Refund
2d44dbe
The offer_metadata was optional but is redundant with invreq_metadata
(i.e., payer_metadata) for refunds. It is now disallowed in the spec and
was already unsupported by RefundBuilder.
@jkczyz
Update docs regarding payment path privacy
22ea505
@jkczyz
jkczyzforce-pushed
the
2023-01-bolt12-spec-updates
branch
from
5d6469f to
22ea505CompareJanuary 30, 2023 21:44
@TheBlueMatt
TheBlueMatt
merged commit ccf9215
into
lightningdevkit:mainJan 30, 2023
@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt
@valentinewallacevalentinewallace

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz@codecov-commenter@valentinewallace@TheBlueMatt