Skip to content

Remove the lightning-transaction-sync MSRV - #2055

Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged

Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-02-fning-msrv

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.

@TheBlueMattTheBlueMatt mentioned this pull request Feb 27, 2023
Merged
@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter

codecov-commenter commented Feb 27, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️

Coverage data is based on head (64a7567) compared to base (16b3c72).
Patch coverage: 73.88% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jkczyz
jkczyz previously approved these changes Feb 27, 2023
View reviewed changes
wpaulino
wpaulino reviewed Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml Outdated
Comment thread.github/workflows/build.yml
cd lightning && cargo test --verbose --color always --features backtrace
- name: Test on Rust ${{ matrix.toolchain }} with net-tokio
if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
if: "matrix.build-net-tokio && !matrix.coverage"

@wpaulinowpaulinoFeb 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.

@TheBlueMattTheBlueMattFeb 27, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.

@wpaulinowpaulinoFeb 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.

@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed the 2023-02-fning-msrv branch 2 times, most recently from 64a7567 to c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt

TheBlueMatt commented Feb 27, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Fixed the bonus transaction-sync test run:

$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}

@tnull

tnull commented Feb 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixed the bonus transaction-sync test run:

$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}

I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?

@TheBlueMatt

TheBlueMatt commented Feb 27, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.

tnull
tnull reviewed Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt merged commit b5e5435 into lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt mentioned this pull request Feb 27, 2023
Merged
This was referenced Feb 28, 2023
Open
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove the lightning-transaction-sync MSRV by TheBlueMatt · Pull Request #2055 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove the lightning-transaction-sync MSRV - #2055
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged
Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

Collaborator
Apparently it has dependencies that don't track an MSRV at all, so

we can't practically enforce one in CI.
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged

@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter
codecov-commenter
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️
Coverage data is based on head (64a7567) compared to base (16b3c72).

Patch coverage: 73.88% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15 
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
jkczyz
jkczyz
previously approved these changes
Feb 27, 2023
View reviewed changes
wpaulino
wpaulino
reviewed
Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
 cd lightning && cargo test --verbose --color always --features backtrace
 - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
 if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
 if: "matrix.build-net-tokio && !matrix.coverage"
@wpaulinowpaulinoFeb 27, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.
@TheBlueMattTheBlueMattFeb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.
@wpaulinowpaulinoFeb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.
@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-02-fning-msrv
branch
2 times, most recently
from
64a7567 to
c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
@tnull
tnull
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.
tnull
tnull
reviewed
Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt
merged commit b5e5435
into
lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged


This was referenced Feb 28, 2023

Open

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove the lightning-transaction-sync MSRV by TheBlueMatt · Pull Request #2055 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove the lightning-transaction-sync MSRV - #2055
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged
Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

Collaborator
Apparently it has dependencies that don't track an MSRV at all, so

we can't practically enforce one in CI.
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged

@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter
codecov-commenter
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️
Coverage data is based on head (64a7567) compared to base (16b3c72).

Patch coverage: 73.88% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15 
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
jkczyz
jkczyz
previously approved these changes
Feb 27, 2023
View reviewed changes
wpaulino
wpaulino
reviewed
Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
 cd lightning && cargo test --verbose --color always --features backtrace
 - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
 if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
 if: "matrix.build-net-tokio && !matrix.coverage"
@wpaulinowpaulinoFeb 27, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.
@TheBlueMattTheBlueMattFeb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.
@wpaulinowpaulinoFeb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.
@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-02-fning-msrv
branch
2 times, most recently
from
64a7567 to
c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
@tnull
tnull
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.
tnull
tnull
reviewed
Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt
merged commit b5e5435
into
lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged


This was referenced Feb 28, 2023

Open

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove the lightning-transaction-sync MSRV by TheBlueMatt · Pull Request #2055 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove the lightning-transaction-sync MSRV - #2055
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged
Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

Collaborator
Apparently it has dependencies that don't track an MSRV at all, so

we can't practically enforce one in CI.
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged

@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter
codecov-commenter
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️
Coverage data is based on head (64a7567) compared to base (16b3c72).

Patch coverage: 73.88% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15 
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
jkczyz
jkczyz
previously approved these changes
Feb 27, 2023
View reviewed changes
wpaulino
wpaulino
reviewed
Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
 cd lightning && cargo test --verbose --color always --features backtrace
 - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
 if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
 if: "matrix.build-net-tokio && !matrix.coverage"
@wpaulinowpaulinoFeb 27, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.
@TheBlueMattTheBlueMattFeb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.
@wpaulinowpaulinoFeb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.
@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-02-fning-msrv
branch
2 times, most recently
from
64a7567 to
c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
@tnull
tnull
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.
tnull
tnull
reviewed
Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt
merged commit b5e5435
into
lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged


This was referenced Feb 28, 2023

Open

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove the lightning-transaction-sync MSRV by TheBlueMatt · Pull Request #2055 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove the lightning-transaction-sync MSRV - #2055
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged
Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

Collaborator
Apparently it has dependencies that don't track an MSRV at all, so

we can't practically enforce one in CI.
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged

@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter
codecov-commenter
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️
Coverage data is based on head (64a7567) compared to base (16b3c72).

Patch coverage: 73.88% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15 
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
jkczyz
jkczyz
previously approved these changes
Feb 27, 2023
View reviewed changes
wpaulino
wpaulino
reviewed
Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
 cd lightning && cargo test --verbose --color always --features backtrace
 - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
 if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
 if: "matrix.build-net-tokio && !matrix.coverage"
@wpaulinowpaulinoFeb 27, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.
@TheBlueMattTheBlueMattFeb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.
@wpaulinowpaulinoFeb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.
@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-02-fning-msrv
branch
2 times, most recently
from
64a7567 to
c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
@tnull
tnull
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.
tnull
tnull
reviewed
Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt
merged commit b5e5435
into
lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged


This was referenced Feb 28, 2023

Open

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove the lightning-transaction-sync MSRV by TheBlueMatt · Pull Request #2055 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove the lightning-transaction-sync MSRV - #2055
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged
Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

Collaborator
Apparently it has dependencies that don't track an MSRV at all, so

we can't practically enforce one in CI.
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged

@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter
codecov-commenter
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️
Coverage data is based on head (64a7567) compared to base (16b3c72).

Patch coverage: 73.88% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15 
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
jkczyz
jkczyz
previously approved these changes
Feb 27, 2023
View reviewed changes
wpaulino
wpaulino
reviewed
Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
 cd lightning && cargo test --verbose --color always --features backtrace
 - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
 if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
 if: "matrix.build-net-tokio && !matrix.coverage"
@wpaulinowpaulinoFeb 27, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.
@TheBlueMattTheBlueMattFeb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.
@wpaulinowpaulinoFeb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.
@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-02-fning-msrv
branch
2 times, most recently
from
64a7567 to
c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
@tnull
tnull
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.
tnull
tnull
reviewed
Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt
merged commit b5e5435
into
lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged


This was referenced Feb 28, 2023

Open

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove the lightning-transaction-sync MSRV by TheBlueMatt · Pull Request #2055 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove the lightning-transaction-sync MSRV - #2055
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged
Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

Collaborator
Apparently it has dependencies that don't track an MSRV at all, so

we can't practically enforce one in CI.
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged

@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter
codecov-commenter
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️
Coverage data is based on head (64a7567) compared to base (16b3c72).

Patch coverage: 73.88% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15 
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
jkczyz
jkczyz
previously approved these changes
Feb 27, 2023
View reviewed changes
wpaulino
wpaulino
reviewed
Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
 cd lightning && cargo test --verbose --color always --features backtrace
 - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
 if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
 if: "matrix.build-net-tokio && !matrix.coverage"
@wpaulinowpaulinoFeb 27, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.
@TheBlueMattTheBlueMattFeb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.
@wpaulinowpaulinoFeb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.
@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-02-fning-msrv
branch
2 times, most recently
from
64a7567 to
c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
@tnull
tnull
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.
tnull
tnull
reviewed
Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt
merged commit b5e5435
into
lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged


This was referenced Feb 28, 2023

Open

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove the lightning-transaction-sync MSRV by TheBlueMatt · Pull Request #2055 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove the lightning-transaction-sync MSRV - #2055
Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Feb 27, 2023
Merged
Remove the lightning-transaction-sync MSRV#2055
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-fning-msrv
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

Collaborator
Apparently it has dependencies that don't track an MSRV at all, so

we can't practically enforce one in CI.
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged

@TheBlueMatt
Fix silent rebase conflict in previous PR
bb0f696
@TheBlueMatt
Remove the lightning-transaction-sync MSRV
0fc5a3a
Apparently it has dependencies that don't track an MSRV at all, so
we can't practically enforce one in CI.
@codecov-commenter
codecov-commenter
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 87.26% // Head: 87.25% // Decreases project coverage by -0.02%⚠️
Coverage data is based on head (64a7567) compared to base (16b3c72).

Patch coverage: 73.88% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2055 +/- ##
==========================================
- Coverage 87.26% 87.25% -0.02% 
==========================================
Files 101 100 -1 Lines 44414 44480 +66 Branches 44414 44480 +66 ==========================================
+ Hits 38759 38810 +51 - Misses 5655 5670 +15 
Impacted FilesCoverage Δ
lightning/src/ln/channelmanager.rs86.54% <0.00%> (+<0.01%)⬆️
lightning/src/ln/onion_utils.rs86.70% <ø> (ø)
lightning/src/routing/gossip.rs83.83% <ø> (-0.16%)⬇️
lightning/src/util/errors.rs32.35% <0.00%> (+0.21%)⬆️
lightning/src/util/events.rs25.50% <28.57%> (-0.43%)⬇️
lightning/src/util/ser.rs84.27% <33.33%> (-0.46%)⬇️
lightning-background-processor/src/lib.rs81.88% <75.00%> (+0.20%)⬆️
lightning/src/util/ser_macros.rs91.59% <75.00%> (-1.10%)⬇️
lightning/src/ln/outbound_payment.rs80.23% <90.74%> (+1.17%)⬆️
lightning/src/chain/channelmonitor.rs89.63% <100.00%> (+0.04%)⬆️
... and 14 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
jkczyz
jkczyz
previously approved these changes
Feb 27, 2023
View reviewed changes
wpaulino
wpaulino
reviewed
Feb 27, 2023
View reviewed changes
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
 cd lightning && cargo test --verbose --color always --features backtrace
 - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
 if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
 if: "matrix.build-net-tokio && !matrix.coverage"
@wpaulinowpaulinoFeb 27, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 137, can we assume that if matrix.coverage is not set then it is false? If so, we already have a build covering that in line 125.
@TheBlueMattTheBlueMattFeb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking? We have two builds, one for coverage and one for not-coverage, the coverage one sets link-dead-code.
@wpaulinowpaulinoFeb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, and on line 136, there's another build for lightning-transaction-sync where the condition doesn't check for matrix.coverage at all. Just wondering if there's a difference here, because if there isn't, then that build could be removed.
@TheBlueMatt
Move lightning-transaction-sync out of the main workspace
64a7567
Because `lightning-transaction-sync` does not have an MSRV (and
because its dev-dependencies are huge), we can't build it by
default when devs run `cargo test`, so it is moved out of the
top-level workspace.
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-02-fning-msrv
branch
2 times, most recently
from
64a7567 to
c4f2e48CompareFebruary 27, 2023 21:06
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
@tnull
tnull
commented
Feb 27, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixed the bonus transaction-sync test run:
$ git diff-tree -U1 64a75679 c4f2e487
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9fb37f1b4..cebaa9a46 100644
--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -135,8 +135,2 @@ jobs:
RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always --features esplora-async
- - name: Test transaction sync clients on Rust ${{ matrix.toolchain }} with features- if: "matrix.build-tx-sync"- run: |- cd lightning-transaction-sync- cargo test --verbose --color always --features esplora-blocking- cargo test --verbose --color always --features esplora-async
- name: Test backtrace-debug builds on Rust ${{ matrix.toolchain }}
I'm confused: why are these 'bonus' again? We now only have cases where the tx-sync crate is built, but none that run the tests?
@TheBlueMatt
TheBlueMatt
commented
Feb 27, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Grrrr, apparently @wpaulino and I both can't read - I missed that it was separate between test/build.
tnull
tnull
reviewed
Feb 27, 2023
View reviewed changes
Comment threadCargo.toml
@TheBlueMatt
TheBlueMatt
merged commit b5e5435
into
lightningdevkit:mainFeb 27, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
Feb 27, 2023
 Merged


This was referenced Feb 28, 2023

Open

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@jkczyzjkczyzjkczyz approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@TheBlueMatt@codecov-commenter@tnull@jkczyz@wpaulino