Skip to content

Cut 0.0.114 - #2065

Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged

Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-02-0.0.114

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.

@TheBlueMattTheBlueMatt added this to the 0.0.114 milestone Mar 2, 2023
@codecov-commenter

codecov-commenter commented Mar 2, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

benthecarman
benthecarman reviewed Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
ariard
ariard reviewed Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md Outdated
* `lightning-background-processor` `std` is now optional in async mode (#1962).
* `create_phantom_invoice` can now be used in `no-std` (#1985).
* The required final CLTV delta on inbound payments is now configurable (#1878)
* `historical_estimated_channel_liquidity_probabilities` was added (#1961)

@ariardariardMar 3, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.

@TheBlueMattTheBlueMattMar 3, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"

Comment threadCHANGELOG.md

## Performance Improvements
* Channel data is now stored per-peer and channel updates across multiple
peers can be operated on simultaneously (#1507).

@ariardariardMar 3, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?

@TheBlueMattTheBlueMattMar 3, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?

Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
* The number of pending un-funded channels as well as peer without funded
channels is now limited to avoid denial of service (#1988).

@ariardariardMar 3, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.

@TheBlueMattTheBlueMattMar 3, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.

valentinewallace
valentinewallace reviewed Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
valentinewallace
valentinewallace reviewed Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt

TheBlueMatt commented Mar 3, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Added notes for things we've merged since 114-beta.

wpaulino
wpaulino reviewed Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino reviewed Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace reviewed Mar 3, 2023
View reviewed changes

@valentinewallacevalentinewallace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go

Comment threadCHANGELOG.md Outdated
valentinewallace
valentinewallace reviewed Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
@valentinewallace

valentinewallace commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

LGTM after squash

@TheBlueMatt

TheBlueMatt commented Mar 3, 2023•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.

wpaulino
wpaulino reviewed Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt

TheBlueMatt commented Mar 4, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Landed all the dependent PRs, rebased, squashed. Should be good to go.

Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073

@TheBlueMatt
TheBlueMatt merged commit af76fac into lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes
+1 more reviewer
@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Cut 0.0.114 by TheBlueMatt · Pull Request #2065 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.114 - #2065
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged
Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Mar 2, 2023

Copy link


Copy Markdown

Collaborator
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.
@TheBlueMattTheBlueMatt
added this to the 0.0.114 milestone
Mar 2, 2023
@codecov-commenter
codecov-commenter
commented
Mar 2, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch and project coverage have no change.
Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1 
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
benthecarman
benthecarman
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

ariard
ariard
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

 * `lightning-background-processor` `std` is now optional in async mode (#1962).
 * `create_phantom_invoice` can now be used in `no-std` (#1985).
 * The required final CLTV delta on inbound payments is now configurable (#1878)
 * `historical_estimated_channel_liquidity_probabilities` was added (#1961)
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"
Comment threadCHANGELOG.md

## Performance Improvements
 * Channel data is now stored per-peer and channel updates across multiple
 peers can be operated on simultaneously (#1507).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?
Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
 * The number of pending un-funded channels as well as peer without funded
 channels is now limited to avoid denial of service (#1988).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Added notes for things we've merged since 114-beta.
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

@valentinewallace
valentinewallace
commented
Mar 3, 2023

Copy link


Copy Markdown

Contributor
LGTM after squash
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.
wpaulino
wpaulino
reviewed
Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt
TheBlueMatt
commented
Mar 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Landed all the dependent PRs, rebased, squashed. Should be good to go.
Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073
@TheBlueMatt
TheBlueMatt
merged commit af76fac
into
lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Cut 0.0.114 by TheBlueMatt · Pull Request #2065 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.114 - #2065
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged
Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Mar 2, 2023

Copy link


Copy Markdown

Collaborator
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.
@TheBlueMattTheBlueMatt
added this to the 0.0.114 milestone
Mar 2, 2023
@codecov-commenter
codecov-commenter
commented
Mar 2, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch and project coverage have no change.
Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1 
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
benthecarman
benthecarman
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

ariard
ariard
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

 * `lightning-background-processor` `std` is now optional in async mode (#1962).
 * `create_phantom_invoice` can now be used in `no-std` (#1985).
 * The required final CLTV delta on inbound payments is now configurable (#1878)
 * `historical_estimated_channel_liquidity_probabilities` was added (#1961)
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"
Comment threadCHANGELOG.md

## Performance Improvements
 * Channel data is now stored per-peer and channel updates across multiple
 peers can be operated on simultaneously (#1507).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?
Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
 * The number of pending un-funded channels as well as peer without funded
 channels is now limited to avoid denial of service (#1988).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Added notes for things we've merged since 114-beta.
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

@valentinewallace
valentinewallace
commented
Mar 3, 2023

Copy link


Copy Markdown

Contributor
LGTM after squash
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.
wpaulino
wpaulino
reviewed
Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt
TheBlueMatt
commented
Mar 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Landed all the dependent PRs, rebased, squashed. Should be good to go.
Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073
@TheBlueMatt
TheBlueMatt
merged commit af76fac
into
lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Cut 0.0.114 by TheBlueMatt · Pull Request #2065 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.114 - #2065
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged
Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Mar 2, 2023

Copy link


Copy Markdown

Collaborator
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.
@TheBlueMattTheBlueMatt
added this to the 0.0.114 milestone
Mar 2, 2023
@codecov-commenter
codecov-commenter
commented
Mar 2, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch and project coverage have no change.
Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1 
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
benthecarman
benthecarman
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

ariard
ariard
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

 * `lightning-background-processor` `std` is now optional in async mode (#1962).
 * `create_phantom_invoice` can now be used in `no-std` (#1985).
 * The required final CLTV delta on inbound payments is now configurable (#1878)
 * `historical_estimated_channel_liquidity_probabilities` was added (#1961)
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"
Comment threadCHANGELOG.md

## Performance Improvements
 * Channel data is now stored per-peer and channel updates across multiple
 peers can be operated on simultaneously (#1507).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?
Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
 * The number of pending un-funded channels as well as peer without funded
 channels is now limited to avoid denial of service (#1988).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Added notes for things we've merged since 114-beta.
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

@valentinewallace
valentinewallace
commented
Mar 3, 2023

Copy link


Copy Markdown

Contributor
LGTM after squash
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.
wpaulino
wpaulino
reviewed
Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt
TheBlueMatt
commented
Mar 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Landed all the dependent PRs, rebased, squashed. Should be good to go.
Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073
@TheBlueMatt
TheBlueMatt
merged commit af76fac
into
lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Cut 0.0.114 by TheBlueMatt · Pull Request #2065 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.114 - #2065
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged
Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Mar 2, 2023

Copy link


Copy Markdown

Collaborator
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.
@TheBlueMattTheBlueMatt
added this to the 0.0.114 milestone
Mar 2, 2023
@codecov-commenter
codecov-commenter
commented
Mar 2, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch and project coverage have no change.
Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1 
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
benthecarman
benthecarman
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

ariard
ariard
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

 * `lightning-background-processor` `std` is now optional in async mode (#1962).
 * `create_phantom_invoice` can now be used in `no-std` (#1985).
 * The required final CLTV delta on inbound payments is now configurable (#1878)
 * `historical_estimated_channel_liquidity_probabilities` was added (#1961)
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"
Comment threadCHANGELOG.md

## Performance Improvements
 * Channel data is now stored per-peer and channel updates across multiple
 peers can be operated on simultaneously (#1507).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?
Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
 * The number of pending un-funded channels as well as peer without funded
 channels is now limited to avoid denial of service (#1988).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Added notes for things we've merged since 114-beta.
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

@valentinewallace
valentinewallace
commented
Mar 3, 2023

Copy link


Copy Markdown

Contributor
LGTM after squash
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.
wpaulino
wpaulino
reviewed
Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt
TheBlueMatt
commented
Mar 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Landed all the dependent PRs, rebased, squashed. Should be good to go.
Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073
@TheBlueMatt
TheBlueMatt
merged commit af76fac
into
lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Cut 0.0.114 by TheBlueMatt · Pull Request #2065 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.114 - #2065
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged
Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Mar 2, 2023

Copy link


Copy Markdown

Collaborator
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.
@TheBlueMattTheBlueMatt
added this to the 0.0.114 milestone
Mar 2, 2023
@codecov-commenter
codecov-commenter
commented
Mar 2, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch and project coverage have no change.
Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1 
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
benthecarman
benthecarman
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

ariard
ariard
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

 * `lightning-background-processor` `std` is now optional in async mode (#1962).
 * `create_phantom_invoice` can now be used in `no-std` (#1985).
 * The required final CLTV delta on inbound payments is now configurable (#1878)
 * `historical_estimated_channel_liquidity_probabilities` was added (#1961)
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"
Comment threadCHANGELOG.md

## Performance Improvements
 * Channel data is now stored per-peer and channel updates across multiple
 peers can be operated on simultaneously (#1507).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?
Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
 * The number of pending un-funded channels as well as peer without funded
 channels is now limited to avoid denial of service (#1988).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Added notes for things we've merged since 114-beta.
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

@valentinewallace
valentinewallace
commented
Mar 3, 2023

Copy link


Copy Markdown

Contributor
LGTM after squash
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.
wpaulino
wpaulino
reviewed
Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt
TheBlueMatt
commented
Mar 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Landed all the dependent PRs, rebased, squashed. Should be good to go.
Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073
@TheBlueMatt
TheBlueMatt
merged commit af76fac
into
lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Cut 0.0.114 by TheBlueMatt · Pull Request #2065 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.114 - #2065
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged
Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Mar 2, 2023

Copy link


Copy Markdown

Collaborator
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.
@TheBlueMattTheBlueMatt
added this to the 0.0.114 milestone
Mar 2, 2023
@codecov-commenter
codecov-commenter
commented
Mar 2, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch and project coverage have no change.
Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1 
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
benthecarman
benthecarman
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

ariard
ariard
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

 * `lightning-background-processor` `std` is now optional in async mode (#1962).
 * `create_phantom_invoice` can now be used in `no-std` (#1985).
 * The required final CLTV delta on inbound payments is now configurable (#1878)
 * `historical_estimated_channel_liquidity_probabilities` was added (#1961)
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"
Comment threadCHANGELOG.md

## Performance Improvements
 * Channel data is now stored per-peer and channel updates across multiple
 peers can be operated on simultaneously (#1507).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?
Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
 * The number of pending un-funded channels as well as peer without funded
 channels is now limited to avoid denial of service (#1988).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Added notes for things we've merged since 114-beta.
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

@valentinewallace
valentinewallace
commented
Mar 3, 2023

Copy link


Copy Markdown

Contributor
LGTM after squash
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.
wpaulino
wpaulino
reviewed
Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt
TheBlueMatt
commented
Mar 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Landed all the dependent PRs, rebased, squashed. Should be good to go.
Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073
@TheBlueMatt
TheBlueMatt
merged commit af76fac
into
lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Cut 0.0.114 by TheBlueMatt · Pull Request #2065 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.114 - #2065
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Mar 4, 2023
Merged
Cut 0.0.114#2065
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-02-0.0.114
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Mar 2, 2023

Copy link


Copy Markdown

Collaborator
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.
@TheBlueMattTheBlueMatt
added this to the 0.0.114 milestone
Mar 2, 2023
@codecov-commenter
codecov-commenter
commented
Mar 2, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch and project coverage have no change.
Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18% =======================================
Files 100 100 Lines 44727 44743 +16 Branches 44727 44743 +16 =======================================
+ Hits 38993 39010 +17 + Misses 5734 5733 -1 
Impacted FilesCoverage Δ
lightning/src/util/time.rs38.29% <0.00%> (-4.56%)⬇️
lightning/src/ln/features.rs92.55% <0.00%> (-0.33%)⬇️
lightning/src/ln/functional_tests.rs97.21% <0.00%> (ø)
lightning/src/ln/channel.rs84.02% <0.00%> (+0.01%)⬆️
lightning/src/ln/priv_short_conf_tests.rs95.73% <0.00%> (+0.02%)⬆️
lightning/src/routing/scoring.rs91.85% <0.00%> (+0.09%)⬆️
lightning/src/ln/peer_handler.rs60.86% <0.00%> (+0.16%)⬆️
lightning/src/ln/outbound_payment.rs80.77% <0.00%> (+0.16%)⬆️
lightning/src/chain/onchaintx.rs86.46% <0.00%> (+0.68%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
benthecarman
benthecarman
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

ariard
ariard
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

 * `lightning-background-processor` `std` is now optional in async mode (#1962).
 * `create_phantom_invoice` can now be used in `no-std` (#1985).
 * The required final CLTV delta on inbound payments is now configurable (#1878)
 * `historical_estimated_channel_liquidity_probabilities` was added (#1961)
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"
Comment threadCHANGELOG.md

## Performance Improvements
 * Channel data is now stored per-peer and channel updates across multiple
 peers can be operated on simultaneously (#1507).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?
Comment threadCHANGELOG.md
0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
 * The number of pending un-funded channels as well as peer without funded
 channels is now limited to avoid denial of service (#1988).
@ariardariardMar 3, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.
@TheBlueMattTheBlueMattMar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Added notes for things we've merged since 114-beta.
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md
wpaulino
wpaulino
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
@valentinewallacevalentinewallace
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go
Comment threadCHANGELOG.md
Outdated

valentinewallace
valentinewallace
reviewed
Mar 3, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

@valentinewallace
valentinewallace
commented
Mar 3, 2023

Copy link


Copy Markdown

Contributor
LGTM after squash
@TheBlueMatt
TheBlueMatt
commented
Mar 3, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.
wpaulino
wpaulino
reviewed
Mar 4, 2023
View reviewed changes
Comment threadlightning-transaction-sync/Cargo.toml
@TheBlueMatt
TheBlueMatt
commented
Mar 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Landed all the dependent PRs, rebased, squashed. Should be good to go.
Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073
@TheBlueMatt
TheBlueMatt
merged commit af76fac
into
lightningdevkit:mainMar 4, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

+1 more reviewer

@ariardariardariard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.114

Development

Successfully merging this pull request may close these issues.

6 participants

@TheBlueMatt@codecov-commenter@valentinewallace@wpaulino@benthecarman@ariard