Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Apr 25, 2023
Merged

Cut 0.0.115 #2211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb42400
Bump crate versions to 0.0.115/invoice 0.23
TheBlueMatt Apr 21, 2023
dafa095
Add 0.0.115 CHANGELOG entries
TheBlueMatt Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 97 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
* The MSRV of the main LDK crates has been increased to 1.48 (#2107).
* Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
`PaymentClaimable::claim_deadline` (#2148).
* `payment_metadata` is now supported in `Invoice` deserialization, sending,
and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
* `Event::PaymentFailed` now exposes a failure reason (#2142).
* BOLT12 messages now support stateless generation and validation (#1989).
* The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
* Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
* `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
* A `ChannelPending` event is now emitted after the initial handshake (#2098).
* `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
* `ChannelManager::list_channels_by_counterparty` was added (#2079).
* `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
* `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
* The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.
## Backwards Compatibility
* Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
* `Event::PaymentPathFailed::retry` was removed and will always be `None` for
payments initiated on 0.0.115 which fail on an earlier version (#2063).
* `Route`s and `PaymentParameters` with blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (#2146).
* Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
`ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
in general unsupported, and included here only for completeness.

## Bug Fixes

@valentinewallacevalentinewallaceApr 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145

@TheBlueMattTheBlueMattApr 24, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.

* Fixed a case where `process_events_async` may `poll` a `Future` which has
already completed (#2081).
* Fixed deserialization of `u16` arrays. This bug may have previously corrupted
the historical buckets in a `ProbabilisticScorer`. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (#2191).
* The `process_events_async` task is now `Send` and can thus be polled on a
multi-threaded runtime (#2199).
* Fixed a missing macro export causing
`impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
* Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
* Fix an issue where the `background-processor` would not wake when a
`ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
* Fix an issue where `process_events_async` would exit immediately (#2145).
* `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
than `find_route`, as was intended and described in the API (#2092).
* Ensure `process_events_async` always exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (#2145).
* `channel_update` messages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (#2198).
* We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (#2220).
* Fixed a debug assertion which may panic under heavy load (#2172).
* `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
* Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
* Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the

@ariardariardApr 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?

Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.

@TheBlueMattTheBlueMattApr 24, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.

`background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
This should substantially increase transaction confirmation reliability
without relying on downstream `TransactionBroadcaster` implementations for
rebroadcasting (#2203, #2205, #2208).
* Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
* Advait
* Alan Cohen
* Alec Chen
* Allan Douglas R. de Oliveira
* Arik Sosman
* Elias Rohrer
* Evan Feenstra
* Jeffrey Czyz
* John Cantrell
* Lucas Soriano del Pino
* Marc Tyndel
* Matt Corallo
* Paul Miller
* Steven
* Steven Williamson
* Steven Zhao
* Tony Giorgio
* Valentine Wallace
* Wilmer Paulino
* benthecarman
* munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down
12 changes: 6 additions & 6 deletions lightning-background-processor/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }
6 changes: 3 additions & 3 deletions lightning-block-sync/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }
4 changes: 2 additions & 2 deletions lightning-custom-message/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
6 changes: 3 additions & 3 deletions lightning-invoice/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}
6 changes: 3 additions & 3 deletions lightning-net-tokio/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
6 changes: 3 additions & 3 deletions lightning-persister/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
6 changes: 3 additions & 3 deletions lightning-rapid-gossip-sync/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
6 changes: 3 additions & 3 deletions lightning-transaction-sync/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }
2 changes: 1 addition & 1 deletion lightning/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down
4 changes: 0 additions & 4 deletions pending_changelog/2059.txt
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions pending_changelog/2063.txt
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions pending_changelog/2146.txt
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions pending_changelog/matt-rm-retryable-secret.txt
View file
Open in desktop

This file was deleted.

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Apr 25, 2023
 Merged


Cut 0.0.115
#2211
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fb42400

Bump crate versions to 0.0.115/invoice 0.23


TheBlueMatt Apr 21, 2023
dafa095

Add 0.0.115 CHANGELOG entries


TheBlueMatt Apr 21, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


97 changes: 97 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
 * The MSRV of the main LDK crates has been increased to 1.48 (#2107).
 * Attempting to claim an un-expired payment on a channel which has closed no
 longer fails. The expiry time of payments is exposed via
 `PaymentClaimable::claim_deadline` (#2148).
 * `payment_metadata` is now supported in `Invoice` deserialization, sending,
 and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
 * `Event::PaymentFailed` now exposes a failure reason (#2142).
 * BOLT12 messages now support stateless generation and validation (#1989).
 * The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
 * Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
 * `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
 * A `ChannelPending` event is now emitted after the initial handshake (#2098).
 * `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
 * `ChannelManager::list_channels_by_counterparty` was added (#2079).
 * `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
 * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
 * The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.

## Backwards Compatibility
 * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
 longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
 * `Event::PaymentPathFailed::retry` was removed and will always be `None` for
 payments initiated on 0.0.115 which fail on an earlier version (#2063).
 * `Route`s and `PaymentParameters` with blinded path information will not be
 readable on prior versions of LDK. Such objects are not currently constructed
 by LDK, but may be when processing BOLT12 data in a coming release (#2146).
 * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
 `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
 in general unsupported, and included here only for completeness.

## Bug Fixes
@valentinewallacevalentinewallaceApr 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.
 * Fixed a case where `process_events_async` may `poll` a `Future` which has
 already completed (#2081).
 * Fixed deserialization of `u16` arrays. This bug may have previously corrupted
 the historical buckets in a `ProbabilisticScorer`. Users relying on the
 historical buckets may wish to wipe their scorer on upgrade to remove corrupt
 data rather than waiting on it to decay (#2191).
 * The `process_events_async` task is now `Send` and can thus be polled on a
 multi-threaded runtime (#2199).
 * Fixed a missing macro export causing
 `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
 * Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
 * Fix an issue where the `background-processor` would not wake when a
 `ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
 * Fix an issue where `process_events_async` would exit immediately (#2145).
 * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
 than `find_route`, as was intended and described in the API (#2092).
 * Ensure `process_events_async` always exits if any sleep future returns true,
 not just if all sleep futures repeatedly return true (#2145).
 * `channel_update` messages no longer set the disable bit unless the peer has
 been disconnected for some time. This should resolve cases where channels are
 disabled for extended periods of time (#2198).
 * We no longer remove CLN nodes from the network graph for violating the BOLT
 spec in some cases after failing to pay through them (#2220).
 * Fixed a debug assertion which may panic under heavy load (#2172).
 * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
 * Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
 * Transaction re-broadcasting is now substantially more aggressive, including a
 new regular rebroadcast feature called on a timer from the
@ariardariardApr 23, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.
 `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
 This should substantially increase transaction confirmation reliability
 without relying on downstream `TransactionBroadcaster` implementations for
 rebroadcasting (#2203, #2205, #2208).
 * Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
 privacy vulnerability which allows an intermediate node on the path to
 discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
 * Advait
 * Alan Cohen
 * Alec Chen
 * Allan Douglas R. de Oliveira
 * Arik Sosman
 * Elias Rohrer
 * Evan Feenstra
 * Jeffrey Czyz
 * John Cantrell
 * Lucas Soriano del Pino
 * Marc Tyndel
 * Matt Corallo
 * Paul Miller
 * Steven
 * Steven Williamson
 * Steven Zhao
 * Tony Giorgio
 * Valentine Wallace
 * Wilmer Paulino
 * benthecarman
 * munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down

12 changes: 6 additions & 6 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }

6 changes: 3 additions & 3 deletions
lightning-block-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }

4 changes: 2 additions & 2 deletions
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }

6 changes: 3 additions & 3 deletions
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}

6 changes: 3 additions & 3 deletions
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

4 changes: 0 additions & 4 deletions
pending_changelog/2059.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2063.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2146.txt

View file


Open in desktop


This file was deleted.


3 changes: 0 additions & 3 deletions
pending_changelog/matt-rm-retryable-secret.txt

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Apr 25, 2023
 Merged


Cut 0.0.115
#2211
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fb42400

Bump crate versions to 0.0.115/invoice 0.23


TheBlueMatt Apr 21, 2023
dafa095

Add 0.0.115 CHANGELOG entries


TheBlueMatt Apr 21, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


97 changes: 97 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
 * The MSRV of the main LDK crates has been increased to 1.48 (#2107).
 * Attempting to claim an un-expired payment on a channel which has closed no
 longer fails. The expiry time of payments is exposed via
 `PaymentClaimable::claim_deadline` (#2148).
 * `payment_metadata` is now supported in `Invoice` deserialization, sending,
 and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
 * `Event::PaymentFailed` now exposes a failure reason (#2142).
 * BOLT12 messages now support stateless generation and validation (#1989).
 * The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
 * Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
 * `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
 * A `ChannelPending` event is now emitted after the initial handshake (#2098).
 * `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
 * `ChannelManager::list_channels_by_counterparty` was added (#2079).
 * `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
 * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
 * The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.

## Backwards Compatibility
 * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
 longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
 * `Event::PaymentPathFailed::retry` was removed and will always be `None` for
 payments initiated on 0.0.115 which fail on an earlier version (#2063).
 * `Route`s and `PaymentParameters` with blinded path information will not be
 readable on prior versions of LDK. Such objects are not currently constructed
 by LDK, but may be when processing BOLT12 data in a coming release (#2146).
 * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
 `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
 in general unsupported, and included here only for completeness.

## Bug Fixes
@valentinewallacevalentinewallaceApr 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.
 * Fixed a case where `process_events_async` may `poll` a `Future` which has
 already completed (#2081).
 * Fixed deserialization of `u16` arrays. This bug may have previously corrupted
 the historical buckets in a `ProbabilisticScorer`. Users relying on the
 historical buckets may wish to wipe their scorer on upgrade to remove corrupt
 data rather than waiting on it to decay (#2191).
 * The `process_events_async` task is now `Send` and can thus be polled on a
 multi-threaded runtime (#2199).
 * Fixed a missing macro export causing
 `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
 * Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
 * Fix an issue where the `background-processor` would not wake when a
 `ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
 * Fix an issue where `process_events_async` would exit immediately (#2145).
 * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
 than `find_route`, as was intended and described in the API (#2092).
 * Ensure `process_events_async` always exits if any sleep future returns true,
 not just if all sleep futures repeatedly return true (#2145).
 * `channel_update` messages no longer set the disable bit unless the peer has
 been disconnected for some time. This should resolve cases where channels are
 disabled for extended periods of time (#2198).
 * We no longer remove CLN nodes from the network graph for violating the BOLT
 spec in some cases after failing to pay through them (#2220).
 * Fixed a debug assertion which may panic under heavy load (#2172).
 * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
 * Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
 * Transaction re-broadcasting is now substantially more aggressive, including a
 new regular rebroadcast feature called on a timer from the
@ariardariardApr 23, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.
 `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
 This should substantially increase transaction confirmation reliability
 without relying on downstream `TransactionBroadcaster` implementations for
 rebroadcasting (#2203, #2205, #2208).
 * Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
 privacy vulnerability which allows an intermediate node on the path to
 discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
 * Advait
 * Alan Cohen
 * Alec Chen
 * Allan Douglas R. de Oliveira
 * Arik Sosman
 * Elias Rohrer
 * Evan Feenstra
 * Jeffrey Czyz
 * John Cantrell
 * Lucas Soriano del Pino
 * Marc Tyndel
 * Matt Corallo
 * Paul Miller
 * Steven
 * Steven Williamson
 * Steven Zhao
 * Tony Giorgio
 * Valentine Wallace
 * Wilmer Paulino
 * benthecarman
 * munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down

12 changes: 6 additions & 6 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }

6 changes: 3 additions & 3 deletions
lightning-block-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }

4 changes: 2 additions & 2 deletions
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }

6 changes: 3 additions & 3 deletions
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}

6 changes: 3 additions & 3 deletions
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

4 changes: 0 additions & 4 deletions
pending_changelog/2059.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2063.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2146.txt

View file


Open in desktop


This file was deleted.


3 changes: 0 additions & 3 deletions
pending_changelog/matt-rm-retryable-secret.txt

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Apr 25, 2023
 Merged


Cut 0.0.115
#2211
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fb42400

Bump crate versions to 0.0.115/invoice 0.23


TheBlueMatt Apr 21, 2023
dafa095

Add 0.0.115 CHANGELOG entries


TheBlueMatt Apr 21, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


97 changes: 97 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
 * The MSRV of the main LDK crates has been increased to 1.48 (#2107).
 * Attempting to claim an un-expired payment on a channel which has closed no
 longer fails. The expiry time of payments is exposed via
 `PaymentClaimable::claim_deadline` (#2148).
 * `payment_metadata` is now supported in `Invoice` deserialization, sending,
 and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
 * `Event::PaymentFailed` now exposes a failure reason (#2142).
 * BOLT12 messages now support stateless generation and validation (#1989).
 * The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
 * Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
 * `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
 * A `ChannelPending` event is now emitted after the initial handshake (#2098).
 * `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
 * `ChannelManager::list_channels_by_counterparty` was added (#2079).
 * `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
 * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
 * The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.

## Backwards Compatibility
 * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
 longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
 * `Event::PaymentPathFailed::retry` was removed and will always be `None` for
 payments initiated on 0.0.115 which fail on an earlier version (#2063).
 * `Route`s and `PaymentParameters` with blinded path information will not be
 readable on prior versions of LDK. Such objects are not currently constructed
 by LDK, but may be when processing BOLT12 data in a coming release (#2146).
 * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
 `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
 in general unsupported, and included here only for completeness.

## Bug Fixes
@valentinewallacevalentinewallaceApr 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.
 * Fixed a case where `process_events_async` may `poll` a `Future` which has
 already completed (#2081).
 * Fixed deserialization of `u16` arrays. This bug may have previously corrupted
 the historical buckets in a `ProbabilisticScorer`. Users relying on the
 historical buckets may wish to wipe their scorer on upgrade to remove corrupt
 data rather than waiting on it to decay (#2191).
 * The `process_events_async` task is now `Send` and can thus be polled on a
 multi-threaded runtime (#2199).
 * Fixed a missing macro export causing
 `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
 * Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
 * Fix an issue where the `background-processor` would not wake when a
 `ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
 * Fix an issue where `process_events_async` would exit immediately (#2145).
 * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
 than `find_route`, as was intended and described in the API (#2092).
 * Ensure `process_events_async` always exits if any sleep future returns true,
 not just if all sleep futures repeatedly return true (#2145).
 * `channel_update` messages no longer set the disable bit unless the peer has
 been disconnected for some time. This should resolve cases where channels are
 disabled for extended periods of time (#2198).
 * We no longer remove CLN nodes from the network graph for violating the BOLT
 spec in some cases after failing to pay through them (#2220).
 * Fixed a debug assertion which may panic under heavy load (#2172).
 * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
 * Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
 * Transaction re-broadcasting is now substantially more aggressive, including a
 new regular rebroadcast feature called on a timer from the
@ariardariardApr 23, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.
 `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
 This should substantially increase transaction confirmation reliability
 without relying on downstream `TransactionBroadcaster` implementations for
 rebroadcasting (#2203, #2205, #2208).
 * Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
 privacy vulnerability which allows an intermediate node on the path to
 discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
 * Advait
 * Alan Cohen
 * Alec Chen
 * Allan Douglas R. de Oliveira
 * Arik Sosman
 * Elias Rohrer
 * Evan Feenstra
 * Jeffrey Czyz
 * John Cantrell
 * Lucas Soriano del Pino
 * Marc Tyndel
 * Matt Corallo
 * Paul Miller
 * Steven
 * Steven Williamson
 * Steven Zhao
 * Tony Giorgio
 * Valentine Wallace
 * Wilmer Paulino
 * benthecarman
 * munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down

12 changes: 6 additions & 6 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }

6 changes: 3 additions & 3 deletions
lightning-block-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }

4 changes: 2 additions & 2 deletions
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }

6 changes: 3 additions & 3 deletions
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}

6 changes: 3 additions & 3 deletions
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

4 changes: 0 additions & 4 deletions
pending_changelog/2059.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2063.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2146.txt

View file


Open in desktop


This file was deleted.


3 changes: 0 additions & 3 deletions
pending_changelog/matt-rm-retryable-secret.txt

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Apr 25, 2023
 Merged


Cut 0.0.115
#2211
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fb42400

Bump crate versions to 0.0.115/invoice 0.23


TheBlueMatt Apr 21, 2023
dafa095

Add 0.0.115 CHANGELOG entries


TheBlueMatt Apr 21, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


97 changes: 97 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
 * The MSRV of the main LDK crates has been increased to 1.48 (#2107).
 * Attempting to claim an un-expired payment on a channel which has closed no
 longer fails. The expiry time of payments is exposed via
 `PaymentClaimable::claim_deadline` (#2148).
 * `payment_metadata` is now supported in `Invoice` deserialization, sending,
 and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
 * `Event::PaymentFailed` now exposes a failure reason (#2142).
 * BOLT12 messages now support stateless generation and validation (#1989).
 * The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
 * Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
 * `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
 * A `ChannelPending` event is now emitted after the initial handshake (#2098).
 * `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
 * `ChannelManager::list_channels_by_counterparty` was added (#2079).
 * `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
 * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
 * The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.

## Backwards Compatibility
 * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
 longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
 * `Event::PaymentPathFailed::retry` was removed and will always be `None` for
 payments initiated on 0.0.115 which fail on an earlier version (#2063).
 * `Route`s and `PaymentParameters` with blinded path information will not be
 readable on prior versions of LDK. Such objects are not currently constructed
 by LDK, but may be when processing BOLT12 data in a coming release (#2146).
 * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
 `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
 in general unsupported, and included here only for completeness.

## Bug Fixes
@valentinewallacevalentinewallaceApr 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.
 * Fixed a case where `process_events_async` may `poll` a `Future` which has
 already completed (#2081).
 * Fixed deserialization of `u16` arrays. This bug may have previously corrupted
 the historical buckets in a `ProbabilisticScorer`. Users relying on the
 historical buckets may wish to wipe their scorer on upgrade to remove corrupt
 data rather than waiting on it to decay (#2191).
 * The `process_events_async` task is now `Send` and can thus be polled on a
 multi-threaded runtime (#2199).
 * Fixed a missing macro export causing
 `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
 * Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
 * Fix an issue where the `background-processor` would not wake when a
 `ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
 * Fix an issue where `process_events_async` would exit immediately (#2145).
 * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
 than `find_route`, as was intended and described in the API (#2092).
 * Ensure `process_events_async` always exits if any sleep future returns true,
 not just if all sleep futures repeatedly return true (#2145).
 * `channel_update` messages no longer set the disable bit unless the peer has
 been disconnected for some time. This should resolve cases where channels are
 disabled for extended periods of time (#2198).
 * We no longer remove CLN nodes from the network graph for violating the BOLT
 spec in some cases after failing to pay through them (#2220).
 * Fixed a debug assertion which may panic under heavy load (#2172).
 * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
 * Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
 * Transaction re-broadcasting is now substantially more aggressive, including a
 new regular rebroadcast feature called on a timer from the
@ariardariardApr 23, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.
 `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
 This should substantially increase transaction confirmation reliability
 without relying on downstream `TransactionBroadcaster` implementations for
 rebroadcasting (#2203, #2205, #2208).
 * Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
 privacy vulnerability which allows an intermediate node on the path to
 discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
 * Advait
 * Alan Cohen
 * Alec Chen
 * Allan Douglas R. de Oliveira
 * Arik Sosman
 * Elias Rohrer
 * Evan Feenstra
 * Jeffrey Czyz
 * John Cantrell
 * Lucas Soriano del Pino
 * Marc Tyndel
 * Matt Corallo
 * Paul Miller
 * Steven
 * Steven Williamson
 * Steven Zhao
 * Tony Giorgio
 * Valentine Wallace
 * Wilmer Paulino
 * benthecarman
 * munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down

12 changes: 6 additions & 6 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }

6 changes: 3 additions & 3 deletions
lightning-block-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }

4 changes: 2 additions & 2 deletions
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }

6 changes: 3 additions & 3 deletions
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}

6 changes: 3 additions & 3 deletions
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

4 changes: 0 additions & 4 deletions
pending_changelog/2059.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2063.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2146.txt

View file


Open in desktop


This file was deleted.


3 changes: 0 additions & 3 deletions
pending_changelog/matt-rm-retryable-secret.txt

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Apr 25, 2023
 Merged


Cut 0.0.115
#2211
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fb42400

Bump crate versions to 0.0.115/invoice 0.23


TheBlueMatt Apr 21, 2023
dafa095

Add 0.0.115 CHANGELOG entries


TheBlueMatt Apr 21, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


97 changes: 97 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
 * The MSRV of the main LDK crates has been increased to 1.48 (#2107).
 * Attempting to claim an un-expired payment on a channel which has closed no
 longer fails. The expiry time of payments is exposed via
 `PaymentClaimable::claim_deadline` (#2148).
 * `payment_metadata` is now supported in `Invoice` deserialization, sending,
 and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
 * `Event::PaymentFailed` now exposes a failure reason (#2142).
 * BOLT12 messages now support stateless generation and validation (#1989).
 * The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
 * Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
 * `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
 * A `ChannelPending` event is now emitted after the initial handshake (#2098).
 * `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
 * `ChannelManager::list_channels_by_counterparty` was added (#2079).
 * `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
 * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
 * The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.

## Backwards Compatibility
 * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
 longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
 * `Event::PaymentPathFailed::retry` was removed and will always be `None` for
 payments initiated on 0.0.115 which fail on an earlier version (#2063).
 * `Route`s and `PaymentParameters` with blinded path information will not be
 readable on prior versions of LDK. Such objects are not currently constructed
 by LDK, but may be when processing BOLT12 data in a coming release (#2146).
 * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
 `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
 in general unsupported, and included here only for completeness.

## Bug Fixes
@valentinewallacevalentinewallaceApr 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.
 * Fixed a case where `process_events_async` may `poll` a `Future` which has
 already completed (#2081).
 * Fixed deserialization of `u16` arrays. This bug may have previously corrupted
 the historical buckets in a `ProbabilisticScorer`. Users relying on the
 historical buckets may wish to wipe their scorer on upgrade to remove corrupt
 data rather than waiting on it to decay (#2191).
 * The `process_events_async` task is now `Send` and can thus be polled on a
 multi-threaded runtime (#2199).
 * Fixed a missing macro export causing
 `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
 * Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
 * Fix an issue where the `background-processor` would not wake when a
 `ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
 * Fix an issue where `process_events_async` would exit immediately (#2145).
 * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
 than `find_route`, as was intended and described in the API (#2092).
 * Ensure `process_events_async` always exits if any sleep future returns true,
 not just if all sleep futures repeatedly return true (#2145).
 * `channel_update` messages no longer set the disable bit unless the peer has
 been disconnected for some time. This should resolve cases where channels are
 disabled for extended periods of time (#2198).
 * We no longer remove CLN nodes from the network graph for violating the BOLT
 spec in some cases after failing to pay through them (#2220).
 * Fixed a debug assertion which may panic under heavy load (#2172).
 * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
 * Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
 * Transaction re-broadcasting is now substantially more aggressive, including a
 new regular rebroadcast feature called on a timer from the
@ariardariardApr 23, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.
 `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
 This should substantially increase transaction confirmation reliability
 without relying on downstream `TransactionBroadcaster` implementations for
 rebroadcasting (#2203, #2205, #2208).
 * Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
 privacy vulnerability which allows an intermediate node on the path to
 discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
 * Advait
 * Alan Cohen
 * Alec Chen
 * Allan Douglas R. de Oliveira
 * Arik Sosman
 * Elias Rohrer
 * Evan Feenstra
 * Jeffrey Czyz
 * John Cantrell
 * Lucas Soriano del Pino
 * Marc Tyndel
 * Matt Corallo
 * Paul Miller
 * Steven
 * Steven Williamson
 * Steven Zhao
 * Tony Giorgio
 * Valentine Wallace
 * Wilmer Paulino
 * benthecarman
 * munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down

12 changes: 6 additions & 6 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }

6 changes: 3 additions & 3 deletions
lightning-block-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }

4 changes: 2 additions & 2 deletions
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }

6 changes: 3 additions & 3 deletions
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}

6 changes: 3 additions & 3 deletions
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

4 changes: 0 additions & 4 deletions
pending_changelog/2059.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2063.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2146.txt

View file


Open in desktop


This file was deleted.


3 changes: 0 additions & 3 deletions
pending_changelog/matt-rm-retryable-secret.txt

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Apr 25, 2023
 Merged


Cut 0.0.115
#2211
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fb42400

Bump crate versions to 0.0.115/invoice 0.23


TheBlueMatt Apr 21, 2023
dafa095

Add 0.0.115 CHANGELOG entries


TheBlueMatt Apr 21, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


97 changes: 97 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
 * The MSRV of the main LDK crates has been increased to 1.48 (#2107).
 * Attempting to claim an un-expired payment on a channel which has closed no
 longer fails. The expiry time of payments is exposed via
 `PaymentClaimable::claim_deadline` (#2148).
 * `payment_metadata` is now supported in `Invoice` deserialization, sending,
 and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
 * `Event::PaymentFailed` now exposes a failure reason (#2142).
 * BOLT12 messages now support stateless generation and validation (#1989).
 * The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
 * Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
 * `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
 * A `ChannelPending` event is now emitted after the initial handshake (#2098).
 * `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
 * `ChannelManager::list_channels_by_counterparty` was added (#2079).
 * `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
 * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
 * The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.

## Backwards Compatibility
 * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
 longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
 * `Event::PaymentPathFailed::retry` was removed and will always be `None` for
 payments initiated on 0.0.115 which fail on an earlier version (#2063).
 * `Route`s and `PaymentParameters` with blinded path information will not be
 readable on prior versions of LDK. Such objects are not currently constructed
 by LDK, but may be when processing BOLT12 data in a coming release (#2146).
 * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
 `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
 in general unsupported, and included here only for completeness.

## Bug Fixes
@valentinewallacevalentinewallaceApr 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.
 * Fixed a case where `process_events_async` may `poll` a `Future` which has
 already completed (#2081).
 * Fixed deserialization of `u16` arrays. This bug may have previously corrupted
 the historical buckets in a `ProbabilisticScorer`. Users relying on the
 historical buckets may wish to wipe their scorer on upgrade to remove corrupt
 data rather than waiting on it to decay (#2191).
 * The `process_events_async` task is now `Send` and can thus be polled on a
 multi-threaded runtime (#2199).
 * Fixed a missing macro export causing
 `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
 * Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
 * Fix an issue where the `background-processor` would not wake when a
 `ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
 * Fix an issue where `process_events_async` would exit immediately (#2145).
 * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
 than `find_route`, as was intended and described in the API (#2092).
 * Ensure `process_events_async` always exits if any sleep future returns true,
 not just if all sleep futures repeatedly return true (#2145).
 * `channel_update` messages no longer set the disable bit unless the peer has
 been disconnected for some time. This should resolve cases where channels are
 disabled for extended periods of time (#2198).
 * We no longer remove CLN nodes from the network graph for violating the BOLT
 spec in some cases after failing to pay through them (#2220).
 * Fixed a debug assertion which may panic under heavy load (#2172).
 * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
 * Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
 * Transaction re-broadcasting is now substantially more aggressive, including a
 new regular rebroadcast feature called on a timer from the
@ariardariardApr 23, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.
 `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
 This should substantially increase transaction confirmation reliability
 without relying on downstream `TransactionBroadcaster` implementations for
 rebroadcasting (#2203, #2205, #2208).
 * Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
 privacy vulnerability which allows an intermediate node on the path to
 discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
 * Advait
 * Alan Cohen
 * Alec Chen
 * Allan Douglas R. de Oliveira
 * Arik Sosman
 * Elias Rohrer
 * Evan Feenstra
 * Jeffrey Czyz
 * John Cantrell
 * Lucas Soriano del Pino
 * Marc Tyndel
 * Matt Corallo
 * Paul Miller
 * Steven
 * Steven Williamson
 * Steven Zhao
 * Tony Giorgio
 * Valentine Wallace
 * Wilmer Paulino
 * benthecarman
 * munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down

12 changes: 6 additions & 6 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }

6 changes: 3 additions & 3 deletions
lightning-block-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }

4 changes: 2 additions & 2 deletions
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }

6 changes: 3 additions & 3 deletions
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}

6 changes: 3 additions & 3 deletions
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

4 changes: 0 additions & 4 deletions
pending_changelog/2059.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2063.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2146.txt

View file


Open in desktop


This file was deleted.


3 changes: 0 additions & 3 deletions
pending_changelog/matt-rm-retryable-secret.txt

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Cut 0.0.115#2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Apr 25, 2023
 Merged


Cut 0.0.115
#2211
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fb42400

Bump crate versions to 0.0.115/invoice 0.23


TheBlueMatt Apr 21, 2023
dafa095

Add 0.0.115 CHANGELOG entries


TheBlueMatt Apr 21, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


97 changes: 97 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
# 0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"

## API Updates
 * The MSRV of the main LDK crates has been increased to 1.48 (#2107).
 * Attempting to claim an un-expired payment on a channel which has closed no
 longer fails. The expiry time of payments is exposed via
 `PaymentClaimable::claim_deadline` (#2148).
 * `payment_metadata` is now supported in `Invoice` deserialization, sending,
 and receiving (via a new `RecipientOnionFields` struct) (#2139, #2127).
 * `Event::PaymentFailed` now exposes a failure reason (#2142).
 * BOLT12 messages now support stateless generation and validation (#1989).
 * The `NetworkGraph` is now pruned of stale data after RGS processing (#2161).
 * Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
 * `lightning-transaction-sync` feature `esplora-async-https` was added (#2085).
 * A `ChannelPending` event is now emitted after the initial handshake (#2098).
 * `PaymentForwarded::outbound_amount_forwarded_msat` was added (#2136).
 * `ChannelManager::list_channels_by_counterparty` was added (#2079).
 * `ChannelDetails::feerate_sat_per_1000_weight` was added (#2094).
 * `Invoice::fallback_addresses` was added to fetch `bitcoin` types (#2023).
 * The offer/refund description is now exposed in `Invoice{,Request}` (#2206).

Comment thread
TheBlueMatt marked this conversation as resolved.

## Backwards Compatibility
 * Payments sent with the legacy `*_with_route` methods on LDK 0.0.115+ will no
 longer be retryable via the LDK 0.0.114- `retry_payment` method (#2139).
 * `Event::PaymentPathFailed::retry` was removed and will always be `None` for
 payments initiated on 0.0.115 which fail on an earlier version (#2063).
 * `Route`s and `PaymentParameters` with blinded path information will not be
 readable on prior versions of LDK. Such objects are not currently constructed
 by LDK, but may be when processing BOLT12 data in a coming release (#2146).
 * Providing `ChannelMonitorUpdate`s generated by LDK 0.0.115 to a
 `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is
 in general unsupported, and included here only for completeness.

## Bug Fixes
@valentinewallacevalentinewallaceApr 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2161 a bug fix? Also #2145
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2161 is an API change, but included both, thanks.
 * Fixed a case where `process_events_async` may `poll` a `Future` which has
 already completed (#2081).
 * Fixed deserialization of `u16` arrays. This bug may have previously corrupted
 the historical buckets in a `ProbabilisticScorer`. Users relying on the
 historical buckets may wish to wipe their scorer on upgrade to remove corrupt
 data rather than waiting on it to decay (#2191).
 * The `process_events_async` task is now `Send` and can thus be polled on a
 multi-threaded runtime (#2199).
 * Fixed a missing macro export causing
 `impl_writeable_tlv_based_enum{,_upgradable}` calls to not compile (#2091).
 * Fixed compilation of `lightning-invoice` with both `no-std` and serde (#2187)
 * Fix an issue where the `background-processor` would not wake when a
 `ChannelMonitorUpdate` completed asynchronously, causing delays (#2090).
 * Fix an issue where `process_events_async` would exit immediately (#2145).
 * `Router` calls from the `ChannelManager` now call `find_route_with_id` rather
 than `find_route`, as was intended and described in the API (#2092).
 * Ensure `process_events_async` always exits if any sleep future returns true,
 not just if all sleep futures repeatedly return true (#2145).
 * `channel_update` messages no longer set the disable bit unless the peer has
 been disconnected for some time. This should resolve cases where channels are
 disabled for extended periods of time (#2198).
 * We no longer remove CLN nodes from the network graph for violating the BOLT
 spec in some cases after failing to pay through them (#2220).
 * Fixed a debug assertion which may panic under heavy load (#2172).
 * `CounterpartyForceClosed::peer_msg` is now wrapped in UntrustedString (#2114)
 * Fixed a potential deadlock in `funding_transaction_generated` (#2158).

## Security
 * Transaction re-broadcasting is now substantially more aggressive, including a
 new regular rebroadcast feature called on a timer from the
@ariardariardApr 23, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
@TheBlueMattTheBlueMattApr 24, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt inflate the feerate, we don't bump on rebroadcasts.
 `background-processor` or from `ChainMonitor::rebroadcast_pending_claims`.
 This should substantially increase transaction confirmation reliability
 without relying on downstream `TransactionBroadcaster` implementations for
 rebroadcasting (#2203, #2205, #2208).
 * Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
 privacy vulnerability which allows an intermediate node on the path to
 discover the final destination for a payment (#2062).

In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
 * Advait
 * Alan Cohen
 * Alec Chen
 * Allan Douglas R. de Oliveira
 * Arik Sosman
 * Elias Rohrer
 * Evan Feenstra
 * Jeffrey Czyz
 * John Cantrell
 * Lucas Soriano del Pino
 * Marc Tyndel
 * Matt Corallo
 * Paul Miller
 * Steven
 * Steven Williamson
 * Steven Zhao
 * Tony Giorgio
 * Valentine Wallace
 * Wilmer Paulino
 * benthecarman
 * munjesi


# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"

## API Updates
Expand Down

12 changes: 6 additions & 6 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,11 +21,11 @@ default = ["std"]

[dependencies]
bitcoin = { version = "0.29.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.115", path = "../lightning-rapid-gossip-sync", default-features = false }

[dev-dependencies]
tokio = { version = "1.14", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.23.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.115", path = "../lightning-persister" }

6 changes: 3 additions & 3 deletions
lightning-block-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -19,11 +19,11 @@ rpc-client = [ "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde_json = { version = "1.0", optional = true }
chunked_transfer = { version = "1.4", optional = true }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }
tokio = { version = "1.14", features = [ "macros", "rt" ] }

4 changes: 2 additions & 2 deletions
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.0.114"
version = "0.0.115"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }

6 changes: 3 additions & 3 deletions
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.22.0"
version = "0.23.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All@@ -21,7 +21,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
Expand All@@ -30,6 +30,6 @@ serde = { version = "1.0.118", optional = true }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}

6 changes: 3 additions & 3 deletions
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
tokio = { version = "1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.114"
version = "0.0.115"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.114", path = "../lightning" }
lightning = { version = "0.0.115", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["_test_utils"] }

6 changes: 3 additions & 3 deletions
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.0.114"
version = "0.0.115"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All@@ -21,15 +21,15 @@ esplora-blocking = ["esplora-client/blocking"]
async-interface = []

[dependencies]
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
lightning = { version = "0.0.115", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }
bdk-macros = "0.6"
futures = { version = "0.3", optional = true }
esplora-client = { version = "0.4", default-features = false, optional = true }
reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

[dev-dependencies]
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
lightning = { version = "0.0.115", path = "../lightning", features = ["std"] }
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
electrum-client = "0.12.0"
tokio = { version = "1.14.0", features = ["full"] }

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.114"
version = "0.0.115"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

4 changes: 0 additions & 4 deletions
pending_changelog/2059.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2063.txt

View file


Open in desktop


This file was deleted.


4 changes: 0 additions & 4 deletions
pending_changelog/2146.txt

View file


Open in desktop


This file was deleted.


3 changes: 0 additions & 3 deletions
pending_changelog/matt-rm-retryable-secret.txt

View file


Open in desktop


This file was deleted.