Skip to content

Prefactor PaymentParameters for blinded recipients - #2258

Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
May 8, 2023
Merged

Prefactor PaymentParameters for blinded recipients#2258
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom
valentinewallace:2023-04-blinded-pathfinding-groundwork-2

Conversation

@valentinewallace

@valentinewallacevalentinewallace commented May 2, 2023

Copy link
Copy Markdown
Contributor

Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid PaymentParameters can't be created.

@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from f7d4237 to 215ea05CompareMay 2, 2023 21:46
@valentinewallacevalentinewallace mentioned this pull request May 2, 2023
Merged
1 task
TheBlueMatt
TheBlueMatt reviewed May 3, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from 215ea05 to aec3d4dCompareMay 3, 2023 18:20
@codecov-commenter

codecov-commenter commented May 3, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 83.82% and project coverage change: -0.01⚠️

Comparison is base (2cae6f0) 91.58% compared to head (fb9983c) 91.57%.

❗ Current head fb9983c differs from pull request most recent head a84e832. Consider uploading reports for the commit a84e832 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01% 
==========================================
Files 104 105 +1 Lines 51993 60983 +8990 Branches 51993 60983 +8990 ==========================================
+ Hits 47616 55848 +8232 - Misses 4377 5135 +758
Impacted FilesCoverage Δ
lightning/src/ln/features.rs97.25% <0.00%> (-1.21%)⬇️
lightning/src/ln/channelmanager.rs91.20% <25.00%> (+2.40%)⬆️
lightning/src/routing/router.rs94.45% <83.22%> (-0.64%)⬇️
lightning/src/ln/payment_tests.rs97.57% <92.85%> (-0.01%)⬇️
lightning-invoice/src/payment.rs89.11% <100.00%> (ø)
lightning-invoice/src/utils.rs97.17% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs94.90% <100.00%> (+2.11%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs98.26% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs97.59% <100.00%> (ø)
... and 1 more

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from aec3d4d to 0275873CompareMay 3, 2023 18:29
TheBlueMatt
TheBlueMatt reviewed May 4, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.

Comment threadlightning/src/routing/router.rs
Comment threadlightning/src/routing/router.rs Outdated
@valentinewallace
Groundwork for refactoring PaymentParams::Hints to ::Payee
06eeefc
Minor changes in preparation for supporting route blinding in
PaymentParameters. In the next commit, we'll be moving more
unblinded-payee-specific fields from the top level parameters into the clear
enum variant.
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch 2 times, most recently from 1e3d7af to 0f823fbCompareMay 4, 2023 14:49
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from 0f823fb to 4729342CompareMay 4, 2023 14:54
jkczyz
jkczyz reviewed May 4, 2023
View reviewed changes
Comment threadlightning/src/ln/features.rs
Comment threadlightning/src/routing/router.rs Outdated
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from 4729342 to 554c1fcCompareMay 4, 2023 18:13
jkczyz
jkczyz previously approved these changes May 4, 2023
View reviewed changes
TheBlueMatt
TheBlueMatt reviewed May 4, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs Outdated
Comment threadlightning/src/routing/router.rs Outdated
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch 2 times, most recently from 1298418 to dca58c3CompareMay 5, 2023 19:36
TheBlueMatt
TheBlueMatt reviewed May 6, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, a few logging nits.

Comment threadlightning/src/routing/router.rs Outdated
Comment threadlightning/src/routing/router.rs Outdated
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from dca58c3 to 9d7a370CompareMay 8, 2023 15:42
jkczyz
jkczyz reviewed May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs Outdated
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from 9d7a370 to fb9983cCompareMay 8, 2023 19:24
jkczyz
jkczyz reviewed May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs Outdated
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from fb9983c to a84e832CompareMay 8, 2023 21:29
@valentinewallace
valentinewallaceforce-pushed the 2023-04-blinded-pathfinding-groundwork-2 branch from a84e832 to d56672cCompareMay 8, 2023 22:01
@TheBlueMatt
TheBlueMatt merged commit 0ecb4b0 into lightningdevkit:mainMay 8, 2023
@TheBlueMattTheBlueMatt mentioned this pull request May 8, 2023
Merged
@jkczyzjkczyz mentioned this pull request May 10, 2023
Open
60 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt

@jkczyzjkczyz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@jkczyz
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Prefactor `PaymentParameters` for blinded recipients by valentinewallace · Pull Request #2258 · lightningdevkit/rust-lightning · GitHub
Skip to content
Prefactor PaymentParameters for blinded recipients - #2258
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
May 8, 2023
Merged
Prefactor PaymentParameters for blinded recipients#2258
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
Conversation
@valentinewallace
@valentinewallacevalentinewallace
commented
May 2, 2023

Copy link


Copy Markdown

Contributor
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid PaymentParameters can't be created.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
f7d4237 to
215ea05CompareMay 2, 2023 21:46
@valentinewallacevalentinewallace
mentioned this pull request
May 2, 2023
 Merged

1 task
TheBlueMatt
TheBlueMatt
reviewed
May 3, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
215ea05 to
aec3d4dCompareMay 3, 2023 18:20
@codecov-commenter
codecov-commenter
commented
May 3, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 83.82% and project coverage change: -0.01⚠️
Comparison is base (2cae6f0) 91.58% compared to head (fb9983c) 91.57%.
❗ Current head fb9983c differs from pull request most recent head a84e832. Consider uploading reports for the commit a84e832 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01% 
==========================================
Files 104 105 +1 Lines 51993 60983 +8990 Branches 51993 60983 +8990 ==========================================
+ Hits 47616 55848 +8232 - Misses 4377 5135 +758 
Impacted FilesCoverage Δ
lightning/src/ln/features.rs97.25% <0.00%> (-1.21%)⬇️
lightning/src/ln/channelmanager.rs91.20% <25.00%> (+2.40%)⬆️
lightning/src/routing/router.rs94.45% <83.22%> (-0.64%)⬇️
lightning/src/ln/payment_tests.rs97.57% <92.85%> (-0.01%)⬇️
lightning-invoice/src/payment.rs89.11% <100.00%> (ø)
lightning-invoice/src/utils.rs97.17% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs94.90% <100.00%> (+2.11%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs98.26% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs97.59% <100.00%> (ø)
... and 1 more
... and 18 files with indirect coverage changes
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
aec3d4d to
0275873CompareMay 3, 2023 18:29
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.
Comment threadlightning/src/routing/router.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
Groundwork for refactoring PaymentParams::Hints to ::Payee
06eeefc
Minor changes in preparation for supporting route blinding in
PaymentParameters. In the next commit, we'll be moving more
unblinded-payee-specific fields from the top level parameters into the clear
enum variant.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1e3d7af to
0f823fbCompareMay 4, 2023 14:49
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
0f823fb to
4729342CompareMay 4, 2023 14:54
jkczyz
jkczyz
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/ln/features.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
4729342 to
554c1fcCompareMay 4, 2023 18:13
jkczyz
jkczyz
previously approved these changes
May 4, 2023
View reviewed changes
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1298418 to
dca58c3CompareMay 5, 2023 19:36
TheBlueMatt
TheBlueMatt
reviewed
May 6, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, a few logging nits.
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
dca58c3 to
9d7a370CompareMay 8, 2023 15:42
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
9d7a370 to
fb9983cCompareMay 8, 2023 19:24
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
fb9983c to
a84e832CompareMay 8, 2023 21:29
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
a84e832 to
d56672cCompareMay 8, 2023 22:01
@TheBlueMatt
TheBlueMatt
merged commit 0ecb4b0
into
lightningdevkit:mainMay 8, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
May 8, 2023
 Merged

@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Prefactor `PaymentParameters` for blinded recipients by valentinewallace · Pull Request #2258 · lightningdevkit/rust-lightning · GitHub
Skip to content
Prefactor PaymentParameters for blinded recipients - #2258
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
May 8, 2023
Merged
Prefactor PaymentParameters for blinded recipients#2258
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
Conversation
@valentinewallace
@valentinewallacevalentinewallace
commented
May 2, 2023

Copy link


Copy Markdown

Contributor
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid PaymentParameters can't be created.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
f7d4237 to
215ea05CompareMay 2, 2023 21:46
@valentinewallacevalentinewallace
mentioned this pull request
May 2, 2023
 Merged

1 task
TheBlueMatt
TheBlueMatt
reviewed
May 3, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
215ea05 to
aec3d4dCompareMay 3, 2023 18:20
@codecov-commenter
codecov-commenter
commented
May 3, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 83.82% and project coverage change: -0.01⚠️
Comparison is base (2cae6f0) 91.58% compared to head (fb9983c) 91.57%.
❗ Current head fb9983c differs from pull request most recent head a84e832. Consider uploading reports for the commit a84e832 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01% 
==========================================
Files 104 105 +1 Lines 51993 60983 +8990 Branches 51993 60983 +8990 ==========================================
+ Hits 47616 55848 +8232 - Misses 4377 5135 +758 
Impacted FilesCoverage Δ
lightning/src/ln/features.rs97.25% <0.00%> (-1.21%)⬇️
lightning/src/ln/channelmanager.rs91.20% <25.00%> (+2.40%)⬆️
lightning/src/routing/router.rs94.45% <83.22%> (-0.64%)⬇️
lightning/src/ln/payment_tests.rs97.57% <92.85%> (-0.01%)⬇️
lightning-invoice/src/payment.rs89.11% <100.00%> (ø)
lightning-invoice/src/utils.rs97.17% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs94.90% <100.00%> (+2.11%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs98.26% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs97.59% <100.00%> (ø)
... and 1 more
... and 18 files with indirect coverage changes
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
aec3d4d to
0275873CompareMay 3, 2023 18:29
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.
Comment threadlightning/src/routing/router.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
Groundwork for refactoring PaymentParams::Hints to ::Payee
06eeefc
Minor changes in preparation for supporting route blinding in
PaymentParameters. In the next commit, we'll be moving more
unblinded-payee-specific fields from the top level parameters into the clear
enum variant.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1e3d7af to
0f823fbCompareMay 4, 2023 14:49
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
0f823fb to
4729342CompareMay 4, 2023 14:54
jkczyz
jkczyz
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/ln/features.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
4729342 to
554c1fcCompareMay 4, 2023 18:13
jkczyz
jkczyz
previously approved these changes
May 4, 2023
View reviewed changes
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1298418 to
dca58c3CompareMay 5, 2023 19:36
TheBlueMatt
TheBlueMatt
reviewed
May 6, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, a few logging nits.
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
dca58c3 to
9d7a370CompareMay 8, 2023 15:42
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
9d7a370 to
fb9983cCompareMay 8, 2023 19:24
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
fb9983c to
a84e832CompareMay 8, 2023 21:29
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
a84e832 to
d56672cCompareMay 8, 2023 22:01
@TheBlueMatt
TheBlueMatt
merged commit 0ecb4b0
into
lightningdevkit:mainMay 8, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
May 8, 2023
 Merged

@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Prefactor `PaymentParameters` for blinded recipients by valentinewallace · Pull Request #2258 · lightningdevkit/rust-lightning · GitHub
Skip to content
Prefactor PaymentParameters for blinded recipients - #2258
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
May 8, 2023
Merged
Prefactor PaymentParameters for blinded recipients#2258
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
Conversation
@valentinewallace
@valentinewallacevalentinewallace
commented
May 2, 2023

Copy link


Copy Markdown

Contributor
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid PaymentParameters can't be created.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
f7d4237 to
215ea05CompareMay 2, 2023 21:46
@valentinewallacevalentinewallace
mentioned this pull request
May 2, 2023
 Merged

1 task
TheBlueMatt
TheBlueMatt
reviewed
May 3, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
215ea05 to
aec3d4dCompareMay 3, 2023 18:20
@codecov-commenter
codecov-commenter
commented
May 3, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 83.82% and project coverage change: -0.01⚠️
Comparison is base (2cae6f0) 91.58% compared to head (fb9983c) 91.57%.
❗ Current head fb9983c differs from pull request most recent head a84e832. Consider uploading reports for the commit a84e832 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01% 
==========================================
Files 104 105 +1 Lines 51993 60983 +8990 Branches 51993 60983 +8990 ==========================================
+ Hits 47616 55848 +8232 - Misses 4377 5135 +758 
Impacted FilesCoverage Δ
lightning/src/ln/features.rs97.25% <0.00%> (-1.21%)⬇️
lightning/src/ln/channelmanager.rs91.20% <25.00%> (+2.40%)⬆️
lightning/src/routing/router.rs94.45% <83.22%> (-0.64%)⬇️
lightning/src/ln/payment_tests.rs97.57% <92.85%> (-0.01%)⬇️
lightning-invoice/src/payment.rs89.11% <100.00%> (ø)
lightning-invoice/src/utils.rs97.17% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs94.90% <100.00%> (+2.11%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs98.26% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs97.59% <100.00%> (ø)
... and 1 more
... and 18 files with indirect coverage changes
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
aec3d4d to
0275873CompareMay 3, 2023 18:29
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.
Comment threadlightning/src/routing/router.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
Groundwork for refactoring PaymentParams::Hints to ::Payee
06eeefc
Minor changes in preparation for supporting route blinding in
PaymentParameters. In the next commit, we'll be moving more
unblinded-payee-specific fields from the top level parameters into the clear
enum variant.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1e3d7af to
0f823fbCompareMay 4, 2023 14:49
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
0f823fb to
4729342CompareMay 4, 2023 14:54
jkczyz
jkczyz
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/ln/features.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
4729342 to
554c1fcCompareMay 4, 2023 18:13
jkczyz
jkczyz
previously approved these changes
May 4, 2023
View reviewed changes
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1298418 to
dca58c3CompareMay 5, 2023 19:36
TheBlueMatt
TheBlueMatt
reviewed
May 6, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, a few logging nits.
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
dca58c3 to
9d7a370CompareMay 8, 2023 15:42
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
9d7a370 to
fb9983cCompareMay 8, 2023 19:24
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
fb9983c to
a84e832CompareMay 8, 2023 21:29
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
a84e832 to
d56672cCompareMay 8, 2023 22:01
@TheBlueMatt
TheBlueMatt
merged commit 0ecb4b0
into
lightningdevkit:mainMay 8, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
May 8, 2023
 Merged

@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Prefactor `PaymentParameters` for blinded recipients by valentinewallace · Pull Request #2258 · lightningdevkit/rust-lightning · GitHub
Skip to content
Prefactor PaymentParameters for blinded recipients - #2258
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
May 8, 2023
Merged
Prefactor PaymentParameters for blinded recipients#2258
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
Conversation
@valentinewallace
@valentinewallacevalentinewallace
commented
May 2, 2023

Copy link


Copy Markdown

Contributor
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid PaymentParameters can't be created.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
f7d4237 to
215ea05CompareMay 2, 2023 21:46
@valentinewallacevalentinewallace
mentioned this pull request
May 2, 2023
 Merged

1 task
TheBlueMatt
TheBlueMatt
reviewed
May 3, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
215ea05 to
aec3d4dCompareMay 3, 2023 18:20
@codecov-commenter
codecov-commenter
commented
May 3, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 83.82% and project coverage change: -0.01⚠️
Comparison is base (2cae6f0) 91.58% compared to head (fb9983c) 91.57%.
❗ Current head fb9983c differs from pull request most recent head a84e832. Consider uploading reports for the commit a84e832 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01% 
==========================================
Files 104 105 +1 Lines 51993 60983 +8990 Branches 51993 60983 +8990 ==========================================
+ Hits 47616 55848 +8232 - Misses 4377 5135 +758 
Impacted FilesCoverage Δ
lightning/src/ln/features.rs97.25% <0.00%> (-1.21%)⬇️
lightning/src/ln/channelmanager.rs91.20% <25.00%> (+2.40%)⬆️
lightning/src/routing/router.rs94.45% <83.22%> (-0.64%)⬇️
lightning/src/ln/payment_tests.rs97.57% <92.85%> (-0.01%)⬇️
lightning-invoice/src/payment.rs89.11% <100.00%> (ø)
lightning-invoice/src/utils.rs97.17% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs94.90% <100.00%> (+2.11%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs98.26% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs97.59% <100.00%> (ø)
... and 1 more
... and 18 files with indirect coverage changes
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
aec3d4d to
0275873CompareMay 3, 2023 18:29
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.
Comment threadlightning/src/routing/router.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
Groundwork for refactoring PaymentParams::Hints to ::Payee
06eeefc
Minor changes in preparation for supporting route blinding in
PaymentParameters. In the next commit, we'll be moving more
unblinded-payee-specific fields from the top level parameters into the clear
enum variant.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1e3d7af to
0f823fbCompareMay 4, 2023 14:49
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
0f823fb to
4729342CompareMay 4, 2023 14:54
jkczyz
jkczyz
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/ln/features.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
4729342 to
554c1fcCompareMay 4, 2023 18:13
jkczyz
jkczyz
previously approved these changes
May 4, 2023
View reviewed changes
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1298418 to
dca58c3CompareMay 5, 2023 19:36
TheBlueMatt
TheBlueMatt
reviewed
May 6, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, a few logging nits.
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
dca58c3 to
9d7a370CompareMay 8, 2023 15:42
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
9d7a370 to
fb9983cCompareMay 8, 2023 19:24
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
fb9983c to
a84e832CompareMay 8, 2023 21:29
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
a84e832 to
d56672cCompareMay 8, 2023 22:01
@TheBlueMatt
TheBlueMatt
merged commit 0ecb4b0
into
lightningdevkit:mainMay 8, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
May 8, 2023
 Merged

@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Prefactor `PaymentParameters` for blinded recipients by valentinewallace · Pull Request #2258 · lightningdevkit/rust-lightning · GitHub
Skip to content
Prefactor PaymentParameters for blinded recipients - #2258
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
May 8, 2023
Merged
Prefactor PaymentParameters for blinded recipients#2258
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
Conversation
@valentinewallace
@valentinewallacevalentinewallace
commented
May 2, 2023

Copy link


Copy Markdown

Contributor
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid PaymentParameters can't be created.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
f7d4237 to
215ea05CompareMay 2, 2023 21:46
@valentinewallacevalentinewallace
mentioned this pull request
May 2, 2023
 Merged

1 task
TheBlueMatt
TheBlueMatt
reviewed
May 3, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
215ea05 to
aec3d4dCompareMay 3, 2023 18:20
@codecov-commenter
codecov-commenter
commented
May 3, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 83.82% and project coverage change: -0.01⚠️
Comparison is base (2cae6f0) 91.58% compared to head (fb9983c) 91.57%.
❗ Current head fb9983c differs from pull request most recent head a84e832. Consider uploading reports for the commit a84e832 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01% 
==========================================
Files 104 105 +1 Lines 51993 60983 +8990 Branches 51993 60983 +8990 ==========================================
+ Hits 47616 55848 +8232 - Misses 4377 5135 +758 
Impacted FilesCoverage Δ
lightning/src/ln/features.rs97.25% <0.00%> (-1.21%)⬇️
lightning/src/ln/channelmanager.rs91.20% <25.00%> (+2.40%)⬆️
lightning/src/routing/router.rs94.45% <83.22%> (-0.64%)⬇️
lightning/src/ln/payment_tests.rs97.57% <92.85%> (-0.01%)⬇️
lightning-invoice/src/payment.rs89.11% <100.00%> (ø)
lightning-invoice/src/utils.rs97.17% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs94.90% <100.00%> (+2.11%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs98.26% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs97.59% <100.00%> (ø)
... and 1 more
... and 18 files with indirect coverage changes
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
aec3d4d to
0275873CompareMay 3, 2023 18:29
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.
Comment threadlightning/src/routing/router.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
Groundwork for refactoring PaymentParams::Hints to ::Payee
06eeefc
Minor changes in preparation for supporting route blinding in
PaymentParameters. In the next commit, we'll be moving more
unblinded-payee-specific fields from the top level parameters into the clear
enum variant.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1e3d7af to
0f823fbCompareMay 4, 2023 14:49
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
0f823fb to
4729342CompareMay 4, 2023 14:54
jkczyz
jkczyz
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/ln/features.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
4729342 to
554c1fcCompareMay 4, 2023 18:13
jkczyz
jkczyz
previously approved these changes
May 4, 2023
View reviewed changes
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1298418 to
dca58c3CompareMay 5, 2023 19:36
TheBlueMatt
TheBlueMatt
reviewed
May 6, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, a few logging nits.
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
dca58c3 to
9d7a370CompareMay 8, 2023 15:42
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
9d7a370 to
fb9983cCompareMay 8, 2023 19:24
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
fb9983c to
a84e832CompareMay 8, 2023 21:29
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
a84e832 to
d56672cCompareMay 8, 2023 22:01
@TheBlueMatt
TheBlueMatt
merged commit 0ecb4b0
into
lightningdevkit:mainMay 8, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
May 8, 2023
 Merged

@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Prefactor `PaymentParameters` for blinded recipients by valentinewallace · Pull Request #2258 · lightningdevkit/rust-lightning · GitHub
Skip to content
Prefactor PaymentParameters for blinded recipients - #2258
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
May 8, 2023
Merged
Prefactor PaymentParameters for blinded recipients#2258
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
valentinewallace:2023-04-blinded-pathfinding-groundwork-2
Conversation
@valentinewallace
@valentinewallacevalentinewallace
commented
May 2, 2023

Copy link


Copy Markdown

Contributor
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid PaymentParameters can't be created.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
f7d4237 to
215ea05CompareMay 2, 2023 21:46
@valentinewallacevalentinewallace
mentioned this pull request
May 2, 2023
 Merged

1 task
TheBlueMatt
TheBlueMatt
reviewed
May 3, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
215ea05 to
aec3d4dCompareMay 3, 2023 18:20
@codecov-commenter
codecov-commenter
commented
May 3, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Patch coverage: 83.82% and project coverage change: -0.01⚠️
Comparison is base (2cae6f0) 91.58% compared to head (fb9983c) 91.57%.
❗ Current head fb9983c differs from pull request most recent head a84e832. Consider uploading reports for the commit a84e832 to get more accurate results
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01% 
==========================================
Files 104 105 +1 Lines 51993 60983 +8990 Branches 51993 60983 +8990 ==========================================
+ Hits 47616 55848 +8232 - Misses 4377 5135 +758 
Impacted FilesCoverage Δ
lightning/src/ln/features.rs97.25% <0.00%> (-1.21%)⬇️
lightning/src/ln/channelmanager.rs91.20% <25.00%> (+2.40%)⬆️
lightning/src/routing/router.rs94.45% <83.22%> (-0.64%)⬇️
lightning/src/ln/payment_tests.rs97.57% <92.85%> (-0.01%)⬇️
lightning-invoice/src/payment.rs89.11% <100.00%> (ø)
lightning-invoice/src/utils.rs97.17% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs94.90% <100.00%> (+2.11%)⬆️
lightning/src/ln/functional_tests.rs98.25% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs98.26% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs97.59% <100.00%> (ø)
... and 1 more
... and 18 files with indirect coverage changes
☔ View full report in Codecov by Sentry.

📢 Do you have feedback about the report comment? Let us know in this issue.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
aec3d4d to
0275873CompareMay 3, 2023 18:29
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.
Comment threadlightning/src/routing/router.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
Groundwork for refactoring PaymentParams::Hints to ::Payee
06eeefc
Minor changes in preparation for supporting route blinding in
PaymentParameters. In the next commit, we'll be moving more
unblinded-payee-specific fields from the top level parameters into the clear
enum variant.
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1e3d7af to
0f823fbCompareMay 4, 2023 14:49
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
0f823fb to
4729342CompareMay 4, 2023 14:54
jkczyz
jkczyz
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/ln/features.rs
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
4729342 to
554c1fcCompareMay 4, 2023 18:13
jkczyz
jkczyz
previously approved these changes
May 4, 2023
View reviewed changes
TheBlueMatt
TheBlueMatt
reviewed
May 4, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1298418 to
dca58c3CompareMay 5, 2023 19:36
TheBlueMatt
TheBlueMatt
reviewed
May 6, 2023
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, a few logging nits.
Comment threadlightning/src/routing/router.rs
Outdated

Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
dca58c3 to
9d7a370CompareMay 8, 2023 15:42
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
9d7a370 to
fb9983cCompareMay 8, 2023 19:24
jkczyz
jkczyz
reviewed
May 8, 2023
View reviewed changes
Comment threadlightning/src/routing/router.rs
Outdated

@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
fb9983c to
a84e832CompareMay 8, 2023 21:29
@valentinewallace
valentinewallaceforce-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
a84e832 to
d56672cCompareMay 8, 2023 22:01
@TheBlueMatt
TheBlueMatt
merged commit 0ecb4b0
into
lightningdevkit:mainMay 8, 2023
@TheBlueMattTheBlueMatt
mentioned this pull request
May 8, 2023
 Merged

@jkczyzjkczyz
mentioned this pull request
May 10, 2023

Open

60 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@TheBlueMattTheBlueMatt
@jkczyzjkczyz

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@jkczyz