Bump version to 0.0.6 by TheBlueMatt · Pull Request #226 · lightningdevkit/rust-lightning

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

TheBlueMatt · 2018-10-26T21:25:32Z

Based on a whole heap of PRs, and also "Fix + test disconnect/reconnect prior to FundingLocked".

yuntai · 2018-10-27T02:31:45Z

+	DynamicOutput {
+ /// Outpoint spendable by user wallet
+ outpoint: OutPoint,
+ /// local_delayedkey = delayed_payment_basepoint_secret + SHA256(per_commitment_point || delayed_payment_basepoint


a closing parenthesis missing

Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Drop channel_close_key from ChannelKeys

…nnel Drop channel_monitor_claim_key from ChannelKeys

This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

This slightly changes the serialization format, but we're still early enough that that's OK.

Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

yuntai reviewed Oct 27, 2018
View reviewed changes

TheBlueMatt mentioned this pull request Oct 27, 2018
Implement and document Channel/ChannelManager (de)serialization #223
Merged

TheBlueMatt force-pushed the 2018-10-0.0.6 branch from 6197b80 to c811de5Compare October 27, 2018 05:46

Antoine Riardand others added 26 commits October 27, 2018 09:34

Generate Events from ChannelMonitor to indicate spendable ouputs
8c235d9
Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key

Add a KeysInterface which provides keys from user
d33cb3c
Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data

Implement KeysInterface for KeysManager util
6d5dc6c

Integrate KeysInterface to ChannelManager with Arc
e361fed

Integrate shutdown_pubkey from KeysInterface in ChannelManager/Channel
32a9378
Drop channel_close_key from ChannelKeys

Integrate destination_script from KeysInterface in ChannelManager/Cha…
5180686
…nnel Drop channel_monitor_claim_key from ChannelKeys

Split Event, move MessageSendEvent push() inside channel_state lock
e397cb9

Send AcceptChannel responses out-of-band to ensure ordered delivery
608d517

Send funding_signed messages out-of-band to ensure ordered delivery
c962a27

Send announcement_signatures msgs out-of-band for ordered delivery
e382a7b

Send shutdown/closing_signed msgs out-of-band for ordered delivery
812f255

Send RAA/CS messages out-of-band to ensure ordered delivery
4342114

Respond to channel_reestablish out-of-band for ordered delivery
e2de49d

Send channel_reestablish out-of-band to ensure ordered deliver
249aa77

Avoid reentrancy of send_data from PeerHandler::read_bytes.
294ad32
This greatly simplifies clients of PeerHandler, and because almost all response messages have already been moved to process_events this doesn't change much effeciency-wise.

Fix and test update_add_htlc but disconnect pre-commitment_signed
c0c139c

Store [u8; 32]s instead of SharedSecrets (for deserialization)
bb43b98

Add a second Readable trait for state args, clean macros slightly
062a02d

Give ChannelMonitor a logger via new ReadableArgs trait
47fe673

Add a BIG lock to ChannelManager
74cec62
During normal operation we should never need to take this, so we use a RwLock that allows normal parallelism until we want to serialize out our ChannelManager, at which point we can take the write-mode lock.

impl Readable/Writable for Route
4eafd37

impl some additional (de)serializers, including a u48 wrapper type
f049011

Redo ChannelMonitor deserialization to avoid read_to_end()
612e280
This slightly changes the serialization format, but we're still early enough that that's OK.

Track last_block_hash in ChannelMonitor and expose it on deser
56513f2
Also make block_connected take a &mut self to ensure serialized state will always be self-consistent.

Track ChannelMonitor-watched-outpoints (+ remove now-uesless Mutex)
6f08779

Store+expose bits of Channel[Monitor] to figure out local state
b2bd64d

TheBlueMatt force-pushed the 2018-10-0.0.6 branch from c811de5 to 6ecd9b0Compare October 27, 2018 13:44

TheBlueMatt added 5 commits October 27, 2018 09:58

Implement and document Channel/ChannelManager (de)serialization
a2fb3cc

Add very basic test of ChannelManager serialization round-trip
7f91572

Fix + test disconnect/reconnect prior to FundingLocked
6ed5a82

fix broken state comparison (thanks@yuntai!)
4a51f4f

Bump version to 0.0.6
cfff650

TheBlueMatt force-pushed the 2018-10-0.0.6 branch from 6ecd9b0 to cfff650Compare October 27, 2018 13:58

TheBlueMatt merged commit b297d5b into lightningdevkit:masterOct 27, 2018