Skip to content

Blinded pathfinding fuzzing - #2366

Merged
valentinewallace merged 2 commits into
lightningdevkit:mainfrom
valentinewallace:2023-05-blinded-pathfinding-fuzz
Jul 31, 2023
Merged

Blinded pathfinding fuzzing#2366
valentinewallace merged 2 commits into
lightningdevkit:mainfrom
valentinewallace:2023-05-blinded-pathfinding-fuzz

Conversation

@valentinewallace

@valentinewallacevalentinewallace commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Fuzz test blinded payment pathfinding. Partially addresses #1970.

TheBlueMatt
TheBlueMatt reviewed Jun 20, 2023
View reviewed changes
Comment threadfuzz/src/router.rs Outdated
Comment threadfuzz/src/router.rs Outdated
@valentinewallacevalentinewallace mentioned this pull request Jul 13, 2023
Open
60 tasks
@valentinewallace
valentinewallaceforce-pushed the 2023-05-blinded-pathfinding-fuzz branch from 02bc479 to 851ebf7CompareJuly 17, 2023 18:37
@valentinewallacevalentinewallace added this to the 0.0.117 milestone Jul 17, 2023
@valentinewallace
valentinewallaceforce-pushed the 2023-05-blinded-pathfinding-fuzz branch from 851ebf7 to e7d5950CompareJuly 25, 2023 21:58
@valentinewallace

valentinewallace commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

Rebased to fix CI

@codecov-commenter

codecov-commenter commented Jul 25, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19% 🎉

Comparison is base (685f266) 90.33% compared to head (851ebf7) 90.53%.

❗ Current head 851ebf7 differs from pull request most recent head e7d5950. Consider uploading reports for the commit e7d5950 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@ Coverage Diff @@## main #2366 +/- ##
==========================================
+ Coverage 90.33% 90.53% +0.19% 
==========================================
Files 106 106 Lines 55732 57311 +1579 Branches 55732 57311 +1579 ==========================================
+ Hits 50347 51886 +1539 - Misses 5385 5425 +40
Files ChangedCoverage Δ
lightning/src/blinded_path/mod.rs93.18% <100.00%> (-1.08%)⬇️
lightning/src/routing/router.rs93.38% <100.00%> (-0.26%)⬇️

... and 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valentinewallace
Router fuzz: macroize first/last hops construction and pathfinding call
9bf4b6e
For reuse in fuzzing blinded payment pathfinding, and to ensure fuzz input
values are fetched in the same order in both match arms.
@valentinewallace
Fuzz test blinded payment pathfinding
a35b92c
@valentinewallace
valentinewallaceforce-pushed the 2023-05-blinded-pathfinding-fuzz branch from e7d5950 to a35b92cCompareJuly 25, 2023 23:33
TheBlueMatt
TheBlueMatt approved these changes Jul 30, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@valentinewallace
valentinewallace merged commit 6f58072 into lightningdevkit:mainJul 31, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@wpaulinowpaulinowpaulino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.0.117 - Everything but the Twelve S...

Development

Successfully merging this pull request may close these issues.

4 participants

@valentinewallace@codecov-commenter@TheBlueMatt@wpaulino