Skip to content

Flip keysend feature bit on - #2465

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
alecchendev:2023-07-flip-keysend-feature-bit
Jul 31, 2023
Merged

Flip keysend feature bit on#2465
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
alecchendev:2023-07-flip-keysend-feature-bit

Conversation

@alecchendev

Copy link
Copy Markdown
Contributor

Keysend seems to be the only feature bit that's in the node context and not the init context, so whenever we switched to providing the default init feature bits as our node feature bits, we must've left out keysend!

@TheBlueMattTheBlueMatt linked an issue Jul 31, 2023 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Jul 31, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (5cddf5e) to head (7ee90a5).
⚠️ Report is 4170 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2465 +/- ##
=======================================
Coverage 90.33% 90.34% =======================================
Files 106 106 Lines 55732 55734 +2 Branches 55732 55734 +2 =======================================
+ Hits 50347 50351 +4 + Misses 5385 5383 -2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keysend feature not set

5 participants

@alecchendev@codecov-commenter@TheBlueMatt@wpaulino@valentinewallace