Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Allow combining of Prob Scorers by benthecarman · Pull Request #2469 · lightningdevkit/rust-lightning · GitHub
Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow combining of Prob Scorers by benthecarman · Pull Request #2469 · lightningdevkit/rust-lightning · GitHub
Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow combining of Prob Scorers by benthecarman · Pull Request #2469 · lightningdevkit/rust-lightning · GitHub
Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Allow combining of Prob Scorers by benthecarman · Pull Request #2469 · lightningdevkit/rust-lightning · GitHub
Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow combining of Prob Scorers by benthecarman · Pull Request #2469 · lightningdevkit/rust-lightning · GitHub
Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow combining of Prob Scorers by benthecarman · Pull Request #2469 · lightningdevkit/rust-lightning · GitHub
Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Allow combining of Prob Scorers by benthecarman · Pull Request #2469 · lightningdevkit/rust-lightning · GitHub
Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions lightning/src/routing/scoring.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -650,6 +650,20 @@ struct HistoricalBucketRangeTracker {

impl HistoricalBucketRangeTracker {
fn new() -> Self { Self { buckets: [0; 8] } }

/// Returns the average of the buckets between the two trackers.
pub(crate) fn combine(mut self, other: Self) -> Self {
let mut buckets: [u16; 8] = [0; 8];
Comment thread
benthecarman marked this conversation as resolved.
for i in 0..8 {
Comment thread
benthecarman marked this conversation as resolved.
let current = self.buckets[i];
let other = other.buckets[i];
buckets[i] = (current + other) / 2;
}

self.buckets = buckets;
self
}

fn track_datapoint(&mut self, liquidity_offset_msat: u64, capacity_msat: u64) {
// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
// we spend in each bucket as a 16-bit fixed-point number with a 5 bit fractional part.
Expand DownExpand Up@@ -787,6 +801,7 @@ impl HistoricalMinMaxBuckets<'_> {
/// Direction is defined in terms of [`NodeId`] partial ordering, where the source node is the
/// first node in the ordering of the channel's counterparties. Thus, swapping the two liquidity
/// offset fields gives the opposite direction.
#[derive(Clone)]
Comment thread
benthecarman marked this conversation as resolved.
struct ChannelLiquidity<T: Time> {
/// Lower channel liquidity bound in terms of an offset from zero.
min_liquidity_offset_msat: u64,
Expand All@@ -801,6 +816,21 @@ struct ChannelLiquidity<T: Time> {
max_liquidity_offset_history: HistoricalBucketRangeTracker,
}

impl<T: Time> ChannelLiquidity<T> {
pub(crate) fn combine(mut self, other: Self) -> Self {
self.min_liquidity_offset_msat = self.min_liquidity_offset_msat.max(other.min_liquidity_offset_msat);
self.max_liquidity_offset_msat = self.max_liquidity_offset_msat.min(other.max_liquidity_offset_msat);
Comment on lines +821 to +822

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. You need to use the methods on DirectedChannelLiquidity otherwise these aren't decayed and thus aren't directly comparable. Each ChannelLiquidity will likely have a different last_updated, meaning one may need to be decayed more than the other.

self.min_liquidity_offset_history.combine(other.min_liquidity_offset_history);
self.max_liquidity_offset_history.combine(other.max_liquidity_offset_history);

if self.last_updated.duration_since(other.last_updated) < Duration::from_secs(0) {
self.last_updated = other.last_updated;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing last_updated without decaying the liquidity offsets to reflect the new time won't work. The data is stored as undecayed offsets. When the penalty is calculated, the offsets are decayed based on elapsed time since the last_updated. And any time last_updated is modified, any unaffected offset from the update is set to its decayed value. You'll need to do something similar here, otherwise offsets may not be properly decayed.

See DirectedChannelLiquidity::set_min_liquidity_msat and DirectedChannelLiquidity::set_max_liquidity_msat. I think it would be easiest to normalize self and other by setting setting each offset to their decayed values and set last_updated to T::now(). Then they can be directly compared.

}

self
}
}

/// A snapshot of [`ChannelLiquidity`] in one direction assuming a certain channel capacity and
/// decayed with a given half life.
struct DirectedChannelLiquidity<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>, T: Time, U: Deref<Target = T>> {
Expand DownExpand Up@@ -942,6 +972,27 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> ProbabilisticScorerU
}
None
}

/// Combines two `ProbabilisticScorerUsingTime` into one.
///
/// This merges the channel liquidity information of both scorers.
pub fn combine(mut self, other: Self) -> Self {
let mut channel_liquidities = self.channel_liquidities;
Comment thread
benthecarman marked this conversation as resolved.

for (id, item) in other.channel_liquidities {
match channel_liquidities.get(&id) {
None => { channel_liquidities.insert(id, item); },
Some(current) => {
let liquidity = current.clone();
channel_liquidities.insert(id, liquidity.combine(item));
}
}
}

self.channel_liquidities = channel_liquidities;

self
}
}

impl<T: Time> ChannelLiquidity<T> {
Expand Down