Improve block connection logging and filtered txids

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.

[Sharmalm]

this pr solves #2348.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcf47a4) 88.57% compared to head (f89d42c) 89.68%.
Report is 50 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2637 +/- ##
==========================================
+ Coverage 88.57% 89.68% +1.10% 
==========================================
Files 115 115 Lines 90687 98529 +7842 Branches 90687 98529 +7842 ==========================================
+ Hits 80327 88364 +8037 + Misses 7962 7842 -120 + Partials 2398 2323 -75 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharmalm]

I have updated the changes, please review it :)

[TheBlueMatt]

Sorry, somehow missed your previous push. Two more comments and I think this is good.

[valentinewallace]

Some nits but nothing blocking!

[Sharmalm]

if every looks good in this PR, then i'll rebase this commit also.
Thank you everyone for the guidance and help during this PR :)

[Sharmalm]

I have been busy with my End term examination of my college , so i wasn't able to update this PR. Now i am active.

[shaavan]

Hi @Sharmalm! Thank you for the PR update, and I hope your End Term Examinations went well!

I have a suggestion to enhance consistency in the PR. Given that we have explicitly defined "Display" for the OutPoint struct, I propose using it instead of (".. {}:{} ..", txid, index) for better clarity.

Here's the proposed diff:

 let lock = self.inner.lock().unwrap();
filter.register_tx(&lock.get_funding_txo().0.txid, &lock.get_funding_txo().1);
log_trace!(logger, - "Registering funding outpoint {}:{}", &lock.get_funding_txo().0.txid, &lock.get_funding_txo().0.index);+ "Registering funding outpoint {}", &lock.get_funding_txo().0);
for (txid, outputs) in lock.get_outputs_to_watch().iter() {
for (index, script_pubkey) in outputs.iter() {
assert!(*index <= u16::max_value() as u32);
+ let outpoint = OutPoint { txid: *txid, index: *index as u16 };
filter.register_output(WatchedOutput {
block_hash: None,
- outpoint: OutPoint { txid: *txid, index: *index as u16 },+ outpoint: outpoint,
script_pubkey: script_pubkey.clone(),
});
- log_trace!(logger, "Adding monitoring for spends of outpoint {}:{} to the filter", txid, index);+ log_trace!(logger, "Adding monitoring for spends of outpoint {} to the filter", outpoint);
}
}
}

[Sharmalm]

Okay

[shaavan]

Let's squash the commits together before going with the final ACK.
If you need help with git squash or rebasing, this guide will prove helpful!

https://www.freecodecamp.org/news/git-squash-commits/

[Sharmalm]

So everything looks good?

[shaavan]

Yep!

[valentinewallace]

LGTM after squash.

[TheBlueMatt]

Can you please update the commit to have a description of what its doing, rather than a list of previous commit titles? See https://cbea.ms/git-commit/ for suggested formats.

[Sharmalm]

I have update the the description.

[shaavan]

Just a quick note:

This commit is logging confirmed TXIDs and also logging when we add things to the filter.

The commit message is improved, but it still feels like it's missing something. How about adding a mention of implementing the Display trait?

Here's my suggestion:

"Implement the Display trait for Outpoint and utilize it in the codebase for monitoring outpoints. Additionally, add log tracing for best_block_update and confirmed transactions."

Thanks!

[shaavan]

ACK

needs to use new logging wrappers

[TheBlueMatt]

Good enough.