') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Cut 0.0.118 by TheBlueMatt · Pull Request #2678 · lightningdevkit/rust-lightning · GitHub
Skip to content

Cut 0.0.118 - #2678

Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-10-0.0.118
Oct 24, 2023
Merged

Cut 0.0.118#2678
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-10-0.0.118

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

Will need updates for the last three prs still.

@TheBlueMattTheBlueMatt added this to the 0.0.118 milestone Oct 20, 2023
@ariard

ariard commented Oct 20, 2023

Copy link
Copy Markdown

see if a grab of #2250 can make it. no strong opinion.

@TheBlueMatt

TheBlueMatt commented Oct 20, 2023

Copy link
Copy Markdown
CollaboratorAuthor

That PR is still pending someone doing an analysis of what the impact is on node selection in others' routing algorithms.

@codecov-commenter

codecov-commenter commented Oct 20, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0795d8) 88.76% compared to head (b664875) 88.76%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## main #2678 +/- ##
==========================================
- Coverage 88.76% 88.76% -0.01% 
==========================================
Files 112 112 Lines 88474 88474 Branches 88474 88474 ==========================================
- Hits 78537 78533 -4 - Misses 7702 7706 +4 
Partials 2235 2235

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benthecarman
benthecarman reviewed Oct 20, 2023
View reviewed changes
Comment threadCHANGELOG.md
wpaulino
wpaulino reviewed Oct 23, 2023
View reviewed changes

@wpaulinowpaulino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
valentinewallace
valentinewallace reviewed Oct 23, 2023
View reviewed changes

@valentinewallacevalentinewallace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squash

Comment threadCHANGELOG.md Outdated
jkczyz
jkczyz reviewed Oct 23, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
## API Updates
* BOLT12 sending and receiving is now supported as an alpha feature. You may
run into unexpected issues and will need to have a direct connection with
onion message peer targets in order to exchange messages. We are seeking

@jkczyzjkczyzOct 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say "payment recipient" instead of "onion message peer targets in order to exchange messages"? Simpler and also includes the payment portion of the flow, which also requires a direct connection.

@TheBlueMattTheBlueMattOct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But its not the "payment recipient" in the case of blinded paths. I agree we should make it less wordy, though.

@jkczyzjkczyzOct 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is something like "payment recipient, which must also be the introduction node in blinded paths".

@TheBlueMattTheBlueMattOct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, we definitely dont need a direct connection to the payment recipient, right?

@jkczyzjkczyzOct 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2540 is listed in #1970 for "Forwarding and receiving to multi-hop blinded paths"

@TheBlueMattTheBlueMattOct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we can't forward, and we currently only generate one-hop, but none of those require direct-connection. We need to be able to get a message to our peer via direct-connection-to-blinded-intro, but the responses from our peer can all come routed.

@jkczyzjkczyzOct 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right. I was confusing myself about support for blinded payment paths, actually. We can find a payment path to them, though, so it's "the offer's recipient or the introduction node of its blinded paths".

@TheBlueMattTheBlueMattOct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, pushed a potential change, lmk if its reasonable.

Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
@TheBlueMatt
TheBlueMattforce-pushed the 2023-10-0.0.118 branch 4 times, most recently from 24c98d2 to 25f7196CompareOctober 23, 2023 22:36
@TheBlueMatt

TheBlueMatt commented Oct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Also added missing backwards compat notes. Correct me if the second one is wrong but I believe we've changed the serialization of the pending waiting-for-invoice payment timeout, which will fail deserialization.

@TheBlueMatt

TheBlueMatt commented Oct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Squashed, added diff stats, ready to go 🎉

@valentinewallace

valentinewallace commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Also added missing backwards compat notes. Correct me if the second one is wrong but I believe we've changed the serialization of the pending waiting-for-invoice payment timeout, which will fail deserialization.

That's accurate, though I wasn't sure if it was necessary to have a release note since I think the AwaitingInvoice variant could not be created via the public API.

@TheBlueMatt

TheBlueMatt commented Oct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

True, but calling a method then trying to downgrade and immediately failing is generally something we document.

valentinewallace
valentinewallace previously approved these changes Oct 23, 2023
View reviewed changes
valentinewallace
valentinewallace reviewed Oct 23, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
@TheBlueMatt
TheBlueMatt merged commit d2242f6 into lightningdevkit:mainOct 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.0.118

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@ariard@codecov-commenter@valentinewallace@jkczyz@wpaulino@benthecarman