cfg-gate async signing logic

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.

[TheBlueMatt]

We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.

Here we add a new async_signing cfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through
014a336.

[shaavan]

ACK modulo nit

The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).

Would it make sense to gate this function, too?

[wpaulino]

It's part of the test suite so it doesn't matter.