Skip to content

Cut 0.0.119 - #2794

Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-12-cut-119
Dec 16, 2023
Merged

Cut 0.0.119#2794
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2023-12-cut-119

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Dec 14, 2023

Copy link
Copy Markdown
Collaborator

Still need to finalize some comments, plus any new PRs, and bump crate versions.

@TheBlueMattTheBlueMatt added this to the 0.0.119 milestone Dec 14, 2023
@codecov-commenter

codecov-commenter commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef2156a) 88.43% compared to head (bef425a) 88.42%.

❗ Current head bef425a differs from pull request most recent head c6e4deb. Consider uploading reports for the commit c6e4deb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## main #2794 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01% 
==========================================
Files 114 114 Lines 91806 91718 -88 Branches 91806 91718 -88 ==========================================
- Hits 81187 81101 -86 - Misses 8128 8134 +6 + Partials 2491 2483 -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

valentinewallace
valentinewallace reviewed Dec 14, 2023
View reviewed changes
Comment threadCHANGELOG.md
benthecarman
benthecarman reviewed Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
shaavan
shaavan reviewed Dec 15, 2023
View reviewed changes

@shaavanshaavan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG looks great!

There are a few PRs that were not mentioned in CHANGELOG. These PRs were either refactoring to internal functions, updates to log, or improvements to test, and hence no need to be mentioned in CHANGELOG.

List of unmentioned PRs

(not tagging them to prevent unnecessary referencing)

2613, 2669, 2693, 2668, 2686, 2682, 2641, 2558, 2702, 2732, 2726, 2746, 2741, 2512, 2755, 2739, 2766, 2769, 2771, 2642, 2764, 2773, 2762, 2765, 2691, 2776, 2774, 2782, 2786, 2637, 2787, 2703, 2790, 2792

I think out of these PRs, there are two that can require a CHANGELOG.

2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.

2741 Fixure of the double-back routing bug here can use a CHANGELOG.

@TheBlueMatt

TheBlueMatt commented Dec 15, 2023

Copy link
Copy Markdown
CollaboratorAuthor

#2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.

Fair, though the trait requirements are strictly relaxed. All existing code should compile just fine.

#2741 Fixure of the double-back routing bug here can use a CHANGELOG.

I'm not convinced. LDK will never generate such a route, and while users can, those routes might actually work (or might not, which in my case was true). We should reject them, but in general users should never see this rejection, and its really just a helpful notice to catch bugs in user code (which presumably they would have already fixed, if they had them).

@TheBlueMatt
TheBlueMattforce-pushed the 2023-12-cut-119 branch 4 times, most recently from 96abdd8 to bef425aCompareDecember 15, 2023 22:51
wpaulino
wpaulino reviewed Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment on lines +55 to +57
* Since 0.0.116, sending payments which required data in the onion for the
recipient which was too large for the onion may have caused corruption which
resulted in payment failure (#2752).

@wpaulinowpaulinoDec 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "which" do we want to keep 😂

@jkczyzjkczyzDec 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."

@TheBlueMattTheBlueMattDec 15, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "requiring...which" which seemed easier since

jkczyz
jkczyz reviewed Dec 15, 2023
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by nits

Comment threadCHANGELOG.md Outdated
time-fetch function, and `ScoreUpDate` methods now take the current time as a
`Duration` argument. This avoids fetching time during pathfinding (#2656).
* Receiving payments to multi-hop blinded paths is now supported (#2688).
* `MessageRouter` and `Router` now feature methods to blinded paths back to the

@jkczyzjkczyzDec 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to/to create

Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment on lines +55 to +57
* Since 0.0.116, sending payments which required data in the onion for the
recipient which was too large for the onion may have caused corruption which
resulted in payment failure (#2752).

@jkczyzjkczyzDec 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."

@TheBlueMatt

TheBlueMatt commented Dec 15, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Should be good to go now 🎉

@TheBlueMatt

TheBlueMatt commented Dec 15, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Oops, sorry, missed @jkczyz's review. Addressed.

@TheBlueMatt

TheBlueMatt commented Dec 16, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI Passed, multiple folks looked at it.

@TheBlueMatt
TheBlueMatt merged commit 4deb263 into lightningdevkit:mainDec 16, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes
+1 more reviewer
@shaavanshaavanshaavan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.0.119

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@codecov-commenter@jkczyz@wpaulino@valentinewallace@benthecarman@shaavan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Cut 0.0.119 by TheBlueMatt · Pull Request #2794 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.119 - #2794
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Dec 16, 2023
Merged
Cut 0.0.119#2794
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
Still need to finalize some comments, plus any new PRs, and bump crate versions.
@TheBlueMattTheBlueMatt
added this to the 0.0.119 milestone
Dec 14, 2023
@codecov-commenter
codecov-commenter
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (ef2156a) 88.43% compared to head (bef425a) 88.42%.
❗ Current head bef425a differs from pull request most recent head c6e4deb. Consider uploading reports for the commit c6e4deb to get more accurate results
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## main #2794 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01% 
==========================================
Files 114 114 Lines 91806 91718 -88 Branches 91806 91718 -88 ==========================================
- Hits 81187 81101 -86 - Misses 8128 8134 +6 + Partials 2491 2483 -8 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
valentinewallace
valentinewallace
reviewed
Dec 14, 2023
View reviewed changes
Comment threadCHANGELOG.md
benthecarman
benthecarman
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

shaavan
shaavan
reviewed
Dec 15, 2023
View reviewed changes
@shaavanshaavan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG looks great!
There are a few PRs that were not mentioned in CHANGELOG. These PRs were either refactoring to internal functions, updates to log, or improvements to test, and hence no need to be mentioned in CHANGELOG.

List of unmentioned PRs

(not tagging them to prevent unnecessary referencing)
2613, 2669, 2693, 2668, 2686, 2682, 2641, 2558, 2702, 2732, 2726, 2746, 2741, 2512, 2755, 2739, 2766, 2769, 2771, 2642, 2764, 2773, 2762, 2765, 2691, 2776, 2774, 2782, 2786, 2637, 2787, 2703, 2790, 2792
I think out of these PRs, there are two that can require a CHANGELOG.
2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
2741 Fixure of the double-back routing bug here can use a CHANGELOG.
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
#2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
Fair, though the trait requirements are strictly relaxed. All existing code should compile just fine.
#2741 Fixure of the double-back routing bug here can use a CHANGELOG.
I'm not convinced. LDK will never generate such a route, and while users can, those routes might actually work (or might not, which in my case was true). We should reject them, but in general users should never see this rejection, and its really just a helpful notice to catch bugs in user code (which presumably they would have already fixed, if they had them).
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-12-cut-119
branch
4 times, most recently
from
96abdd8 to
bef425aCompareDecember 15, 2023 22:51
wpaulino
wpaulino
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@wpaulinowpaulinoDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "which" do we want to keep 😂
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMattTheBlueMattDec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "requiring...which" which seemed easier since
jkczyz
jkczyz
reviewed
Dec 15, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by nits
Comment threadCHANGELOG.md
Outdated

 time-fetch function, and `ScoreUpDate` methods now take the current time as a
 `Duration` argument. This avoids fetching time during pathfinding (#2656).
 * Receiving payments to multi-hop blinded paths is now supported (#2688).
 * `MessageRouter` and `Router` now feature methods to blinded paths back to the
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to/to create
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Should be good to go now 🎉
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Oops, sorry, missed @jkczyz's review. Addressed.
@TheBlueMatt
TheBlueMatt
commented
Dec 16, 2023

Copy link


Copy Markdown

CollaboratorAuthor
CI Passed, multiple folks looked at it.
@TheBlueMatt
TheBlueMatt
merged commit 4deb263
into
lightningdevkit:mainDec 16, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes

+1 more reviewer

@shaavanshaavanshaavan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.119

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@codecov-commenter@jkczyz@wpaulino@valentinewallace@benthecarman@shaavan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Cut 0.0.119 by TheBlueMatt · Pull Request #2794 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.119 - #2794
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Dec 16, 2023
Merged
Cut 0.0.119#2794
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
Still need to finalize some comments, plus any new PRs, and bump crate versions.
@TheBlueMattTheBlueMatt
added this to the 0.0.119 milestone
Dec 14, 2023
@codecov-commenter
codecov-commenter
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (ef2156a) 88.43% compared to head (bef425a) 88.42%.
❗ Current head bef425a differs from pull request most recent head c6e4deb. Consider uploading reports for the commit c6e4deb to get more accurate results
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## main #2794 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01% 
==========================================
Files 114 114 Lines 91806 91718 -88 Branches 91806 91718 -88 ==========================================
- Hits 81187 81101 -86 - Misses 8128 8134 +6 + Partials 2491 2483 -8 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
valentinewallace
valentinewallace
reviewed
Dec 14, 2023
View reviewed changes
Comment threadCHANGELOG.md
benthecarman
benthecarman
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

shaavan
shaavan
reviewed
Dec 15, 2023
View reviewed changes
@shaavanshaavan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG looks great!
There are a few PRs that were not mentioned in CHANGELOG. These PRs were either refactoring to internal functions, updates to log, or improvements to test, and hence no need to be mentioned in CHANGELOG.

List of unmentioned PRs

(not tagging them to prevent unnecessary referencing)
2613, 2669, 2693, 2668, 2686, 2682, 2641, 2558, 2702, 2732, 2726, 2746, 2741, 2512, 2755, 2739, 2766, 2769, 2771, 2642, 2764, 2773, 2762, 2765, 2691, 2776, 2774, 2782, 2786, 2637, 2787, 2703, 2790, 2792
I think out of these PRs, there are two that can require a CHANGELOG.
2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
2741 Fixure of the double-back routing bug here can use a CHANGELOG.
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
#2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
Fair, though the trait requirements are strictly relaxed. All existing code should compile just fine.
#2741 Fixure of the double-back routing bug here can use a CHANGELOG.
I'm not convinced. LDK will never generate such a route, and while users can, those routes might actually work (or might not, which in my case was true). We should reject them, but in general users should never see this rejection, and its really just a helpful notice to catch bugs in user code (which presumably they would have already fixed, if they had them).
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-12-cut-119
branch
4 times, most recently
from
96abdd8 to
bef425aCompareDecember 15, 2023 22:51
wpaulino
wpaulino
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@wpaulinowpaulinoDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "which" do we want to keep 😂
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMattTheBlueMattDec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "requiring...which" which seemed easier since
jkczyz
jkczyz
reviewed
Dec 15, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by nits
Comment threadCHANGELOG.md
Outdated

 time-fetch function, and `ScoreUpDate` methods now take the current time as a
 `Duration` argument. This avoids fetching time during pathfinding (#2656).
 * Receiving payments to multi-hop blinded paths is now supported (#2688).
 * `MessageRouter` and `Router` now feature methods to blinded paths back to the
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to/to create
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Should be good to go now 🎉
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Oops, sorry, missed @jkczyz's review. Addressed.
@TheBlueMatt
TheBlueMatt
commented
Dec 16, 2023

Copy link


Copy Markdown

CollaboratorAuthor
CI Passed, multiple folks looked at it.
@TheBlueMatt
TheBlueMatt
merged commit 4deb263
into
lightningdevkit:mainDec 16, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes

+1 more reviewer

@shaavanshaavanshaavan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.119

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@codecov-commenter@jkczyz@wpaulino@valentinewallace@benthecarman@shaavan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Cut 0.0.119 by TheBlueMatt · Pull Request #2794 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.119 - #2794
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Dec 16, 2023
Merged
Cut 0.0.119#2794
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
Still need to finalize some comments, plus any new PRs, and bump crate versions.
@TheBlueMattTheBlueMatt
added this to the 0.0.119 milestone
Dec 14, 2023
@codecov-commenter
codecov-commenter
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (ef2156a) 88.43% compared to head (bef425a) 88.42%.
❗ Current head bef425a differs from pull request most recent head c6e4deb. Consider uploading reports for the commit c6e4deb to get more accurate results
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## main #2794 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01% 
==========================================
Files 114 114 Lines 91806 91718 -88 Branches 91806 91718 -88 ==========================================
- Hits 81187 81101 -86 - Misses 8128 8134 +6 + Partials 2491 2483 -8 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
valentinewallace
valentinewallace
reviewed
Dec 14, 2023
View reviewed changes
Comment threadCHANGELOG.md
benthecarman
benthecarman
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

shaavan
shaavan
reviewed
Dec 15, 2023
View reviewed changes
@shaavanshaavan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG looks great!
There are a few PRs that were not mentioned in CHANGELOG. These PRs were either refactoring to internal functions, updates to log, or improvements to test, and hence no need to be mentioned in CHANGELOG.

List of unmentioned PRs

(not tagging them to prevent unnecessary referencing)
2613, 2669, 2693, 2668, 2686, 2682, 2641, 2558, 2702, 2732, 2726, 2746, 2741, 2512, 2755, 2739, 2766, 2769, 2771, 2642, 2764, 2773, 2762, 2765, 2691, 2776, 2774, 2782, 2786, 2637, 2787, 2703, 2790, 2792
I think out of these PRs, there are two that can require a CHANGELOG.
2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
2741 Fixure of the double-back routing bug here can use a CHANGELOG.
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
#2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
Fair, though the trait requirements are strictly relaxed. All existing code should compile just fine.
#2741 Fixure of the double-back routing bug here can use a CHANGELOG.
I'm not convinced. LDK will never generate such a route, and while users can, those routes might actually work (or might not, which in my case was true). We should reject them, but in general users should never see this rejection, and its really just a helpful notice to catch bugs in user code (which presumably they would have already fixed, if they had them).
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-12-cut-119
branch
4 times, most recently
from
96abdd8 to
bef425aCompareDecember 15, 2023 22:51
wpaulino
wpaulino
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@wpaulinowpaulinoDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "which" do we want to keep 😂
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMattTheBlueMattDec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "requiring...which" which seemed easier since
jkczyz
jkczyz
reviewed
Dec 15, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by nits
Comment threadCHANGELOG.md
Outdated

 time-fetch function, and `ScoreUpDate` methods now take the current time as a
 `Duration` argument. This avoids fetching time during pathfinding (#2656).
 * Receiving payments to multi-hop blinded paths is now supported (#2688).
 * `MessageRouter` and `Router` now feature methods to blinded paths back to the
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to/to create
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Should be good to go now 🎉
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Oops, sorry, missed @jkczyz's review. Addressed.
@TheBlueMatt
TheBlueMatt
commented
Dec 16, 2023

Copy link


Copy Markdown

CollaboratorAuthor
CI Passed, multiple folks looked at it.
@TheBlueMatt
TheBlueMatt
merged commit 4deb263
into
lightningdevkit:mainDec 16, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes

+1 more reviewer

@shaavanshaavanshaavan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.119

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@codecov-commenter@jkczyz@wpaulino@valentinewallace@benthecarman@shaavan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Cut 0.0.119 by TheBlueMatt · Pull Request #2794 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.119 - #2794
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Dec 16, 2023
Merged
Cut 0.0.119#2794
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
Still need to finalize some comments, plus any new PRs, and bump crate versions.
@TheBlueMattTheBlueMatt
added this to the 0.0.119 milestone
Dec 14, 2023
@codecov-commenter
codecov-commenter
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (ef2156a) 88.43% compared to head (bef425a) 88.42%.
❗ Current head bef425a differs from pull request most recent head c6e4deb. Consider uploading reports for the commit c6e4deb to get more accurate results
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## main #2794 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01% 
==========================================
Files 114 114 Lines 91806 91718 -88 Branches 91806 91718 -88 ==========================================
- Hits 81187 81101 -86 - Misses 8128 8134 +6 + Partials 2491 2483 -8 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
valentinewallace
valentinewallace
reviewed
Dec 14, 2023
View reviewed changes
Comment threadCHANGELOG.md
benthecarman
benthecarman
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

shaavan
shaavan
reviewed
Dec 15, 2023
View reviewed changes
@shaavanshaavan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG looks great!
There are a few PRs that were not mentioned in CHANGELOG. These PRs were either refactoring to internal functions, updates to log, or improvements to test, and hence no need to be mentioned in CHANGELOG.

List of unmentioned PRs

(not tagging them to prevent unnecessary referencing)
2613, 2669, 2693, 2668, 2686, 2682, 2641, 2558, 2702, 2732, 2726, 2746, 2741, 2512, 2755, 2739, 2766, 2769, 2771, 2642, 2764, 2773, 2762, 2765, 2691, 2776, 2774, 2782, 2786, 2637, 2787, 2703, 2790, 2792
I think out of these PRs, there are two that can require a CHANGELOG.
2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
2741 Fixure of the double-back routing bug here can use a CHANGELOG.
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
#2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
Fair, though the trait requirements are strictly relaxed. All existing code should compile just fine.
#2741 Fixure of the double-back routing bug here can use a CHANGELOG.
I'm not convinced. LDK will never generate such a route, and while users can, those routes might actually work (or might not, which in my case was true). We should reject them, but in general users should never see this rejection, and its really just a helpful notice to catch bugs in user code (which presumably they would have already fixed, if they had them).
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-12-cut-119
branch
4 times, most recently
from
96abdd8 to
bef425aCompareDecember 15, 2023 22:51
wpaulino
wpaulino
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@wpaulinowpaulinoDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "which" do we want to keep 😂
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMattTheBlueMattDec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "requiring...which" which seemed easier since
jkczyz
jkczyz
reviewed
Dec 15, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by nits
Comment threadCHANGELOG.md
Outdated

 time-fetch function, and `ScoreUpDate` methods now take the current time as a
 `Duration` argument. This avoids fetching time during pathfinding (#2656).
 * Receiving payments to multi-hop blinded paths is now supported (#2688).
 * `MessageRouter` and `Router` now feature methods to blinded paths back to the
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to/to create
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Should be good to go now 🎉
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Oops, sorry, missed @jkczyz's review. Addressed.
@TheBlueMatt
TheBlueMatt
commented
Dec 16, 2023

Copy link


Copy Markdown

CollaboratorAuthor
CI Passed, multiple folks looked at it.
@TheBlueMatt
TheBlueMatt
merged commit 4deb263
into
lightningdevkit:mainDec 16, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes

+1 more reviewer

@shaavanshaavanshaavan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.119

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@codecov-commenter@jkczyz@wpaulino@valentinewallace@benthecarman@shaavan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Cut 0.0.119 by TheBlueMatt · Pull Request #2794 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.119 - #2794
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Dec 16, 2023
Merged
Cut 0.0.119#2794
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
Still need to finalize some comments, plus any new PRs, and bump crate versions.
@TheBlueMattTheBlueMatt
added this to the 0.0.119 milestone
Dec 14, 2023
@codecov-commenter
codecov-commenter
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (ef2156a) 88.43% compared to head (bef425a) 88.42%.
❗ Current head bef425a differs from pull request most recent head c6e4deb. Consider uploading reports for the commit c6e4deb to get more accurate results
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## main #2794 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01% 
==========================================
Files 114 114 Lines 91806 91718 -88 Branches 91806 91718 -88 ==========================================
- Hits 81187 81101 -86 - Misses 8128 8134 +6 + Partials 2491 2483 -8 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
valentinewallace
valentinewallace
reviewed
Dec 14, 2023
View reviewed changes
Comment threadCHANGELOG.md
benthecarman
benthecarman
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

shaavan
shaavan
reviewed
Dec 15, 2023
View reviewed changes
@shaavanshaavan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG looks great!
There are a few PRs that were not mentioned in CHANGELOG. These PRs were either refactoring to internal functions, updates to log, or improvements to test, and hence no need to be mentioned in CHANGELOG.

List of unmentioned PRs

(not tagging them to prevent unnecessary referencing)
2613, 2669, 2693, 2668, 2686, 2682, 2641, 2558, 2702, 2732, 2726, 2746, 2741, 2512, 2755, 2739, 2766, 2769, 2771, 2642, 2764, 2773, 2762, 2765, 2691, 2776, 2774, 2782, 2786, 2637, 2787, 2703, 2790, 2792
I think out of these PRs, there are two that can require a CHANGELOG.
2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
2741 Fixure of the double-back routing bug here can use a CHANGELOG.
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
#2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
Fair, though the trait requirements are strictly relaxed. All existing code should compile just fine.
#2741 Fixure of the double-back routing bug here can use a CHANGELOG.
I'm not convinced. LDK will never generate such a route, and while users can, those routes might actually work (or might not, which in my case was true). We should reject them, but in general users should never see this rejection, and its really just a helpful notice to catch bugs in user code (which presumably they would have already fixed, if they had them).
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-12-cut-119
branch
4 times, most recently
from
96abdd8 to
bef425aCompareDecember 15, 2023 22:51
wpaulino
wpaulino
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@wpaulinowpaulinoDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "which" do we want to keep 😂
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMattTheBlueMattDec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "requiring...which" which seemed easier since
jkczyz
jkczyz
reviewed
Dec 15, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by nits
Comment threadCHANGELOG.md
Outdated

 time-fetch function, and `ScoreUpDate` methods now take the current time as a
 `Duration` argument. This avoids fetching time during pathfinding (#2656).
 * Receiving payments to multi-hop blinded paths is now supported (#2688).
 * `MessageRouter` and `Router` now feature methods to blinded paths back to the
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to/to create
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Should be good to go now 🎉
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Oops, sorry, missed @jkczyz's review. Addressed.
@TheBlueMatt
TheBlueMatt
commented
Dec 16, 2023

Copy link


Copy Markdown

CollaboratorAuthor
CI Passed, multiple folks looked at it.
@TheBlueMatt
TheBlueMatt
merged commit 4deb263
into
lightningdevkit:mainDec 16, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes

+1 more reviewer

@shaavanshaavanshaavan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.119

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@codecov-commenter@jkczyz@wpaulino@valentinewallace@benthecarman@shaavan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Cut 0.0.119 by TheBlueMatt · Pull Request #2794 · lightningdevkit/rust-lightning · GitHub
Skip to content
Cut 0.0.119 - #2794
Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Dec 16, 2023
Merged
Cut 0.0.119#2794
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom 
TheBlueMatt:2023-12-cut-119
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
Still need to finalize some comments, plus any new PRs, and bump crate versions.
@TheBlueMattTheBlueMatt
added this to the 0.0.119 milestone
Dec 14, 2023
@codecov-commenter
codecov-commenter
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (ef2156a) 88.43% compared to head (bef425a) 88.42%.
❗ Current head bef425a differs from pull request most recent head c6e4deb. Consider uploading reports for the commit c6e4deb to get more accurate results
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## main #2794 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01% 
==========================================
Files 114 114 Lines 91806 91718 -88 Branches 91806 91718 -88 ==========================================
- Hits 81187 81101 -86 - Misses 8128 8134 +6 + Partials 2491 2483 -8 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
valentinewallace
valentinewallace
reviewed
Dec 14, 2023
View reviewed changes
Comment threadCHANGELOG.md
benthecarman
benthecarman
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

shaavan
shaavan
reviewed
Dec 15, 2023
View reviewed changes
@shaavanshaavan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG looks great!
There are a few PRs that were not mentioned in CHANGELOG. These PRs were either refactoring to internal functions, updates to log, or improvements to test, and hence no need to be mentioned in CHANGELOG.

List of unmentioned PRs

(not tagging them to prevent unnecessary referencing)
2613, 2669, 2693, 2668, 2686, 2682, 2641, 2558, 2702, 2732, 2726, 2746, 2741, 2512, 2755, 2739, 2766, 2769, 2771, 2642, 2764, 2773, 2762, 2765, 2691, 2776, 2774, 2782, 2786, 2637, 2787, 2703, 2790, 2792
I think out of these PRs, there are two that can require a CHANGELOG.
2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
2741 Fixure of the double-back routing bug here can use a CHANGELOG.
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
#2693 Trait requirements for a pub fn are altered here. And I believe it can use a CHANGELOG.
Fair, though the trait requirements are strictly relaxed. All existing code should compile just fine.
#2741 Fixure of the double-back routing bug here can use a CHANGELOG.
I'm not convinced. LDK will never generate such a route, and while users can, those routes might actually work (or might not, which in my case was true). We should reject them, but in general users should never see this rejection, and its really just a helpful notice to catch bugs in user code (which presumably they would have already fixed, if they had them).
@TheBlueMatt
TheBlueMattforce-pushed
the
2023-12-cut-119
branch
4 times, most recently
from
96abdd8 to
bef425aCompareDecember 15, 2023 22:51
wpaulino
wpaulino
reviewed
Dec 15, 2023
View reviewed changes
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@wpaulinowpaulinoDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "which" do we want to keep 😂
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMattTheBlueMattDec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with "requiring...which" which seemed easier since
jkczyz
jkczyz
reviewed
Dec 15, 2023
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by nits
Comment threadCHANGELOG.md
Outdated

 time-fetch function, and `ScoreUpDate` methods now take the current time as a
 `Duration` argument. This avoids fetching time during pathfinding (#2656).
 * Receiving payments to multi-hop blinded paths is now supported (#2688).
 * `MessageRouter` and `Router` now feature methods to blinded paths back to the
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to/to create
Comment threadCHANGELOG.md
Outdated

Comment threadCHANGELOG.md
Outdated


Comment on lines

+55
 to 
+57

 * Since 0.0.116, sending payments which required data in the onion for the
 recipient which was too large for the onion may have caused corruption which
 resulted in payment failure (#2752).
@jkczyzjkczyzDec 15, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither: "that ... and ..."
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Should be good to go now 🎉
@TheBlueMatt
TheBlueMatt
commented
Dec 15, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Oops, sorry, missed @jkczyz's review. Addressed.
@TheBlueMatt
TheBlueMatt
commented
Dec 16, 2023

Copy link


Copy Markdown

CollaboratorAuthor
CI Passed, multiple folks looked at it.
@TheBlueMatt
TheBlueMatt
merged commit 4deb263
into
lightningdevkit:mainDec 16, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@valentinewallacevalentinewallacevalentinewallace left review comments
@benthecarmanbenthecarmanbenthecarman left review comments
@wpaulinowpaulinowpaulino approved these changes

+1 more reviewer

@shaavanshaavanshaavan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

0.0.119

Development

Successfully merging this pull request may close these issues.

7 participants

@TheBlueMatt@codecov-commenter@jkczyz@wpaulino@valentinewallace@benthecarman@shaavan