Introduce Retry InvoiceRequest Flow by shaavan · Pull Request #3010 · lightningdevkit/rust-lightning

shaavan · 2024-04-22T12:09:15Z

resolves#2836

Description:

Add functionality to handle retrying the sending of invoice_request messages on new reply_paths that are still awaiting invoices.

Changes:

Introduced invoice_request as an optional field in the PendingOutboundPayments::AwaitingInvoice variant to accommodate instances without invoice requests.
Refactored logic from pay_for_offer to create invoice request messages into a separate function for reuse with retry message flow.
Implemented the retry_tick_occurred function in ChannelManager to handle generating invoice request messages for AwaitingInvoice payments and enqueueing them.
Added retry_tick_occurred to ln_background_processor with a timer duration of 5 seconds for timely retries without overwhelming the system with too many onion messages.

shaavan · 2024-04-26T17:57:14Z

Updated from pr3010.01 to pr3010.02 (diff):

Changes:

Introduce Readable impl for InvoiceRequest
Restructure commits.

shaavan · 2024-04-27T13:41:50Z

Updated from pr3010.02 to pr3010.03 (diff):

Updates:

Rebase on main, to resolve merge conflicts.
Fix ci

codecov-commenter · 2024-04-27T13:48:48Z

Codecov Report

Attention: Patch coverage is 95.09202% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (db905e8) to head (b1cd887).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	87.17%	5 Missing ⚠️
lightning/src/offers/invoice_request.rs	50.00%	0 Missing and 2 partials ⚠️
lightning/src/ln/outbound_payment.rs	98.07%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3010 +/- ##
==========================================
- Coverage 89.64% 89.64% -0.01% 
==========================================
Files 126 126 Lines 102251 102383 +132 Branches 102251 102383 +132 ==========================================
+ Hits 91666 91781 +115 - Misses 7863 7874 +11 - Partials 2722 2728 +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shaavan · 2024-04-29T09:23:37Z

Updated from pr3010.03 to pr3010.04 (diff):

Changes:

Introduce retry_tick_occurred test.

shaavan · 2024-05-03T12:52:32Z

Updated from pr3010.04 to pr3010.05 (diff):

Addressed @TheBlueMatt comments

Updates:

Removed the secondary timer in ln_background_processor.
Moved the retry_tick_occurred to a private function, and renamed it to retry_invoice_request_messages.
Decrease the FRESHNESS_TIMER duration, while introducing a call counter within timer_tick_occurred. This is done so that retry_invoice_request_messages can be called faster than the rest of the code without introducing a secondary timer.
Update the test appropriately.

shaavan · 2024-05-03T13:15:33Z

Updated from pr3010.05 to pr3010.06 (diff):

Update:

Rebase on main.
To keep the code consistent with the main, now the create_invoice_reqeust_message, and retry_invoice_request_messages functions return Result<(), Bolt12SemanticError>

shaavan · 2024-05-03T13:38:45Z

Updated from pr3010.06 to pr3010.07 (diff):

Update:

Replaced using unsafe with using internal Mutex variable for tracking call counts.

shaavan · 2024-05-13T16:47:39Z

Updated from pr3010.07 to pr3010.08 (diff):

Changes:

Rebase on main, to solve merge conflicts.

TheBlueMatt · 2024-05-13T20:08:44Z

I don't buy that we need a new counter. There's a lot of things that hang on the timer rate, but this is a great opportunity to redefine the constants in seconds and multiply out a rate. Looking at all the things we do in the timer tick, as far as I can tell the only one that doesn't have a counter and a limit constant already is timer_check_closing_negotiation_process, and it should be easy to add there.

shaavan · 2024-05-14T13:19:11Z

Hi Matt!
Thanks a lot for the suggestion!

I think this will definitely be a more maintainable way to handle this change than introducing a counter!
Worked out your suggestion in a separate PR since they were quite different from this one: #3065
Let me know if the approach seems sound!

Thanks a lot!

shaavan · 2024-06-10T13:08:39Z

Updated from pr3010.08 to pr3010.09 (diff):
Addressed @TheBlueMatt's comment

Update:

Rebase on main
Introduced a new approach for retrying invoice request messages.

Details:

This approach triggers InvoiceRequest retries when any ChannelMessageHandler's handler is invoked by any message from any peer.
It ensures that if an InvoiceRequest message fails to send on the first attempt due to network disconnection, it will retry as soon as we are back online and receive messages from our peer.
It guarantees that we only retry once for a given PendingOutboundPayment.
This approach allows retries independent of a sub-minute timer.

shaavan · 2024-06-12T11:21:32Z

Updated from pr3010.09 to pr3010.10 (diff):
Addressed @TheBlueMatt comments

Changes:

Update function name from retry_invoice_requests -> handle_message_received, so that it's more explicit about its calling behavior than specific functionality.
Move the function call to do_handle_message_without_peer_lock so that it can be triggered when any message from any peer for any handler is received.
Updated the code to generate awaiting_invoice_flag from pending_outbound_payments instead of serialising it.

shaavan · 2024-06-20T13:16:07Z

Updated from pr3010.10 to pr3010.11 (diff):

Changes:

Rebase on main, to resolve merge conflicts.

shaavan · 2024-06-20T13:16:28Z

@TheBlueMatt
A gentle ping! :)

shaavan · 2024-06-27T13:06:15Z

Updated from pr3010.11 to pr3010.12 (diff):
Addressed @TheBlueMatt comments

Changes:

Updated the handle_message_received documentation to be more generic, removing references to BOLT12.
Removed the return Result type for handle_message_received as the result was unused in the codebase.
Changed the TLV number of invoice_request to odd so that downgrade support is maintained.

shaavan · 2024-08-20T07:34:26Z

Updated from pr3010.22 to pr3010.23 (diff):

Changes:

Rebase on main to resolve merge conflicts.
Squash fixup commit
No changes to the approach in this version.

Range-Diff:

1: 115fab41 ! 1: 8abd02fd Add InvoiceRequest and Context Fields in AwaitingInvoice
@@ Metadata
Author: shaavan <shaavan.github@gmail.com>
## Commit message ##
- Add InvoiceRequest and Context Fields in AwaitingInvoice
+ Add InvoiceRequest and Nonce Fields in AwaitingInvoice
- - Introduced `InvoiceRequest` and `context` fields in the `AwaitingInvoice`
+ - Introduced `InvoiceRequest` and `nonce` fields in the `AwaitingInvoice`
to enable recreation of the `InvoiceRequest` message for retries if the
corresponding invoice is not received in time.
- Added `awaiting_invoice` flag to track pending outbound payments with
@@ lightning/src/ln/channelmanager.rs: where
@@ lightning/src/ln/channelmanager.rs: macro_rules! create_refund_builder { ($self: ident, $builder: ty) => {
let nonce = Nonce::from_entropy_source(entropy);
- let context = OffersContext::OutboundPayment { payment_id, nonce };
+ let context = OffersContext::OutboundPayment { payment_id, nonce, hmac: None };
- let path = $self.create_blinded_paths_using_absolute_expiry(context, Some(absolute_expiry))
+ let path = $self.create_blinded_paths_using_absolute_expiry(context.clone(), Some(absolute_expiry))
.and_then(|paths| paths.into_iter().next().ok_or(()))
@@ lightning/src/ln/channelmanager.rs: macro_rules! create_refund_builder { ($self:
$self.pending_outbound_payments
.add_new_awaiting_invoice(
- payment_id, expiration, retry_strategy, max_total_routing_fee_msat,
-+ payment_id, expiration, retry_strategy, max_total_routing_fee_msat, None, context
++ payment_id, expiration, retry_strategy, max_total_routing_fee_msat, None, nonce
)
.map_err(|_| Bolt12SemanticError::DuplicatePaymentId)?;
-@@ lightning/src/ln/channelmanager.rs: where
- let invoice_request = builder.build_and_sign()?;
- - let context = OffersContext::OutboundPayment { payment_id, nonce };
-- let reply_paths = self.create_blinded_paths(context)
-+ let reply_paths = self.create_blinded_paths(context.clone())
- .map_err(|_| Bolt12SemanticError::MissingPaths)?;
- - let _persistence_guard = PersistenceNotifierGuard::notify_on_drop(self);
@@ lightning/src/ln/channelmanager.rs: where
let expiration = StaleExpiration::TimerTicks(1);
self.pending_outbound_payments
.add_new_awaiting_invoice(
- payment_id, expiration, retry_strategy, max_total_routing_fee_msat
+ payment_id, expiration, retry_strategy, max_total_routing_fee_msat,
-+ Some(invoice_request.clone()), context,
++ Some(invoice_request.clone()), nonce,
)
.map_err(|_| Bolt12SemanticError::DuplicatePaymentId)?;
@@ lightning/src/ln/outbound_payment.rs: use bitcoin::hashes::Hash;
+use crate::blinded_path::message::OffersContext;
use crate::blinded_path::{IntroductionNode, NodeIdLookUp};
- use crate::blinded_path::payment::advance_path_by_one;
use crate::events::{self, PaymentFailureReason};
-@@ lightning/src/ln/outbound_payment.rs: use crate::ln::channelmanager::{EventCompletionAction, HTLCSource, PaymentId};
+ use crate::ln::types::{PaymentHash, PaymentPreimage, PaymentSecret};
+@@ lightning/src/ln/outbound_payment.rs: use crate::ln::features::Bolt12InvoiceFeatures;
use crate::ln::onion_utils;
use crate::ln::onion_utils::{DecodedOnionFailure, HTLCFailReason};
use crate::offers::invoice::Bolt12Invoice;
+use crate::offers::invoice_request::InvoiceRequest;
++use crate::offers::nonce::Nonce;
use crate::routing::router::{BlindedTail, InFlightHtlcs, Path, PaymentParameters, Route, RouteParameters, Router};
use crate::sign::{EntropySource, NodeSigner, Recipient};
use crate::util::errors::APIError;
@@ lightning/src/ln/outbound_payment.rs: pub(crate) enum PendingOutboundPayment {
retry_strategy: Retry,
max_total_routing_fee_msat: Option<u64>,
+ invoice_request: Option<InvoiceRequest>,
-+ context: OffersContext,
++ nonce: Option<Nonce>,
},
InvoiceReceived {
payment_hash: PaymentHash,
@@ lightning/src/ln/outbound_payment.rs: impl OutboundPayments {
&self, payment_id: PaymentId, expiration: StaleExpiration, retry_strategy: Retry,
- max_total_routing_fee_msat: Option<u64>
+ max_total_routing_fee_msat: Option<u64>, invoice_request: Option<InvoiceRequest>,
-+ context: OffersContext,
++ nonce: Nonce,
) -> Result<(), ()> {
let mut pending_outbounds = self.pending_outbound_payments.lock().unwrap();
match pending_outbounds.entry(payment_id) {
@@ lightning/src/ln/outbound_payment.rs: impl OutboundPayments {
retry_strategy,
max_total_routing_fee_msat,
+ invoice_request,
-+ context,
++ nonce: Some(nonce),
});
+ self.awaiting_invoice.store(true, Ordering::Release);
@@ lightning/src/ln/outbound_payment.rs: impl OutboundPayments {
+ }
+
+ let mut pending_outbound_payments = self.pending_outbound_payments.lock().unwrap();
-+ let invoice_requests = pending_outbound_payments.iter_mut()
-+ .filter_map(|(_, payment)| match payment {
-+ PendingOutboundPayment::AwaitingInvoice { invoice_request, context, ..} => {
-+ invoice_request.take().map(|req| (context.clone(), req))
++ let invoice_requests = pending_outbound_payments
++ .iter_mut()
++ .filter_map(|(payment_id, payment)| {
++ if let PendingOutboundPayment::AwaitingInvoice {
++ invoice_request, nonce: Some(nonce), ..
++ } = payment {
++ let context = OffersContext::OutboundPayment {
++ payment_id: *payment_id,
++ nonce: *nonce,
++ // TODO: hmac to be incorporated.
++ hmac: None,
++ };
++ invoice_request.take().map(|req| (context, req))
++ } else {
++ None
+ }
-+ _ => None,
+ })
+ .collect();
+
@@ lightning/src/ln/outbound_payment.rs: impl_writeable_tlv_based_enum_upgradable!(
(2, retry_strategy, required),
(4, max_total_routing_fee_msat, option),
+ (5, invoice_request, option),
-+ (6, context, required),
++ (7, nonce, option),
},
(7, InvoiceReceived) => {
(0, payment_hash, required),
@@ lightning/src/ln/outbound_payment.rs: mod tests {
- - use core::time::Duration;
- -+	use crate::blinded_path::message::OffersContext;
- use crate::blinded_path::EmptyNodeIdLookUp;
- use crate::events::{Event, PathFailure, PaymentFailureReason};
- use crate::ln::types::PaymentHash;
-@@ lightning/src/ln/outbound_payment.rs: mod tests {
+ use crate::ln::outbound_payment::{Bolt12PaymentError, OutboundPayments, Retry, RetryableSendFailure, StaleExpiration};
+ #[cfg(feature = "std")]
+ use crate::offers::invoice::DEFAULT_RELATIVE_EXPIRY;
++	use crate::offers::nonce::Nonce;
+ use crate::offers::offer::OfferBuilder;
+ use crate::offers::test_utils::*;
+ use crate::routing::gossip::NetworkGraph;
use crate::routing::router::{InFlightHtlcs, Path, PaymentParameters, Route, RouteHop, RouteParameters};
use crate::sync::{Arc, Mutex, RwLock};
use crate::util::errors::APIError;
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_err()
);
}
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_err()
);
}
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), None
-+ payment_id, expiration, Retry::Attempts(0), None, None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), None, None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
@@ lightning/src/ln/outbound_payment.rs: mod tests {
outbound_payments.add_new_awaiting_invoice(
payment_id, expiration, Retry::Attempts(0),
- Some(invoice.amount_msats() / 100 + 50_000)
-+ Some(invoice.amount_msats() / 100 + 50_000), None, OffersContext::Unknown {}
++ Some(invoice.amount_msats() / 100 + 50_000), None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
@@ lightning/src/ln/outbound_payment.rs: mod tests {
assert!(
outbound_payments.add_new_awaiting_invoice(
- payment_id, expiration, Retry::Attempts(0), Some(1234)
-+ payment_id, expiration, Retry::Attempts(0), Some(1234), None, OffersContext::Unknown {}
++ payment_id, expiration, Retry::Attempts(0), Some(1234), None, Nonce::try_from(&[0u8; 16][..]).unwrap()
).is_ok()
);
assert!(outbound_payments.has_pending_payments());
2: bf1d03b9 < -: -------- f: Include Nonce in AwaitingInvoice for context recreation
3: 9b1e056c ! 2: 1cc365ce Introduce enqueue_invoice_request Function
@@ Commit message
## lightning/src/ln/channelmanager.rs ##
@@ lightning/src/ln/channelmanager.rs: use crate::ln::outbound_payment::{OutboundPayments, PaymentAttempts, PendingOutb
use crate::ln::wire::Encode;
- use crate::offers::invoice::{BlindedPayInfo, Bolt12Invoice, DEFAULT_RELATIVE_EXPIRY, DerivedSigningPubkey, ExplicitSigningPubkey, InvoiceBuilder, UnsignedBolt12Invoice};
+ use crate::offers::invoice::{Bolt12Invoice, DEFAULT_RELATIVE_EXPIRY, DerivedSigningPubkey, ExplicitSigningPubkey, InvoiceBuilder, UnsignedBolt12Invoice};
use crate::offers::invoice_error::InvoiceError;
-use crate::offers::invoice_request::{DerivedPayerId, InvoiceRequestBuilder};
+use crate::offers::invoice_request::{DerivedPayerId, InvoiceRequest, InvoiceRequestBuilder};
@@ lightning/src/ln/channelmanager.rs: where
+	fn enqueue_invoice_request(
+ &self,
+ invoice_request: InvoiceRequest,
-+ reply_paths: Vec<BlindedPath>,
++ reply_paths: Vec<BlindedMessagePath>,
+	) -> Result<(), Bolt12SemanticError> {
let mut pending_offers_messages = self.pending_offers_messages.lock().unwrap();
- if !offer.paths().is_empty() {
4: e9fbabc9 = 3: 8a17319a Introduce handle_message_received in ChannelMessageHandler
5: 656dd95d ! 4: 6a9e9134 Introduce handle_message_received test
@@ lightning/src/ln/offers_tests.rs: fn creates_and_pays_for_offer_using_one_hop_bl
+	assert_ne!(offer.signing_pubkey(), Some(alice_id));
+	assert!(!offer.paths().is_empty());
+	for path in offer.paths() {
-+ assert_eq!(path.introduction_node, IntroductionNode::NodeId(alice_id));
++ assert_eq!(path.introduction_node(), &IntroductionNode::NodeId(alice_id));
+	}
+	let payment_id = PaymentId([1; 32]);
+	bob.node.pay_for_offer(&offer, None, None, None, payment_id, Retry::Attempts(0), None).unwrap();
@@ lightning/src/ln/offers_tests.rs: fn creates_and_pays_for_offer_using_one_hop_bl
+	});
+	assert_eq!(invoice_request.amount_msats(), None);
+	assert_ne!(invoice_request.payer_id(), bob_id);
-+	assert_eq!(reply_path.introduction_node, IntroductionNode::NodeId(bob_id));
++	assert_eq!(reply_path.introduction_node(), &IntroductionNode::NodeId(bob_id));
+	let onion_message = alice.onion_messenger.next_onion_message_for_peer(bob_id).unwrap();
+	bob.onion_messenger.handle_onion_message(&alice_id, &onion_message);
+
@@ lightning/src/ln/offers_tests.rs: fn creates_and_pays_for_offer_using_one_hop_bl
+	assert_eq!(invoice.amount_msats(), 10_000_000);
+	assert_ne!(invoice.signing_pubkey(), alice_id);
+	assert!(!invoice.payment_paths().is_empty());
-+	for (_, path) in invoice.payment_paths() {
-+ assert_eq!(path.introduction_node, IntroductionNode::NodeId(alice_id));
++	for path in invoice.payment_paths() {
++ assert_eq!(path.introduction_node(), &IntroductionNode::NodeId(alice_id));
+	}
+	route_bolt12_payment(bob, &[alice], &invoice);
+	expect_recent_payment!(bob, RecentPaymentDetails::Pending, payment_id);

shaavan · 2024-08-21T09:25:03Z

Updated from pr3010.23 to pr3010.24 (diff):
Addressed @vincenzopalazzo, and @jkczyz comments

Changes:

Introduce RetryableInvoiceRequest struct, which contains all the data required to recreate InvoiceRequest Messages.
Upgrade logging level from info to warn for invoice request retry failure case, and improve logging.

shaavan · 2024-08-22T12:21:08Z

Updated from pr3010.24 to pr3010.25 (diff):
Addressed @jkczyz comments

Changes:

Remove a redundant clone.
Rename handle_message_received -> message_received, and update docs to align with the function's purpose.
Move the message_received call to handle_message so that it is called before the "message handling" for any kind of message received.
Simplify a check in test.

TheBlueMatt

LGTM, feel free to squash.

shaavan · 2024-09-09T12:59:18Z

Updated from pr3010.25 to pr3010.26 (diff):
Addressed @TheBlueMatt comments

Update add_new_awaiting_invoice to only update the awaiting_invoice flag if there is some retryable_invoice_request.
Update message_received docs.

shaavan · 2024-09-10T09:49:10Z

Updated from pr3010.26 to pr3010.27 (diff):
Addressed @jkczyz comment

Changes:

Use a if conditional, instead of map for a more idiomatic construct for retryable_invoice_request.

shaavan · 2024-09-12T13:15:18Z

Updated from pr3010.27 to pr3010.28 (diff):
Addressed @jkczyz comment

Changes:

Moved the introduced test to the appropriate location.

1. To enable the retry of the Invoice Request message, it's necessary to store the essential data required to recreate the message. 2. A new struct is introduced to manage this data, ensuring the InvoiceRequest message can be reliably recreated for retries. 3. The addition of an `awaiting_invoice` flag allows tracking of retryable invoice requests, preventing the need to lock the `pending_outbound_payment` mutex.

1. Separate the logic of forming `invoice_request` messages from `invoice_request` and `reply_paths` and enqueueing them into a separate function. 2. This logic will be reused in the following commit when reforming `invoice_request` messages for retrying.

- Introduce the `message_received` function to manage the behavior when a message is received from any peer. - This function is used within `ChannelManager` to retry `InvoiceRequest` messages if we haven't received the corresponding invoice yet. - This change makes the offer communication robust against sudden connection drops where the initial attempt to send the message might have failed.

- Add a test to verify the functionality of the handle_message_received function. - Ensure the test covers scenarios where InvoiceRequest messages are retried for PendingOutboundPayments after a simulated connection loss.

shaavan · 2024-09-12T13:29:29Z

Updated from pr3010.28 to pr3010.29 (diff):

Changes:

Rebase on main to resolve merge conflicts.

Quick #3010 followups

shaavan force-pushed the issue2836 branch from fe09ff9 to 434c888Compare April 26, 2024 17:49

shaavan force-pushed the issue2836 branch from 434c888 to 7c4dd75Compare April 27, 2024 13:41

shaavan changed the title ~~Introduce Retry Invoice Flow~~Introduce Retry InvoiceRequest FlowApr 29, 2024

shaavan force-pushed the issue2836 branch from 9cc86bc to 80f5205Compare May 3, 2024 12:52

shaavan force-pushed the issue2836 branch from 80f5205 to dce32e7Compare May 3, 2024 13:15

shaavan force-pushed the issue2836 branch from dce32e7 to ff76783Compare May 3, 2024 13:38

shaavan force-pushed the issue2836 branch from ff76783 to 65b0fa3Compare May 13, 2024 16:47

shaavan mentioned this pull request May 15, 2024
Make timer_tick_occurred a second long timer #3065
Closed

shaavan force-pushed the issue2836 branch from 65b0fa3 to 4dd148dCompare June 10, 2024 13:08

TheBlueMatt reviewed Jun 11, 2024
View reviewed changes

Comment threadlightning/src/ln/msgs.rs Outdated
Comment threadlightning/src/ln/channelmanager.rs Outdated
Comment threadlightning/src/ln/channelmanager.rs Outdated

shaavan force-pushed the issue2836 branch from 4dd148d to 2566089Compare June 12, 2024 11:21

shaavan force-pushed the issue2836 branch from 2566089 to 286c5d3Compare June 20, 2024 13:16

jkczyz self-requested a review June 20, 2024 15:45

TheBlueMatt reviewed Jun 25, 2024
View reviewed changes

Comment threadlightning/src/ln/msgs.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/outbound_payment.rs Outdated
Comment threadlightning/src/ln/outbound_payment.rs Outdated

shaavan force-pushed the issue2836 branch from 286c5d3 to c8c3349Compare June 27, 2024 13:06

vincenzopalazzo reviewed Aug 16, 2024
View reviewed changes

Comment threadlightning/src/ln/outbound_payment.rs Outdated
Comment threadlightning/src/ln/channelmanager.rs Outdated

jkczyz reviewed Aug 16, 2024
View reviewed changes

Comment threadlightning/src/ln/outbound_payment.rs Outdated
Comment threadlightning/src/ln/outbound_payment.rs Outdated
Comment threadlightning/src/ln/channelmanager.rs Outdated
Comment threadlightning/src/ln/channelmanager.rs Outdated
Comment threadlightning/src/ln/outbound_payment.rs Outdated

shaavan force-pushed the issue2836 branch from 656dd95 to 6a9e913Compare August 20, 2024 07:34

shaavan force-pushed the issue2836 branch from 6a9e913 to c71ff98Compare August 21, 2024 09:25

jkczyz reviewed Aug 21, 2024
View reviewed changes

Comment threadlightning/src/ln/channelmanager.rs Outdated
Comment threadlightning/src/ln/msgs.rs Outdated
Comment threadlightning/src/ln/peer_handler.rs Outdated
Comment threadlightning/src/ln/offers_tests.rs Outdated

shaavan force-pushed the issue2836 branch from c71ff98 to 7ad9eadCompare August 22, 2024 12:21

jkczyz assigned TheBlueMatt Aug 22, 2024

TheBlueMatt reviewed Sep 6, 2024
View reviewed changes

Comment threadlightning/src/ln/outbound_payment.rs Outdated
Comment threadlightning/src/ln/msgs.rs

shaavan force-pushed the issue2836 branch from 7ad9ead to fe891f0Compare September 9, 2024 12:59

jkczyz reviewed Sep 9, 2024
View reviewed changes

Comment threadlightning/src/ln/outbound_payment.rs Outdated

shaavan force-pushed the issue2836 branch from fe891f0 to b5ca78bCompare September 10, 2024 09:48

jkczyz reviewed Sep 10, 2024
View reviewed changes

Comment threadlightning/src/ln/offers_tests.rs Outdated

shaavan force-pushed the issue2836 branch from b5ca78b to f42b055Compare September 12, 2024 13:15

shaavan added 4 commits September 12, 2024 18:47

Introduce handle_message_received test
b1cd887
- Add a test to verify the functionality of the handle_message_received function. - Ensure the test covers scenarios where InvoiceRequest messages are retried for PendingOutboundPayments after a simulated connection loss.

shaavan force-pushed the issue2836 branch from f42b055 to b1cd887Compare September 12, 2024 13:29

jkczyz approved these changes Sep 12, 2024
View reviewed changes

TheBlueMatt approved these changes Sep 12, 2024
View reviewed changes

TheBlueMatt merged commit 1059f5f into lightningdevkit:mainSep 12, 2024

shaavan deleted the issue2836 branch September 12, 2024 15:58

TheBlueMatt added a commit that referenced this pull request Sep 30, 2024
Merge pull request#3311from TheBlueMatt/2024-09-3010-followups
c7627df
Quick #3010 followups

Uh oh!

Conversation

shaavan commented Apr 22, 2024

Uh oh!

shaavan commented Apr 26, 2024

Uh oh!

shaavan commented Apr 27, 2024

Uh oh!

codecov-commenter commented Apr 27, 2024• edited by codecov BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shaavan commented Apr 29, 2024

Uh oh!

shaavan commented May 3, 2024

Uh oh!

shaavan commented May 3, 2024

Uh oh!

shaavan commented May 3, 2024

Uh oh!

shaavan commented May 13, 2024

Uh oh!

TheBlueMatt commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shaavan commented May 14, 2024

Uh oh!

shaavan commented Jun 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shaavan commented Jun 12, 2024

Uh oh!

shaavan commented Jun 20, 2024

Uh oh!

shaavan commented Jun 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shaavan commented Jun 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shaavan commented Aug 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shaavan commented Aug 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shaavan commented Aug 22, 2024

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shaavan commented Sep 9, 2024

Uh oh!

Uh oh!

shaavan commented Sep 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shaavan commented Sep 12, 2024

Uh oh!

shaavan commented Sep 12, 2024

Uh oh!

Reviewers

Assignees

codecov-commenter commented Apr 27, 2024•
edited by codecov Bot
Loading

TheBlueMatt commented May 13, 2024•
edited
Loading

shaavan commented Aug 20, 2024•
edited
Loading

shaavan commented Sep 10, 2024•
edited
Loading