') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add draft release notes for 0.0.123 by TheBlueMatt · Pull Request #3012 · lightningdevkit/rust-lightning · GitHub
Skip to content

Add draft release notes for 0.0.123 - #3012

Merged
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom
TheBlueMatt:2024-04-0.0.123-rl
May 8, 2024
Merged

Add draft release notes for 0.0.123#3012
TheBlueMatt merged 4 commits into
lightningdevkit:mainfrom
TheBlueMatt:2024-04-0.0.123-rl

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Apr 22, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (a27088d) to head (2804377).
Report is 27 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## main #3012 +/- ##
==========================================
+ Coverage 89.83% 90.57% +0.73% 
==========================================
Files 117 118 +1 Lines 96237 101950 +5713 Branches 96237 101950 +5713 ==========================================
+ Hits 86459 92340 +5881 + Misses 7215 7165 -50 + Partials 2563 2445 -118

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMattTheBlueMatt added this to the 0.0.123 milestone Apr 29, 2024
jkczyz
jkczyz reviewed Apr 29, 2024
View reviewed changes
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated

* `ChainMonitor::archive_fully_resolved_channel_monitors` is now provided to
remove `ChannelMonitor`s from memory which have been fully resolved on-chain
and now are not needed. It uses the new `Persist::archive_persisted_channel`

@jkczyzjkczyzApr 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/now are not/are no longer

@TheBlueMattTheBlueMattMay 1, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, causes the whole block to run another line...

Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
`ChannelManager::accept_inbound_channel` would previously have stalled from
the peer's perspective as no `error` message was sent (#2953).
* Blinded path construction has been tuned to select paths more likely to
succeed, improving BOLT12 payment reliability (#2911, #2912, XXX?).

@jkczyzjkczyzApr 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is another PR expected here?

@TheBlueMattTheBlueMattMay 1, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, sorry, I had recalled there being one but I'm wrong.

Comment threadCHANGELOG.md Outdated
valentinewallace
valentinewallace reviewed May 1, 2024
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md
* `ChannelManager` deserialization may now fail with `DangerousValue` when
LDK's persistence API was violated (#2974).

## Bug Fixes

@valentinewallacevalentinewallaceMay 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3021, #2971, #2951 could be mentioned?

@TheBlueMattTheBlueMattMay 3, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3021 - yea, this PR is older than that one, I'll go ahead and rebase it and add more PRs now.
2971 - it feels pretty internal implementation detail, I'm not sure I could concretely describe in a useful way what it fixes for users.
2951 - this too seems to fix a case that isn't super relevant usually. Its really only interesting in certain regtest setups where you're using non-announced introduction nodes.

@TheBlueMatt
TheBlueMattforce-pushed the 2024-04-0.0.123-rl branch 2 times, most recently from 23db855 to 50fb43cCompareMay 7, 2024 18:51
@TheBlueMatt

TheBlueMatt commented May 7, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Added update for #3045

valentinewallace
valentinewallace reviewed May 8, 2024
View reviewed changes
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md
BOLT11 invoices containing non-ASCII characters are invalid.

In total, this release features 150 files changed, 19307 insertions, 6306
deletions in 360 commits since 0.0.121 from 17 authors, in alphabetical order:

@valentinewallacevalentinewallaceMay 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/121/122?

@TheBlueMattTheBlueMattMay 8, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because 122 branched its annoying to try to figure out so I just did it against 121.

@TheBlueMatt
Add changelog entries for 0.0.123
df4a09a
@TheBlueMatt
Bump possiblyrandom to 0.2
2804377
I'd uploaded `possiblyrandom` 0.1 to reserve the crate name but
with a dummy library so now we need ot use 0.2 for the release.
@TheBlueMatt
TheBlueMatt merged commit 74c9f9b into lightningdevkit:mainMay 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes
@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.0.123

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt@codecov-commenter@jkczyz@valentinewallace